| Message ID | 20231207161430.2570611-1-robh@kernel.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4893147vqy;
Thu, 7 Dec 2023 08:15:39 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IH0p4AeqG/TLsJatnMAwKuU3oqnuZzGugveWVjDcCyXC0jjFX0+7WgwFQInvo5x8SQx7xzt
X-Received: by 2002:a05:6a21:609:b0:18f:d75b:80bf with SMTP id
ll9-20020a056a21060900b0018fd75b80bfmr2970819pzb.50.1701965738759;
Thu, 07 Dec 2023 08:15:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1701965738; cv=none;
d=google.com; s=arc-20160816;
b=vTk9AFvWls/9v8x8IiiLrVjLYm/T+8CZcQpf0XXzVLY3UfDYmv3r2nU5WZp98goVwT
IFl6yY/ZYmziVjK3/v+05rymI/99XikWVbWzYl27Th4r1g8AhjRHphxib01RWh2PuBic
Yh7pcjXhJvwkQyObUHZdxyxf9qNVRNv+N6I/Z96oNDbijIL6tIQLnvJuGqdm+dlwy6G1
gdGk97BeFVvZKmTxxsSHjEK4gDgRza9ickwcJI0/s4xtI9bw+XlWETiGWwUAgnZUqVj2
65tE0hznhrdKrp7TmjX0NWoCiccZZ1ettQ/TdHuOHrchhF69o8Beve93EwVKo6DNtLsj
Hr5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=/ZhzYoCpdG6VhiSR/L2EDWgRjEplV0sOkvK2BvrQlBY=;
fh=fmDm/WXcEBvTYVjeljbOV9ksAgPj4Amu+hI4AP8H7eE=;
b=PDEgbr8XIS0zwJuQQSG6PkG0dyJLEN0R4PJI2TpU3MiFMCrktbrQHALIPCwFOg4mNU
6RU4wniVYA6g+hgbZ7JlvDx1t3kjJU6nO9kvP0sn1Riez+u3cqZFqYWC+vjqOHlX3cQg
mSixtvlrzSEfwNswUZLQ8UUQrh+Ur3xmvKpjJV2/TGnQvUFYPt79xZPmrErydi+RWIFc
k9z778wrRkJBTwlBgTGQyVHukLTgAYytP5s0Cx28Yp1DyEs5TWwrIMgUKv4T4D/yAFnz
HpuraEW0XfVkeXiqMqdJi/JWlN6MX2YNz3QSIMKd5ofzvYJOOtJLpz1R8uWFI8mVGaBv
o2Jw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4])
by mx.google.com with ESMTPS id
ca40-20020a056a0206a800b005adba954597si1452756pgb.504.2023.12.07.08.15.38
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 07 Dec 2023 08:15:38 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
client-ip=2620:137:e000::3:4;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by howler.vger.email (Postfix) with ESMTP id 1198682A8570;
Thu, 7 Dec 2023 08:15:05 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235249AbjLGQO4 (ORCPT <rfc822;chrisfriedt@gmail.com>
+ 99 others); Thu, 7 Dec 2023 11:14:56 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49032 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235614AbjLGQOm (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 7 Dec 2023 11:14:42 -0500
Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com
[209.85.160.44])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA83E10E4
for <linux-kernel@vger.kernel.org>;
Thu, 7 Dec 2023 08:14:32 -0800 (PST)
Received: by mail-oa1-f44.google.com with SMTP id
586e51a60fabf-1fae0e518a4so1072018fac.0
for <linux-kernel@vger.kernel.org>;
Thu, 07 Dec 2023 08:14:32 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1701965672; x=1702570472;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=/ZhzYoCpdG6VhiSR/L2EDWgRjEplV0sOkvK2BvrQlBY=;
b=ibpKbcMCGJ9SW18Q10N5LzQcVL7Zt6AgMnzwsnLhSIWl5Sm0szJ5TeHEbjWTcWP9/b
Xjo3V9oXQfF2AEqx/W0HifCxDuoDLu1LeLiWwmb3vm3WW7N6Ccf83tURvi6Je8o6xkqo
f2LyzCTRdPr52OpmPvU56Qp0Yj/EzV1nPGIhyvbAXRfyhpZVedngrcyoAkwGRYAmgzgP
9tNi6ptTXf/cdZg3W4+RTHxWJ79UXPlpI1yD/ra3hqKUa+9IdGP7H7fbQ2o1Tt6NObmX
jeWyZ/iF4hj/WERWQbQjrqDQ1SxZGHB5MjTK0YJ3/EEwsR8KgDM40GnhfRGs5bBPuPe9
1Txg==
X-Gm-Message-State: AOJu0Yxl7cdyVZshkWxcvL2ii2q7r5v8XTzzIg1IM5YIbnT8YYu9zAF4
yaVsmks9yXKx9yV9oc+vDe1UH9VLRw==
X-Received: by 2002:a05:6870:ac21:b0:1fa:db2d:628c with SMTP id
kw33-20020a056870ac2100b001fadb2d628cmr1430930oab.8.1701965672023;
Thu, 07 Dec 2023 08:14:32 -0800 (PST)
Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net.
[66.90.144.107])
by smtp.gmail.com with ESMTPSA id
yl13-20020a05687c218d00b001fb17559927sm19102oab.48.2023.12.07.08.14.31
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 07 Dec 2023 08:14:31 -0800 (PST)
Received: (nullmailer pid 2570647 invoked by uid 1000);
Thu, 07 Dec 2023 16:14:30 -0000
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [PATCH] firmware: microchip: Replace of_device.h with explicit
include
Date: Thu, 7 Dec 2023 10:14:30 -0600
Message-ID: <20231207161430.2570611-1-robh@kernel.org>
X-Mailer: git-send-email 2.42.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]);
Thu, 07 Dec 2023 08:15:06 -0800 (PST)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1784640426334230254
X-GMAIL-MSGID: 1784640426334230254
|
| Series |
firmware: microchip: Replace of_device.h with explicit include
|
|
Commit Message
Rob Herring
Dec. 7, 2023, 4:14 p.m. UTC
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it was merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. Soon the implicit includes are going to be removed.
of_device.h isn't needed, but platform_device.h is.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/firmware/microchip/mpfs-auto-update.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
From: Conor Dooley <conor.dooley@microchip.com> On Thu, 07 Dec 2023 10:14:30 -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. Soon the implicit includes are going to be removed. > > of_device.h isn't needed, but platform_device.h is. > > [...] Sorry about that Rob.. I'll also add the maintainers coverage you noticed was missing. [1/1] firmware: microchip: Replace of_device.h with explicit include https://git.kernel.org/conor/c/405820eae72f Thanks, Conor.
diff --git a/drivers/firmware/microchip/mpfs-auto-update.c b/drivers/firmware/microchip/mpfs-auto-update.c index d56a95b36b85..81f5f62e34fc 100644 --- a/drivers/firmware/microchip/mpfs-auto-update.c +++ b/drivers/firmware/microchip/mpfs-auto-update.c @@ -14,7 +14,7 @@ #include <linux/math.h> #include <linux/module.h> #include <linux/mtd/mtd.h> -#include <linux/of_device.h> +#include <linux/platform_device.h> #include <linux/sizes.h> #include <soc/microchip/mpfs.h>