From patchwork Thu Dec 7 14:13:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 175160 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4812231vqy; Thu, 7 Dec 2023 06:18:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7pLeLcBar1nfbKpkcSz66dG1700NK96FIvj8Qv1ACvtDFltAs6K4Tmj3/nJnWZ2QLAN4O X-Received: by 2002:a05:6a20:3c90:b0:18b:902f:88fe with SMTP id b16-20020a056a203c9000b0018b902f88femr3121053pzj.9.1701958720374; Thu, 07 Dec 2023 06:18:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701958720; cv=none; d=google.com; s=arc-20160816; b=msEkG8l9dN68vVLCPzFFuohzBywmlzlDeQpRpWHdpSloX9q1ldhyxG4jlQv7yDqTLl qRWeREutv03wuck+wUbo6hLpB4djiroEi5ZMJjwADe8LtL5fkx6DFwLej4l/lY3urFHq 9VT1OKjitwOz0VrPP9oo+Y2EoVDYT+8h7x9FeT8gJttCa/fScDydFsR5KQSPlYlBBTL3 Kl8Mod+1DuVRd/laofNmrpv9C5j6wbLLrPE922XqI/kmwXx+7GcwfDP6/AUqBhi+mLK4 hN42NEtK+RELEoqWVjei4t4JcyGwKiWImdBJHfdwCeIaLf1zWHexyfIR6f2G6Lv65OSy 0WkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sovyoawCuHPIC3BGXACLSdhYBPDtlBypfblslGEc6KU=; fh=2EyuYZuFv7pvbWODgXyYvSVo1Jt/nOD9U4n59BuOM5Q=; b=ngtGpGNbYnQiHJRxnYMPdIzbWod6Mm93VoS2TY6r3pp4kyu2PHAKm/MEzDGrPhtPyj fJAP1JVWuhzIS18zQhHYo1GhUJcvDEtSHnsHRE6EWazQ6RjM1Li84HevMArVMKspBzOO rqt54468d5qJ/Ex0bpbWuSKooAHQVFbPPHXKEjNq3GutE45ZKicw2NfFqFe7KkjLHzaR h8iYz0khZHhUkANldMv4Ysh4kcnNIr8bdt8Ww4iv7K2ygm6IJwiKp2SzcogjISl9RUsk aUH1CKnY5+PF2jQqreQSsY3ftxx8WoCFNBm2RFUaZaxmyTiaqlcYaAx/kdolojeew71W e0sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dcrC1Z3x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id 131-20020a630289000000b005bdfd3a26a0si1243682pgc.584.2023.12.07.06.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 06:18:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dcrC1Z3x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 58A5180B81E2; Thu, 7 Dec 2023 06:18:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443367AbjLGOSK (ORCPT + 99 others); Thu, 7 Dec 2023 09:18:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443272AbjLGORd (ORCPT ); Thu, 7 Dec 2023 09:17:33 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1449A1987; Thu, 7 Dec 2023 06:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701958642; x=1733494642; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+yrYKiXrfmH57CrIvqkWlnC8Sznz69h4K5xSraBupEU=; b=dcrC1Z3xW601XZPaDEvx2khZxiaAvsepojBXnP9rs6gqtkA0r7ITNgJF pCMrwPsyJQkoaa0vJeoByWCEh+zEoBJsUOpDCcwaLxXjw8L7/9w6K8vCL rJqFhe1uNmTDJ9+x4f4ifT6oGxBustHxQ68yd5R09WglE/k8aEHjysYj1 sglxT+KIsAtvefSG82pzDqvXkKRCwduuAyR3RgnUQQs7JnKjHro2pbvth mJItT+ADbNkNpY468yJSJM0aAoRuaOGlvZf4TAL2Xz6nH7Und6CP1YUAi 05EuDL44bfIT2snofd3YwnCmRSbTkLO0Gtnx/MPy5eVvC8hLJ6YiK7iOY A==; X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="460726199" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="460726199" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 06:17:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="889756103" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="889756103" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 07 Dec 2023 06:17:11 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5927ACC8; Thu, 7 Dec 2023 16:17:03 +0200 (EET) From: Andy Shevchenko To: Mario Limonciello , Jarkko Nikula , Herbert Xu , Andy Shevchenko , Wolfram Sang , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Philipp Zabel , Serge Semin Subject: [PATCH v5 19/24] i2c: designware: Uninline i2c_dw_probe() Date: Thu, 7 Dec 2023 16:13:59 +0200 Message-ID: <20231207141653.2785124-20-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231207141653.2785124-1-andriy.shevchenko@linux.intel.com> References: <20231207141653.2785124-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 07 Dec 2023 06:18:39 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784633067273256395 X-GMAIL-MSGID: 1784633067273256395 Since i2c_dw_probe() might be extended in the future, uninline it to reduce the noise in the common header. Reviewed-by: Andi Shyti Tested-by: Serge Semin Acked-by: Jarkko Nikula Link: https://lore.kernel.org/r/20231120144641.1660574-20-andriy.shevchenko@linux.intel.com Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-common.c | 14 ++++++++++++++ drivers/i2c/busses/i2c-designware-core.h | 17 ++--------------- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 7c877e380605..1d213bc0bbfa 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -714,6 +714,20 @@ void i2c_dw_disable(struct dw_i2c_dev *dev) } EXPORT_SYMBOL_GPL(i2c_dw_disable); +int i2c_dw_probe(struct dw_i2c_dev *dev) +{ + switch (dev->mode) { + case DW_IC_SLAVE: + return i2c_dw_probe_slave(dev); + case DW_IC_MASTER: + return i2c_dw_probe_master(dev); + default: + dev_err(dev->dev, "Wrong operation mode: %d\n", dev->mode); + return -EINVAL; + } +} +EXPORT_SYMBOL_GPL(i2c_dw_probe); + static int i2c_dw_prepare(struct device *device) { /* diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index f6ebf86dcc6f..7479cb3a450d 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -10,9 +10,7 @@ */ #include -#include #include -#include #include #include #include @@ -367,19 +365,6 @@ static inline void i2c_dw_configure_slave(struct dw_i2c_dev *dev) { } static inline int i2c_dw_probe_slave(struct dw_i2c_dev *dev) { return -EINVAL; } #endif -static inline int i2c_dw_probe(struct dw_i2c_dev *dev) -{ - switch (dev->mode) { - case DW_IC_SLAVE: - return i2c_dw_probe_slave(dev); - case DW_IC_MASTER: - return i2c_dw_probe_master(dev); - default: - dev_err(dev->dev, "Wrong operation mode: %d\n", dev->mode); - return -EINVAL; - } -} - static inline void i2c_dw_configure(struct dw_i2c_dev *dev) { if (i2c_detect_slave_mode(dev->dev)) @@ -388,6 +373,8 @@ static inline void i2c_dw_configure(struct dw_i2c_dev *dev) i2c_dw_configure_master(dev); } +int i2c_dw_probe(struct dw_i2c_dev *dev); + #if IS_ENABLED(CONFIG_I2C_DESIGNWARE_BAYTRAIL) int i2c_dw_baytrail_probe_lock_support(struct dw_i2c_dev *dev); #endif