Message ID | 20231207080235.652719-1-andyshrk@163.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4621295vqy; Thu, 7 Dec 2023 00:04:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHnqVz1UjjFSIzGRbYN6a56jHD+z4Z82yAtE+txYFTPhHQ4mmCjf9mkquTl/VrutAOi+lx X-Received: by 2002:a05:6870:1488:b0:1fb:75b:2fae with SMTP id k8-20020a056870148800b001fb075b2faemr2261965oab.69.1701936263332; Thu, 07 Dec 2023 00:04:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701936263; cv=none; d=google.com; s=arc-20160816; b=xiL92ZcZkzl0ALf2/wZeDN19QvkYdfN5anqHziDX1H6n9inSBM8Fz+VBU5Px7CXI3X kAZ8MvuK7+PsY3JSXNvANQoUvD0mDhYzEQBXQ0CkXCElvoow+UgTANXJm0SiDNNwJ9C7 JTjDZtiDionmLQWhicBu9TNHZYqBFmEBOv+6381/Je46qdy7/QP05xedQrEQR1YcXQ3w fKZrVrUmbqE6UA0YR58RBLrBIF+Ajy0WJpuFDspFpJX7lmCFnARBYn+0qK6NKwG/TLBv 6wfB0PzQRW0Ow/irZWrGBcG6e5sqTNhTscNSO+FtEhSrHh/4GzwdD3+/c1tdPVPuKFWd s8ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EagjjKWNWKSpKBM+wTEZQyp+boVbVHbVzJJ39PCuk0M=; fh=UxFpKtBK5VEiehKMA7YEJ/g9njmupgYZNYvE1WeoN9M=; b=d+gHMl4MxuYZGH8VFlUQx90zBFOK8flAwOoTV8QFJCVBKLy9zqdQZO15WDe5xgXUi6 YW/xc0ogj2IitEP/+aat+U1mQmVYXeCXduTowV8AvMI9UB7TnmbZgdLMEgsAT2B39RqR IJBXAEeONzKm8fSrtxTQpHJnqoIXRhx+7VIL00WBxy+dD60h+5jvgozmcTEcWle+f5Qs wVpPBkIlQDq7UPydFjj7wpfWHN7Y4l8s3KSUy+LMQlpkbTNYQdT7gJZHgWjTRPLjOrBt c2Kdcivr3gWmJgTXZET0FhPCadlsbWXfQ+nMG1sO7lv+yNqrQzxRzyCnKM3uavMXmOzk G5hQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=TfUvT0RU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id e8-20020a63e008000000b005c660726916si722560pgh.515.2023.12.07.00.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 00:04:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=TfUvT0RU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C433A801B49F; Thu, 7 Dec 2023 00:04:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378139AbjLGIEF (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Thu, 7 Dec 2023 03:04:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378293AbjLGIDs (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 7 Dec 2023 03:03:48 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A40621715; Thu, 7 Dec 2023 00:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Eagjj KWNWKSpKBM+wTEZQyp+boVbVHbVzJJ39PCuk0M=; b=TfUvT0RUFYc7U2/AlB+F5 UFEjE8ZxIUvKFTTlvaIjLSSd5yLel5Jek3mV1A833tuQNQkFRyizA1xoAYACBvzx ng4IYufs223SmaK8LluDXg0ozVxzHLEE4PXq6eGZ0+3LZc1Lg54jmxsI7oOuV+b4 DTT0vhR4f8h5Mkgv0S7qYE= Received: from ProDesk.. (unknown [58.22.7.114]) by zwqz-smtp-mta-g4-0 (Coremail) with SMTP id _____wD3_wsefHFlU2WcEw--.43577S2; Thu, 07 Dec 2023 16:02:41 +0800 (CST) From: Andy Yan <andyshrk@163.com> To: heiko@sntech.de Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, kever.yang@rock-chips.com, chris.obbard@collabora.com, Andy Yan <andy.yan@rock-chips.com> Subject: [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588 Date: Thu, 7 Dec 2023 16:02:35 +0800 Message-Id: <20231207080235.652719-1-andyshrk@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231207075906.651771-1-andyshrk@163.com> References: <20231207075906.651771-1-andyshrk@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wD3_wsefHFlU2WcEw--.43577S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF45ZrW7uFyDKrWfAryxKrg_yoWDJrX_C3 WxZw45XF4rtFWF93WDA3yfGFyDCw42kr1kXa9YkF1vya4q9rykKr93J34rAr4rWr47uF9a 93WS9ry3WF9xGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8KFAPUUUUU== X-Originating-IP: [58.22.7.114] X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbBEgM-XmVOA0XAIwAAs+ X-Spam-Status: No, score=0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SORBS_WEB, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 00:04:21 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784609519574315650 X-GMAIL-MSGID: 1784609519574315650 |
Series |
Add VOP2 support on rk3588
|
|
Commit Message
Andy Yan
Dec. 7, 2023, 8:02 a.m. UTC
From: Andy Yan <andy.yan@rock-chips.com> Add a Rockchip RK3588 compatible Signed-off-by: Andy Yan <andy.yan@rock-chips.com> --- Changes in v4: - Add const for rockchip,rk3588-iommu compatible .../devicetree/bindings/iommu/rockchip,iommu.yaml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
Comments
Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan: > From: Andy Yan <andy.yan@rock-chips.com> > > Add a Rockchip RK3588 compatible > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> In the next iteration, please split this out into a separate patch and send it to the iommu+dt maintainers. Supporting the iommus on rk3588 can be realized separately and the patch needs to go through a separate tree anyway. Thanks Heiko
On 07/12/2023 09:02, Andy Yan wrote: > From: Andy Yan <andy.yan@rock-chips.com> > > Add a Rockchip RK3588 compatible > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Heiko: On 12/9/23 00:29, Heiko Stübner wrote: > Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan: >> From: Andy Yan <andy.yan@rock-chips.com> >> >> Add a Rockchip RK3588 compatible >> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > In the next iteration, please split this out into a separate patch and send > it to the iommu+dt maintainers. > > Supporting the iommus on rk3588 can be realized separately and the > patch needs to go through a separate tree anyway. Okay, I will split this patch out of this vop2 series, does this mean that I also need to split out the iommu dt node as a separate patch from current PATCH16 ? > > > Thanks > Heiko > > >
Hi Andy, Am Samstag, 9. Dezember 2023, 02:26:25 CET schrieb Andy Yan: > Hi Heiko: > > On 12/9/23 00:29, Heiko Stübner wrote: > > Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan: > >> From: Andy Yan <andy.yan@rock-chips.com> > >> > >> Add a Rockchip RK3588 compatible > >> > >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > > In the next iteration, please split this out into a separate patch and send > > it to the iommu+dt maintainers. > > > > Supporting the iommus on rk3588 can be realized separately and the > > patch needs to go through a separate tree anyway. > > Okay, I will split this patch out of this vop2 series, does this mean that > I also need to split out the iommu dt node as a separate patch from current > PATCH16 ? no :-) . The vop-iommu can stay together with the vop core node. As adding the actual vop iommu is very much tied to the vop node. For the iommu-compatible it was different. The compatible just declares that the iommu acts similar to the one on rk3568, so is related to the iommu driver itself and should go through the iommu tree. So all is good here. Heiko
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml index ba9124f721f1..621dde0e45d8 100644 --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml @@ -19,9 +19,14 @@ description: |+ properties: compatible: - enum: - - rockchip,iommu - - rockchip,rk3568-iommu + oneOf: + - enum: + - rockchip,iommu + - rockchip,rk3568-iommu + - items: + - enum: + - rockchip,rk3588-iommu + - const: rockchip,rk3568-iommu reg: items: