From patchwork Thu Dec 7 17:56:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Patchwork-Id: 175317 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4960313vqy; Thu, 7 Dec 2023 09:57:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzAtQnBgbfnis9qW2pggQVD+aABdhqvTPIvhFWuT8KcHSD6auV486hpyDubPSLJicNzA2Z X-Received: by 2002:a17:90b:38d1:b0:286:bf89:5db7 with SMTP id nn17-20020a17090b38d100b00286bf895db7mr2574374pjb.39.1701971829638; Thu, 07 Dec 2023 09:57:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701971829; cv=none; d=google.com; s=arc-20160816; b=a4B6JhQh+RquNUUO8aLJt/3yQcd1H+zB53Rw9RHA02H6WipvqJTBeAaGrM80UW3NWf jsmMG/hb5mjTxg9RZC8eg+cMf08W9ehy8Wc5mX1z1A17E7mM6FIfdwvM6Dm4H6sZaGmx YWYPOg1QyY1X4ANUrhWxBuaAsFmmqfmI84+DXJH/Q5+pQw78zdA8qeIYxSR0ZEyIqlG3 2BJyC+aQbjiKwfJZU9VtB+eQ9sS0ntPWTeI69o4P0Xi/upGJVTqS01d5tqRk7hR++h2N XOODiN5nYjnPEM8ZVckfRK97BOdXXY/qVh+4u0ijAng9qFFUmZYsgg+v2WYq1rGv0lfB YaOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=vddebcTO/XfK+NsS92vVFiknvcfiWXWgXyXdZyT4bP0=; fh=AHZzcI0NKFNU1WuuS/FWF2LprSMGsTAGL8gmMiTfjNU=; b=KLinDLssA713fosnPAIF0bsDkskK5SEyAz1LFSzxVkFtKLXtbTF1bRplk+k7GMauwv UL/oJ2WOmpf/uW9yqQ1DhRUvjLoNHwvrS5HpHv4cwsgJXUKoBhMUtPnkkqk+7P0ZRanl ISMr8Aeob+/euQqBbY96UrII89fwZT0ZFLShSAr1UnC2B5vhLdsOJU0Tje3pdQFUibwj uFxtqZ8kHUdSoRarmLEqLNCwww0GPwcPttPzTmovBtpqYzv+aaZcgNyrz45/vdIxsQHO epOwo3ToZ62zs2izNhTBfls0VEDwxYe++EuRwJYqsGlZxL4ZAz36jRB07iS4AfwCigbg KVoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=ByQSsCmD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id w2-20020a17090a4f4200b002865a41a91dsi186791pjl.138.2023.12.07.09.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 09:57:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=ByQSsCmD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 0FF758029120; Thu, 7 Dec 2023 09:57:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443634AbjLGR4f (ORCPT + 99 others); Thu, 7 Dec 2023 12:56:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235234AbjLGR40 (ORCPT ); Thu, 7 Dec 2023 12:56:26 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3CFA171F; Thu, 7 Dec 2023 09:56:31 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4435FE000B; Thu, 7 Dec 2023 17:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701971790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vddebcTO/XfK+NsS92vVFiknvcfiWXWgXyXdZyT4bP0=; b=ByQSsCmDNvqeJZ9UKc1E0XnSRolzRN7rrRquwZB4Omb61enhukjtOwY+Tp+MflhtXrNdHW W4nXC3RZXL+tD47emkU2NkjveM7NkwOaXtA15Axu6A56EHt6Osh+Q3NUx/bSsDqQrXHdN5 ow+leHrI1j9UjsSmkY0q03hRyJsRj/sV7ChveBYyqlL5GnEnIfCB3vSGe0hhjd9eqS9Kj0 krR04/HZLemKSNqx1RNJL0hifCMvSB2f3Mlxt3Xl1JeIc1bhm5sURcIxBk73n68mfeKXya DWmeADJBBMMvADsauI5BQ+BheNCmokJL00RR/l3S4x8nUY5IjcFO2IPYnVdsmA== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Date: Thu, 07 Dec 2023 18:56:09 +0100 Subject: [PATCH v6 4/8] tty: serial: amba-pl011: avoid quoted string split across lines MIME-Version: 1.0 Message-Id: <20231207-mbly-uart-v6-4-e384afa5e78c@bootlin.com> References: <20231207-mbly-uart-v6-0-e384afa5e78c@bootlin.com> In-Reply-To: <20231207-mbly-uart-v6-0-e384afa5e78c@bootlin.com> To: Russell King , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Linus Walleij , =?utf-8?q?Gr=C3=A9gory_Clement?= , Alexandre Belloni , Thomas Petazzoni , Vladimir Kondratiev , Tawfik Bayouk , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?T?= =?utf-8?q?h=C3=A9o_Lebrun?= X-Mailer: b4 0.12.4 X-GND-Sasl: theo.lebrun@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 07 Dec 2023 09:57:07 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784646813189105436 X-GMAIL-MSGID: 1784646813189105436 Remove all instances of quoted strings split across lines. Fix four checkpatch warnings: $ ./scripts/checkpatch.pl --strict --file \ drivers/tty/serial/amba-pl011.c WARNING: quoted string split across lines [...] Reviewed-by: Ilpo Järvinen Reviewed-by: Linus Walleij Signed-off-by: Théo Lebrun --- drivers/tty/serial/amba-pl011.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 743dee75c68b..be8888db1a37 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -973,8 +973,8 @@ static void pl011_dma_rx_irq(struct uart_amba_port *uap) /* Switch buffer & re-trigger DMA job */ dmarx->use_buf_b = !dmarx->use_buf_b; if (pl011_dma_rx_trigger_dma(uap)) { - dev_dbg(uap->port.dev, "could not retrigger RX DMA job " - "fall back to interrupt mode\n"); + dev_dbg(uap->port.dev, + "could not retrigger RX DMA job fall back to interrupt mode\n"); uap->im |= UART011_RXIM; pl011_write(uap->im, uap, REG_IMSC); } @@ -1021,8 +1021,8 @@ static void pl011_dma_rx_callback(void *data) * get some IRQ immediately from RX. */ if (ret) { - dev_dbg(uap->port.dev, "could not retrigger RX DMA job " - "fall back to interrupt mode\n"); + dev_dbg(uap->port.dev, + "could not retrigger RX DMA job fall back to interrupt mode\n"); uap->im |= UART011_RXIM; pl011_write(uap->im, uap, REG_IMSC); } @@ -1158,8 +1158,8 @@ static void pl011_dma_startup(struct uart_amba_port *uap) if (uap->using_rx_dma) { if (pl011_dma_rx_trigger_dma(uap)) - dev_dbg(uap->port.dev, "could not trigger initial " - "RX DMA job, fall back to interrupt mode\n"); + dev_dbg(uap->port.dev, + "could not trigger initial RX DMA job, fall back to interrupt mode\n"); if (uap->dmarx.poll_rate) { timer_setup(&uap->dmarx.timer, pl011_dma_rx_poll, 0); mod_timer(&uap->dmarx.timer, @@ -1391,8 +1391,8 @@ __acquires(&uap->port.lock) */ if (pl011_dma_rx_available(uap)) { if (pl011_dma_rx_trigger_dma(uap)) { - dev_dbg(uap->port.dev, "could not trigger RX DMA job " - "fall back to interrupt mode again\n"); + dev_dbg(uap->port.dev, + "could not trigger RX DMA job fall back to interrupt mode again\n"); uap->im |= UART011_RXIM; pl011_write(uap->im, uap, REG_IMSC); } else {