From patchwork Wed Dec 6 23:17:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 174774 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4438504vqy; Wed, 6 Dec 2023 15:18:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6+uQNFgi0cYHNmtIf0FasaKXEbLwOq+rDTznIOlUSd2ccUB2GAehyPfrZcTlzrs4rNnUS X-Received: by 2002:a17:90a:4ca2:b0:286:a50d:96f1 with SMTP id k31-20020a17090a4ca200b00286a50d96f1mr1511349pjh.24.1701904717537; Wed, 06 Dec 2023 15:18:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701904717; cv=none; d=google.com; s=arc-20160816; b=FVKmGXuEle4oWLQ2I5/Bs75mWPw5guGAICwTqJGpEVSnpm8+iWn2kb3KrinTDKlvOw O4q2PA6XX62U8ogJJYf+IleUCu1KzL0m6INdp2ux7LiZG2ahw1nuW1RtiQ2UvIMkPOsJ 2ZQC3vmt7Y+QVfYe11t6q/bdN84RKAzQvvPn3CuhlNyijww6nJMObi6n4HiZI6KaHm5y sq8Gs3bOyOM+CkJ2+0/uEfaK+MHxwcoJBx5+0puqZ0cVLp9KTLyV1irH86UDxiQoap94 X3WceXyJPP62hvcRs1Kx6W54bvbi7h2HABBlGUxgnvdMpt9Zsn49zSbImVlr3Fu2XNl0 oIyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2aQSEZ8mWupx7iBojEmnO4BJWlffS1cn+a5CTpv+RNk=; fh=fyWHa9Xga1kBSwfIj7Gdwg4R3yg35b+1QQ92cERVV+E=; b=cv3wXdXPSND64zYSofldSI5hZ6/HoXbXJGc23v/2YtJy48Uxfw6PSc48sEYg3pBl1d VgOdbC1k/cPpUgw1m+FBkMbET+hCRIJR20wdY6YKKHcwkycC7xa2r5uemOzz0heosiJ/ v1NVMu8et9cgavpemth/CzUsPdf1M67ILshSyN4X0xCWiUb4a/NiBc/cWrQhxjOQ6ntE Q3XejMX0m3ZyDLdPCBJyXv9G1F1lYdSlcSmO1yBfLuykODHeNNJxP3J9cMahxfaTOyc9 uLUVJcdKo7NQn3u52QHa/HnuZDH8SRsvTmWCcTNz3gwSod7cfGJWA+cnXAGTSuNl45DG 8jaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ldO8y0aa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id lj6-20020a17090b344600b002868183da74si569840pjb.65.2023.12.06.15.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 15:18:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ldO8y0aa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id EFFCD80DAC76; Wed, 6 Dec 2023 15:18:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379666AbjLFXRj (ORCPT + 99 others); Wed, 6 Dec 2023 18:17:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379617AbjLFXRa (ORCPT ); Wed, 6 Dec 2023 18:17:30 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D218BD69 for ; Wed, 6 Dec 2023 15:17:36 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3424CC433CB; Wed, 6 Dec 2023 23:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701904656; bh=8uz7AK/6yHawqaJPcw4bg1vliKDTq/KL8xQPTh+RBhQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ldO8y0aaCAI30pGHZ+jGi3ri+gv6J7mHp87soVwGOCnw7hGcQgtXzAK6BzELZoYXT EkEFX2BuYSZfAhST/kM4KnpgfrUHGV4vAsB7+Ouh4jfVeliyoFM5Qhy/H7rOju9C5n fW2tyyccaFPGkmXsN/rlupyXFxMt0EKFplWPVCQy/CmqxlalQSkr7GtccdcDSbvVNR 3wy2y6YX/LW2rtq8M5iliwsM/Fx8Pg4+Ge8xxfSFebR//VvU94kwwBFAKUZaoVgj79 MUX+xlMD1xRnCl2NeZL2/zAlrXEnZasnuLWe3loDsHzSUMGaKwJFLs9qgItr2iDKaP ESqXecPm63nDg== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Fei Shao , linux-kernel@vger.kernel.org, patches@lists.linux.dev, AngeloGioacchino Del Regno Subject: [PATCH 5/8] spmi: mtk-pmif: Reorder driver remove sequence Date: Wed, 6 Dec 2023 15:17:28 -0800 Message-ID: <20231206231733.4031901-6-sboyd@kernel.org> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog In-Reply-To: <20231206231733.4031901-1-sboyd@kernel.org> References: <20231206231733.4031901-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 06 Dec 2023 15:18:34 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784576440890508495 X-GMAIL-MSGID: 1784576440890508495 From: Fei Shao This driver enables clocks and then adds SPMI controller in probing, so we expect the reversed sequence in removal. Fix the order in the remove callback. Signed-off-by: Fei Shao Link: https://lore.kernel.org/r/20230824104101.4083400-4-fshao@chromium.org Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-mtk-pmif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c index 6ebc6901490a..cc660da6a037 100644 --- a/drivers/spmi/spmi-mtk-pmif.c +++ b/drivers/spmi/spmi-mtk-pmif.c @@ -515,9 +515,9 @@ static void mtk_spmi_remove(struct platform_device *pdev) struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct pmif *arb = spmi_controller_get_drvdata(ctrl); + spmi_controller_remove(ctrl); clk_bulk_disable_unprepare(arb->nclks, arb->clks); clk_bulk_put(arb->nclks, arb->clks); - spmi_controller_remove(ctrl); } static const struct of_device_id mtk_spmi_match_table[] = {