[v2,net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define

Message ID 20231206160124.1935451-1-sean@geanix.com
State New
Headers
Series [v2,net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define |

Commit Message

Sean Nyekjaer Dec. 6, 2023, 4:01 p.m. UTC
  Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
DSA_TAG_PROTO_LAN937X to improve readability.

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
Changes since v1:
 - removed Fixes tag

 drivers/net/dsa/microchip/ksz_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Andrew Lunn Dec. 6, 2023, 4:07 p.m. UTC | #1
On Wed, Dec 06, 2023 at 05:01:23PM +0100, Sean Nyekjaer wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
  
Arun Ramadoss Dec. 7, 2023, 4:11 a.m. UTC | #2
On Wed, 2023-12-06 at 17:01 +0100, Sean Nyekjaer wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
  
patchwork-bot+netdevbpf@kernel.org Dec. 8, 2023, 7:10 p.m. UTC | #3
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  6 Dec 2023 17:01:23 +0100 you wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> Changes since v1:
>  - removed Fixes tag
> 
> [...]

Here is the summary with links:
  - [v2,net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
    https://git.kernel.org/netdev/net-next/c/cf02bea7c171

You are awesome, thank you!
  

Patch

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 286e20f340e5..5c2214784ed0 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -2614,7 +2614,7 @@  static enum dsa_tag_protocol ksz_get_tag_protocol(struct dsa_switch *ds,
 		proto = DSA_TAG_PROTO_KSZ9477;
 
 	if (is_lan937x(dev))
-		proto = DSA_TAG_PROTO_LAN937X_VALUE;
+		proto = DSA_TAG_PROTO_LAN937X;
 
 	return proto;
 }