From patchwork Wed Dec 6 14:52:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 174613 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4156901vqy; Wed, 6 Dec 2023 06:54:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKVr44uFbfNcASMkEb72u3JGnCl8YobsR8iXKIfNrjIrL/hIuHVQaKFO/XC24lZ6k7ND1n X-Received: by 2002:a05:6870:63ac:b0:1fb:1412:c372 with SMTP id t44-20020a05687063ac00b001fb1412c372mr1040000oap.54.1701874460880; Wed, 06 Dec 2023 06:54:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701874460; cv=none; d=google.com; s=arc-20160816; b=vkqu9xjSgzPzFrc0jCOORj8JIMxc/8TahIY0efTmahz6W6nfsymGNS3aaKaHkJSvwE i4rc3e42cssJex49jl/A4mRnsMMltwIJ/uvyQB16LLwOkSjNfFejMUhXN3y++jhq8jSK csodKridLzNHgKJ1zY8w6rcUgnFqljYy1ZfNRyCQBOXzSCjvbNlZuHd3Tps7DPCgquVz BImlR6mdBvlkoA121ahRfg4c6ItPxtptJ/FLelPSprWxp4OeMGDcNxMexyyKG5d5I1dN uXoTLyvtY39Zgm6WYO5vVwx9vHzh2HKNVzztqaYGyQ80WHjA5BsuR3XMmgpbHkm65DOT W1oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:dkim-signature:from; bh=vaRGVoXrIlt2HgjUs7mRGGr9BwnSNs+Kf5T79EG7bZI=; fh=1IKp81/Uvl9vUeFxTVLSiabzC4OE9m73g8+CMu1UOiY=; b=h5L85Retjv1cS1gaQOgmwwoupbZRZyyFDvm/9ZBVavQ0raTowDkBQKpfoFcbCVBPFX fhqguEIZMS/qgAmUT4r1Bw3lR6/Z5Nx/E7RetJ9g3QLkH2lsqEdIMpwIaIry4uUobHtZ /6gNdbDRn9RADpmwKyaTuY2fqS2srQFJ9G8oOVu3fUGB55FrI77GxvuyNy6sl4/z9wiz j+peRW4oFrTbBcl6Xr1Bol4TAGqTxNLCMSbtnzgczFPj+JT3IWGdLD0TwaAyIMGbiGb8 PGxYINdao2i/UzaUmVkq2zO/whHvC+HpKWTn3yIqYVnaPv92pNuJM1CmT1MqbsEya+RA abYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ssjWMX8b; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y34-20020a634b22000000b005c624afc0f3si10217pga.698.2023.12.06.06.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 06:54:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ssjWMX8b; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7076480755EF; Wed, 6 Dec 2023 06:53:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442076AbjLFOw4 (ORCPT + 99 others); Wed, 6 Dec 2023 09:52:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379029AbjLFOww (ORCPT ); Wed, 6 Dec 2023 09:52:52 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3124D10C6; Wed, 6 Dec 2023 06:52:57 -0800 (PST) From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1701874375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vaRGVoXrIlt2HgjUs7mRGGr9BwnSNs+Kf5T79EG7bZI=; b=ssjWMX8beirkCUmin8cMKUd1xR2AD3wvF5r7TUdBYjgngccpjHlwUnPKV+wDNBmarLTikY tva7GLWX+nz9bZUrnlDaaE4Zg3cZG366Qfe+nThMm/dPEjxEfBpLSa/Lv5FAwzcd0GlLsE uC8DPKs9JtyE1Q19XeGHL5E/2S5eNuquqg285KUWdnosM5j6kp1/xuf03fahXuXcwLTigz AoMqwFDKrX0A2549kmF9FebdKTKXlHudLUxqQ2uSoN9BOQvKOxJenR/PWICTfjbwlZpN3s wwLUM+mHC8JMC6EI9PY3E1hkp/kB3cuCiXMZefx5PHG+NMVHJ9LXdkiwpM+oeQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1701874375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vaRGVoXrIlt2HgjUs7mRGGr9BwnSNs+Kf5T79EG7bZI=; b=QkNV5dZamHFmsLAGwjCx11EsaKISJ6lQbxSSSaBlHV1BGs2yFV4cIYQqpkSzJA7uQcAHft hCTiVAUceO/7XHDQ== To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, daniel@zonque.org Cc: Nam Cao Subject: [PATCH v3] spi: cadence: revert "Add SPI transfer delays" Date: Wed, 6 Dec 2023 15:52:33 +0100 Message-Id: <20231206145233.74982-1-namcao@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 06 Dec 2023 06:53:10 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784544069199834459 X-GMAIL-MSGID: 1784544714907787471 The commit 855a40cd8ccc ("spi: cadence: Add SPI transfer delays") adds a delay after each transfer into the driver's transfer_one(). However, the delay is already done in SPI core. So this commit unnecessarily doubles the delay amount. Revert this commit. Signed-off-by: Nam Cao --- v3: add missing change log v2: - update subject format - rewrite commit message to be more descriptive drivers/spi/spi-cadence.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 12c940ba074a..bd96d8b546cd 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -451,7 +451,6 @@ static int cdns_transfer_one(struct spi_controller *ctlr, udelay(10); cdns_spi_process_fifo(xspi, xspi->tx_fifo_depth, 0); - spi_transfer_delay_exec(transfer); cdns_spi_write(xspi, CDNS_SPI_IER, CDNS_SPI_IXR_DEFAULT); return transfer->len;