diff mbox series

[net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define

Message ID 20231206072442.1628505-1-sean@geanix.com
State New
Headers
Series [net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define |

Commit Message

Sean Nyekjaer Dec. 6, 2023, 7:24 a.m. UTC 
  Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
DSA_TAG_PROTO_LAN937X to improve readability.

Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 drivers/net/dsa/microchip/ksz_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arun Ramadoss Dec. 6, 2023, 8:58 a.m. UTC | #1 
Hi Sean,

> -----Original Message-----
> From: Sean Nyekjaer <sean@geanix.com>
> Sent: Wednesday, December 6, 2023 12:55 PM
> To: Woojung Huh - C21699 <Woojung.Huh@microchip.com>;
> UNGLinuxDriver <UNGLinuxDriver@microchip.com>; Andrew Lunn
> <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; Vladimir Oltean
> <olteanv@gmail.com>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Arun Ramadoss - I17769
> <Arun.Ramadoss@microchip.com>
> Cc: Sean Nyekjaer <sean@geanix.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without
> _VALUE define
> 
> [Some people who received this message don't often get email from
> sean@geanix.com. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
> 
> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

Not sure, whether it is a bug fix or not. Since it only improves readability.
I believe it should point to net-next.
Sean Nyekjaer Dec. 6, 2023, 9 a.m. UTC | #2 
Hi Arun,

> On 6 Dec 2023, at 09.58, <Arun.Ramadoss@microchip.com> <Arun.Ramadoss@microchip.com> wrote:
> 
> Hi Sean,
> 
>> -----Original Message-----
>> From: Sean Nyekjaer <sean@geanix.com>
>> Sent: Wednesday, December 6, 2023 12:55 PM
>> To: Woojung Huh - C21699 <Woojung.Huh@microchip.com>;
>> UNGLinuxDriver <UNGLinuxDriver@microchip.com>; Andrew Lunn
>> <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; Vladimir Oltean
>> <olteanv@gmail.com>; David S. Miller <davem@davemloft.net>; Eric
>> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
>> Paolo Abeni <pabeni@redhat.com>; Arun Ramadoss - I17769
>> <Arun.Ramadoss@microchip.com>
>> Cc: Sean Nyekjaer <sean@geanix.com>; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without
>> _VALUE define
>> 
>> [Some people who received this message don't often get email from
>> sean@geanix.com. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>> 
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>> 
>> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
>> DSA_TAG_PROTO_LAN937X to improve readability.
>> 
>> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> 
> Not sure, whether it is a bug fix or not. Since it only improves readability.
> I believe it should point to net-next. 
> 

Agree :)

Feel free to remove the Fixes tag while applying.

/Sean
Vladimir Oltean Dec. 6, 2023, 3:58 p.m. UTC | #3 
On Wed, Dec 06, 2023 at 10:00:52AM +0100, Sean Nyekjaer wrote:
> Hi Arun,
> 
> > On 6 Dec 2023, at 09.58, <Arun.Ramadoss@microchip.com> <Arun.Ramadoss@microchip.com> wrote:
> > 
> > Hi Sean,
> > 
> >> -----Original Message-----
> >> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> >> DSA_TAG_PROTO_LAN937X to improve readability.
> >> 
> >> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
> >> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> > 
> > Not sure, whether it is a bug fix or not. Since it only improves readability.
> > I believe it should point to net-next. 
> > 
> 
> Agree :)
> 
> Feel free to remove the Fixes tag while applying.
> 
> /Sean

If you're talking to Arun: he can't do that. Only Jakub, David, Paolo
and Eric can apply patches, and based on history, I don't think that
either of them is keen on editing patches before applying. One way or
another, based on past experience, you might be better off just resending,
with the Fixes tag dropped, and patch retargeted to net-next (and
counter incremented to v2).

The criteria from Documentation/process/stable-kernel-rules.rst still
apply pretty much to net.git as well, since these patches land in stable
trees too. We triage as much as possible, to give users of stable
kernels a worthwhile reason to update, not a change that results in
absolutely the same generated machine code.
diff mbox series

Patch

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 286e20f340e5..5c2214784ed0 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -2614,7 +2614,7 @@  static enum dsa_tag_protocol ksz_get_tag_protocol(struct dsa_switch *ds,
 		proto = DSA_TAG_PROTO_KSZ9477;
 
 	if (is_lan937x(dev))
-		proto = DSA_TAG_PROTO_LAN937X_VALUE;
+		proto = DSA_TAG_PROTO_LAN937X;
 
 	return proto;
 }