Message ID | 20231206-rkisp-irq-fix-v2-1-6ba4185eeb1f@ideasonboard.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4005893vqy; Wed, 6 Dec 2023 02:13:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFuFJIS37C8zovWJejb8ZPGxW8H4650J/k/aoW+66HaUwe2G43Hc6rvxTcdCTyRwP6Ofoo5 X-Received: by 2002:a17:902:ef85:b0:1d0:7f06:1751 with SMTP id iz5-20020a170902ef8500b001d07f061751mr607666plb.79.1701857597121; Wed, 06 Dec 2023 02:13:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701857597; cv=none; d=google.com; s=arc-20160816; b=o2fIuCcHvTAeQXS423zS8sEFN9yl2CLxHjk7w9DOTJv0M+XMVPgm6RH17UlAwpjhIg rEmqDSO80ebf/BqP7nTqN1W1YCc7U+qk0+V9NByqJqdhLI/CLGqKsge7k7TL+Q6CfLNE W2ZuiE/d8pkBSSS17TlYOaM2ke5pfxXqWxE6dDbQqCjjW9WEXwWuwTN11NOepbY0COqo r7abxDEREFQp0jfDO+TaroVmIYMSI061K1JLCQbg48nGaRQZSb/5FfAekBuafrfCdx0F cWj0ff6lIeX6k4+fegSFIjZ3IdZXjGI5aQglsKnNNBQMUN2qVXinWlaA3FlnW4pauwMu ZTiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=Ry9R6yyPBnVMk6f21d8y/r5YOO3GFQR+ubLUeW5VHwU=; fh=6fL1NhFCGI+wAVvsHH1pL+P1muGn2uwGLcwd3RTuFww=; b=rKH98o8ogcl4NtAwVRO6ZBg3zlII6MVpSK+WkDe7BMi+ApnQ8h+fqwvxXq4PZ9IYkE DBW/toh12aagdTNtqhaw/CXdY1E0xT/nKkm9MamNGRnHVBzY3W2YCt9X5z1lVfJh3f1O r7f/mvBeJ3znfFQOvg84Hrpr+qb/23YsL1KOBri5s4gJJX3xqVDogJpCpbZH0k26p+Pk K5RlrBNEeFsZphI1J3XYQpkoBfooK9OoMV6uDpdAPVIaySDkh9tHIFpu896V1uqS3Fj6 Z4tAptQQdPLhImafIFAXtCfn3Zl9RQhBr8Mpq8tv1XV2x8GbUC7oFLLauXnEtI8yLjHL rsqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=LwVWe7fY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id h6-20020a170902f54600b001d0231f5e30si2376164plf.295.2023.12.06.02.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 02:13:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=LwVWe7fY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 32BDB80BB3CB; Wed, 6 Dec 2023 02:13:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377622AbjLFKMx (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Wed, 6 Dec 2023 05:12:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377550AbjLFKMt (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 6 Dec 2023 05:12:49 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 847F9D46; Wed, 6 Dec 2023 02:12:54 -0800 (PST) Received: from [127.0.1.1] (91-158-149-209.elisa-laajakaista.fi [91.158.149.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D3FFB14DC; Wed, 6 Dec 2023 11:12:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701857531; bh=FsHDUhUOSdmxO1qno4l01PDWe1nNLgupoeHmIzcStq0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LwVWe7fYRMeptio1qhiK7QyUSytVlcl8HZexC+03MTX0Ai/LY/NOYTIgzk4IKyDCF W7ZO/hV36GBLi7DOq4B09njNrCAS8B4U+YWNJTTixxl9lakF1PDaLopc0ycamnzhUg nvvPYthYsZEirxkRwvlYA1LW5091IxL7VHuTIQQk= From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Date: Wed, 06 Dec 2023 12:12:28 +0200 Subject: [PATCH v2 1/4] media: rkisp1: Drop IRQF_SHARED MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231206-rkisp-irq-fix-v2-1-6ba4185eeb1f@ideasonboard.com> References: <20231206-rkisp-irq-fix-v2-0-6ba4185eeb1f@ideasonboard.com> In-Reply-To: <20231206-rkisp-irq-fix-v2-0-6ba4185eeb1f@ideasonboard.com> To: Dafna Hirschfeld <dafna@fastmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Heiko Stuebner <heiko@sntech.de>, Paul Elder <paul.elder@ideasonboard.com> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>, kieran.bingham@ideasonboard.com, umang.jain@ideasonboard.com, aford173@gmail.com, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1223; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=FsHDUhUOSdmxO1qno4l01PDWe1nNLgupoeHmIzcStq0=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBlcEkg4oQWDIpxgRjng5riAxA98dypRcWlQusOt gHRf/zsXYaJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZXBJIAAKCRD6PaqMvJYe 9Qt2D/9VM6a4+9d6s6OGE5LzaUWHgDu2WoXfUkyZ+cD9Zb65uEiK6uQxQJRa7OEfRqn7Us0XlG9 O56i09/y211GvZiwC4Q/CJlN7slXeGor51/DQsMvaEjmdeTwupE8XJ4Kp5Xb8IfkigKd8DcD6Ok oH/GFRJ6YA95YwQDnd7s3fVxawUE9t/z6jYCtF56e7cRJ9Tpzf/dXM5ebb8Ymiku0K4RCZpjuUr K8mTjmTacegvUqPofVSc6DJyoaqUucYfEpbTdYAilz7fqpLaLL0djdjytER7y4RGkv7CiuB46Dx lZdu9KXd1YHMrYJ02un7ETntsbO6Y9lg1lf4tFsyw2rU+lGtZlqBjeEFUbfFn1KkcXKkn3ubv5A 7SCe1udyuRXV3tinIZ+oAGG9p1hLrBn1OwwHNLhxvYx0eDcKLMrwleRG7EhWe9WL1TNe6V/Ir9V iaJkQv919QYja1YKjjM7gnIZUZXM8qclZYVAb7P7XFfvPKOUTU8NH1Pa7Z0cahSvXmKdx3ZoK/A 2WU0EK8+c4IVeJskD0I/oFzL/BUJMEl8LmyH4UpItj15RKAFzX5kjALNkC4fEm8bnskkmpVojT7 J6zMWDC8ZpYY23v8iqK3Qv6JpJY8z89dKvPDVGpSA+aIyOqUZfm8AJMPLZYujbVVAombu0D4zQl qFV4XmjbLpJIIoQ== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 06 Dec 2023 02:13:14 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784527031797459721 X-GMAIL-MSGID: 1784527031797459721 |
Series | media: rkisp1: Fix IRQ related issues | |
Commit Message
Tomi Valkeinen
Dec. 6, 2023, 10:12 a.m. UTC
In all known platforms the ISP has dedicated IRQ lines, but for some
reason the driver uses IRQF_SHARED.
Supporting IRQF_SHARED properly requires handling interrupts even when
our device is disabled, and the driver does not handle this. To avoid
adding such code, and to be sure the driver won't accidentally be used
in a platform with shared interrupts, let's drop the IRQF_SHARED flag.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Tomi, Thank you for the patch. On Wed, Dec 06, 2023 at 12:12:28PM +0200, Tomi Valkeinen wrote: > In all known platforms the ISP has dedicated IRQ lines, but for some > reason the driver uses IRQF_SHARED. > > Supporting IRQF_SHARED properly requires handling interrupts even when > our device is disabled, and the driver does not handle this. To avoid > adding such code, and to be sure the driver won't accidentally be used > in a platform with shared interrupts, let's drop the IRQF_SHARED flag. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index 2b9886fd0800..d4950294b7b9 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -573,7 +573,7 @@ static int rkisp1_probe(struct platform_device *pdev) > if (irq < 0) > return irq; > > - ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED, > + ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0, > dev_driver_string(dev), dev); > if (ret) { > dev_err(dev, "request irq failed: %d\n", ret); >
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index 2b9886fd0800..d4950294b7b9 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -573,7 +573,7 @@ static int rkisp1_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED, + ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0, dev_driver_string(dev), dev); if (ret) { dev_err(dev, "request irq failed: %d\n", ret);