From patchwork Tue Dec 5 22:58:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 174226 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3754353vqy; Tue, 5 Dec 2023 14:59:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfAsnVJVbYzL/xykx19QOrS5Esr1Azh8OaZyy7oYgtS67RZuy/B+QkvYbsaL70uhq+c1Iy X-Received: by 2002:a05:6e02:1347:b0:35d:5d94:ee4c with SMTP id k7-20020a056e02134700b0035d5d94ee4cmr75815ilr.67.1701817146658; Tue, 05 Dec 2023 14:59:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701817146; cv=none; d=google.com; s=arc-20160816; b=bZopoc6evpviT6mSHLD716ee/WXj2xVqgvhsWbI05QSs7Hvye8T7QfrDbCR0gFSMBs jiV/aQc8U62xuqyBER43UeAWVu0Y1c0F5eB0dx1WY3CuQy/rzSd1eBI110+cplCKswiH lW7FQZmnOVUlok5fWdRjiFDCdJyWCcP9tqvPPXPk5RkKCZ5cvzK2JHiOBRiVI5iqiREB ufCy34X+x8+aB8y3eaVlerjIQdXxnB4mAaez8Zu+4rcMxfW438tkLEGQkWLc8cycumxe /xDIYJ3AAXltFTjr//ZtnQ4Lxw+ThXe1XIIAFgAWqs6iM7ZLD/S9hkHlAigcMcf/CkA2 y+sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+wPQgMtfP3e+4Wk8NNsQzADS8z91J+KBS6ktKYz5c3k=; fh=A9jMpFR0tQBavCFDssk9Ngo7PE5BgHG9lSzxZ2tXp50=; b=GaHey2p7ESsoDeZOaGayfNDOemeze5wsGxZFsWq94MS1WlK8u++qexSebz6RQ2urzZ A/FYV++G0ExyVozF2zH3/GiQdfkFoVw5jQYn7Mtjc83GzYUXMCklRnAqR3fUvtQ8at1Z 1MvkQ3ITyYUWZdk8A4yNN44IEWK7OoR5F/mtJpl0+AQASHoy3k3zJ4reqDotC5NrhTA8 BKNfazbP4235FpQc/MJoFyGgNHzAbJ7KZaDe9kNEeGJ1ae4WesQA65QFuOnl5NeNsscl g1VnQh0S9l1aaGwhAKd3zAU+3u7i/gpdus6wZgm1kxj+80MSiz9vHIa97+3yCCvRXH6L GAGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SyeWcAiT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id v14-20020a63480e000000b005be01a390b5si3973394pga.472.2023.12.05.14.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 14:59:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SyeWcAiT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6709780966FC; Tue, 5 Dec 2023 14:59:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346254AbjLEW6x (ORCPT + 99 others); Tue, 5 Dec 2023 17:58:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjLEW6w (ORCPT ); Tue, 5 Dec 2023 17:58:52 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B800DB5; Tue, 5 Dec 2023 14:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=+wPQgMtfP3e+4Wk8NNsQzADS8z91J+KBS6ktKYz5c3k=; b=SyeWcAiTZWnRR5UdV+pQOksTQV j/lgXABiUbfdSoeR0tkqA9lDLIYgGvkUceaJK8glrdHDycjTE6zuLCo15Giyt/MLgsCmu1hqRoAvs Ft2OCuPEkm/Z98RqKalBfmQJIfEcpvfsF6DLY3GnSwy4yNNYAfqbAY88SaRHTjq8pKcoVzp76aWJZ I+rUK5LL2bI44mLfOcaftgkqKe77YyZrfgcv3mR1xle87Qbg5JUN/FCc3oWlv3xnsRN5dUhAXw4ka TPz/GBNZ6LCYB4JN5RTdYtE+0lzjxKObsW6vG673UFgDibCdI42a1+DrdRHOsogx2JRInA+2nh1Fn nzWrp4+w==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rAeNU-008Z1T-2S; Tue, 05 Dec 2023 22:58:57 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , "Rafael J. Wysocki" , Pavel Machek , Kevin Hilman , Ulf Hansson , Greg Kroah-Hartman , linux-pm@vger.kernel.org Subject: [PATCH] PM: domains: fix domain_governor kernel-doc warnings Date: Tue, 5 Dec 2023 14:58:56 -0800 Message-ID: <20231205225856.32739-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 14:59:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784484616552253791 X-GMAIL-MSGID: 1784484616552253791 Fix kernel-doc warnings found when using "W=1". domain_governor.c:54: warning: No description found for return value of 'default_suspend_ok' domain_governor.c:266: warning: No description found for return value of '_default_power_down_ok' domain_governor.c:412: warning: cannot understand function prototype: 'struct dev_power_governor pm_domain_always_on_gov = ' Signed-off-by: Randy Dunlap Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Kevin Hilman Cc: Ulf Hansson Cc: Greg Kroah-Hartman Cc: linux-pm@vger.kernel.org Reviewed-by: Ulf Hansson --- drivers/base/power/domain_governor.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -- a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c --- a/drivers/base/power/domain_governor.c +++ b/drivers/base/power/domain_governor.c @@ -49,6 +49,8 @@ static int dev_update_qos_constraint(str /** * default_suspend_ok - Default PM domain governor routine to suspend devices. * @dev: Device to check. + * + * Returns: true if OK to suspend, false if not OK to suspend */ static bool default_suspend_ok(struct device *dev) { @@ -261,6 +263,8 @@ static bool __default_power_down_ok(stru * @now: current ktime. * * This routine must be executed under the PM domain's lock. + * + * Returns: true if OK to power down, false if not OK to power down */ static bool _default_power_down_ok(struct dev_pm_domain *pd, ktime_t now) { @@ -406,8 +410,8 @@ struct dev_power_governor simple_qos_gov .power_down_ok = default_power_down_ok, }; -/** - * pm_genpd_gov_always_on - A governor implementing an always-on policy +/* + * pm_domain_always_on_gov - A governor implementing an always-on policy */ struct dev_power_governor pm_domain_always_on_gov = { .suspend_ok = default_suspend_ok,