Message ID | 20231205164924.835682-1-irogers@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3561329vqy; Tue, 5 Dec 2023 08:49:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKQkmG6Uoe2YYb0W1Z/ip4+b0RJUQseWYLjClp7xI8czFOVhI64dkCyQOH8jx+hju16rSe X-Received: by 2002:a92:7410:0:b0:35d:59a2:128f with SMTP id p16-20020a927410000000b0035d59a2128fmr7412996ilc.59.1701794982103; Tue, 05 Dec 2023 08:49:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701794982; cv=none; d=google.com; s=arc-20160816; b=iLOnXTZp2Hip2Ehi2/lE5bZb70dWRnbgNorUTzvTx7aJ0VhPGgv/ip3eqVgxfmAUKr SB7f7rytfmkukhThLApfggddGO3uyEBH99hKeOD2wrU7jgMBYvlorT3RfxgkH5i2lzLJ 74Zk/y4A9yEK94vZ4Rg4Pa1hDQgJfezy8ahNQfMKg5fMxCNVrKgEfvlMe3yi7N9qGgR6 yVc21xqwFocmsfcdFK16OhXneaWnlR08yxcxsPdgYui1yqVBHVcbT3Wn98VIKu3w4QAW xiCHARoeyREKegjvptPkxzC2k+TG6yPbgCoa/1IFa/3FDcvH5mXF2pOmimGctF4nFDRj ST4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:subject:mime-version:message-id:date :dkim-signature; bh=il/zOOk1ULaSp4c3ZKjwASqI7JmWGklotUwSmWlNxts=; fh=M03QQq2BGgAHjQvEE5ebB9F7AIwQdsROrtXDdf41UXo=; b=bx+cbMB9Rd0UzNMz/9Kp7DVu4w4D/uYEjCis6lmTC5j5rrn+ooke4TLtbZFQ7nyt0S GPBfHT8yvzHETbaLZjU+T3Vzh2ZhrY4QHXsimRx5tUOWnpMeosVWfRZLzK+fmZCdPFCN Ihf0x61jPrui2ouQIrpT49CG7xZOAQ/ElMBwOdEHRDgUJa5/wM/sgNzl2Z6Ig3itEg/8 /QE/OSOn//xnKV+IuaNPVhrhnOjAt0fbSu7KBfD1d7GLozkw4WHPY5U21X/q9xdUwGLP D4jRLsfJWlxcu5/F3byqLbA/ynf6ewNwH4U4RYuKfkZyeGAZUoDM7KI7AQRAIii1RyGs OgRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=MmthDo4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z19-20020a63e113000000b005c14fc66cc4si5472453pgh.380.2023.12.05.08.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 08:49:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=MmthDo4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id AFF9380ABDE4; Tue, 5 Dec 2023 08:49:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232160AbjLEQt0 (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Tue, 5 Dec 2023 11:49:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232198AbjLEQtY (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 5 Dec 2023 11:49:24 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD7019F for <linux-kernel@vger.kernel.org>; Tue, 5 Dec 2023 08:49:30 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-db547d41413so3801803276.0 for <linux-kernel@vger.kernel.org>; Tue, 05 Dec 2023 08:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701794969; x=1702399769; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=il/zOOk1ULaSp4c3ZKjwASqI7JmWGklotUwSmWlNxts=; b=MmthDo4GyoBmUhvDHGw72G01MDqlIvODa/hQIJaBYO9hgqqG53xzEtqM7gWzDs8U4N VdXtcO7F5Bm4sWPPbsXjwi85nRkOqiy4X7W5o4hXuksGEWZvuab5ApIi0lg3dllLzM3y /pFJ0yFA6vcJldgWu8d/Er50IQWisih7fMxW04E1+gA6tr9Dz6wRbfX7auCF1L+P5rWL ArWdVjJA1EfOlHQ/r8DQ/Zq/QFwvnQFOt9ROehJpW0P9D3dw0kSzhY6b/dwUYb62jQGj rLG/dcxCrKSO9vUodXOiOjhR1KdWQIlK5SeNWFSIbLMYlOUChqL3m1z24CEEM8/gI1jQ QF9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701794969; x=1702399769; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=il/zOOk1ULaSp4c3ZKjwASqI7JmWGklotUwSmWlNxts=; b=c0GZoqOYCzGUit58kkhahMjw6oH5LAux7rkwCxFVBwJzxKGKgzQPaDBD+KOUVAzDCq 5L29tC491xTGrOasXRkNDg6yLCK7m85Jbs7LtRtLVsEgsXikyV/lP9L+8pGGqjiSU3SY uFyYqoJkhiLmugKUcMVurQYbrensMe4CmO7jb1HHVotHknXbkz8kYqChcLn12d6MvR+v VeYXXGDVFl/SXT/Y5+g4fAdyFlFF4S0R8DlWcZGnWcDCA61SW/8pk7NZEblCpIQ5HSwx CShQyaJZXYr2Vf2a68dw/9g7I7VyzbVI4vVrFgNlLrNiI37HbX/QoDXtUgk1ciYKjvFJ Uxfw== X-Gm-Message-State: AOJu0Yx24n0RJFDY/QcnSIiIzRCl0faFQdscWYhcyjxAqWitPqHtWp7h I2msJfSaJuR1VZ5BoFbptKmEsNT0jx4X X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:48b6:2578:1ca7:5287]) (user=irogers job=sendgmr) by 2002:a05:6902:51:b0:da3:b467:af07 with SMTP id m17-20020a056902005100b00da3b467af07mr60835ybh.2.1701794969538; Tue, 05 Dec 2023 08:49:29 -0800 (PST) Date: Tue, 5 Dec 2023 08:49:24 -0800 Message-Id: <20231205164924.835682-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Subject: [PATCH v1] perf test: Skip diff test if test_loop is missing From: Ian Rogers <irogers@google.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 08:49:35 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784461375420587317 X-GMAIL-MSGID: 1784461375420587317 |
Series |
[v1] perf test: Skip diff test if test_loop is missing
|
|
Commit Message
Ian Rogers
Dec. 5, 2023, 4:49 p.m. UTC
The diff test depends on finding the symbol test_loop in perf and will
fail if perf has been stripped and no debug object is available. In
that case, skip the test instead.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/diff.sh | 7 +++++++
1 file changed, 7 insertions(+)
Comments
On 5/12/23 18:49, Ian Rogers wrote: > The diff test depends on finding the symbol test_loop in perf and will > fail if perf has been stripped and no debug object is available. In > that case, skip the test instead. > > Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/tests/shell/diff.sh | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/perf/tests/shell/diff.sh b/tools/perf/tests/shell/diff.sh > index 213185763688..14b87af88703 100755 > --- a/tools/perf/tests/shell/diff.sh > +++ b/tools/perf/tests/shell/diff.sh > @@ -9,8 +9,15 @@ perfdata1=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > perfdata2=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > perfdata3=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > testprog="perf test -w thloop" > + > +shelldir=$(dirname "$0") > +# shellcheck source=lib/perf_has_symbol.sh > +. "${shelldir}"/lib/perf_has_symbol.sh > + > testsym="test_loop" > > +skip_test_missing_symbol ${testsym} > + > cleanup() { > rm -rf "${perfdata1}" > rm -rf "${perfdata1}".old The verbose output in the error case could also be tweaked. Before patch: $ strip tools/perf/perf $ tools/perf/perf buildid-cache -p $(realpath tools/perf/perf) $ tools/perf/perf test -v 'diff test' 85: perf diff tests : --- start --- test child forked, pid 8621 Basic two file diff test ./tools/perf/tests/shell/diff.sh: 51: [: Workload: unexpected operator ./tools/perf/tests/shell/diff.sh: 56: [: Workload: unexpected operator Basic two file diff test [Failed diff] Basic three file diff test ./tools/perf/tests/shell/diff.sh: 73: [: Workload: unexpected operator ./tools/perf/tests/shell/diff.sh: 78: [: Workload: unexpected operator ./tools/perf/tests/shell/diff.sh: 83: [: Workload: unexpected operator Basic three file diff test [Failed diff] test child finished with -1 ---- end ---- perf diff tests: FAILED! After patch: $ tools/perf/perf test -v 'diff test' 85: perf diff tests : --- start --- test child forked, pid 8853 perf does not have symbol 'test_loop' perf is missing symbols - skipping test test child finished with -2 ---- end ---- perf diff tests: Skip and with symbols: $ tools/perf/perf test -v 'diff test' 85: perf diff tests : --- start --- test child forked, pid 10122 103e20-103e60 g test_loop perf does have symbol 'test_loop' Basic two file diff test Basic two file diff test [Success] Basic three file diff test Basic three file diff test [Success] test child finished with 0 ---- end ---- perf diff tests: Ok Tested-by: Adrian Hunter <adrian.hunter@intel.com>
diff --git a/tools/perf/tests/shell/diff.sh b/tools/perf/tests/shell/diff.sh index 213185763688..14b87af88703 100755 --- a/tools/perf/tests/shell/diff.sh +++ b/tools/perf/tests/shell/diff.sh @@ -9,8 +9,15 @@ perfdata1=$(mktemp /tmp/__perf_test.perf.data.XXXXX) perfdata2=$(mktemp /tmp/__perf_test.perf.data.XXXXX) perfdata3=$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog="perf test -w thloop" + +shelldir=$(dirname "$0") +# shellcheck source=lib/perf_has_symbol.sh +. "${shelldir}"/lib/perf_has_symbol.sh + testsym="test_loop" +skip_test_missing_symbol ${testsym} + cleanup() { rm -rf "${perfdata1}" rm -rf "${perfdata1}".old