From patchwork Tue Dec 5 09:22:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 173814 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3307236vqy; Tue, 5 Dec 2023 01:23:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IEE0JDZ86NgLEzlGsXRPsIxi+q4k/KyC7gYv1w5STmBch7w5UrHjAXMLN4NOczpeUZhSbEB X-Received: by 2002:a17:90a:5608:b0:286:6cc0:cac7 with SMTP id r8-20020a17090a560800b002866cc0cac7mr826167pjf.62.1701768189699; Tue, 05 Dec 2023 01:23:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701768189; cv=none; d=google.com; s=arc-20160816; b=VqIUGnixMqdJy47vW43XXW0CEaqRwRdg5Ff+LWdJzbcwOGBpe/nZZ8ayDvLUCaVXWe 5cyLxw+q7MNw/j7C5JOZn2Z7J49J/l9IbbDgVfU95cdyhlDxmZj7UVRyCAVIC8bA9aG0 edZWyW+lW1oron2I5B28kCdYnu2jNwhbEOS66+SAA2mw0aQstIElNRRfrPjx/03HiMhU qu/WbHente9mjEDY2d+HX6l9o52gcTrzJcy+HT9VIDQxUfjpd71qkUIwAJM3AOwAKyiF 6/U+umj1PpBy5IokRxOD8e/MC8qRbShK7MqvF0aZ96uOk7gYEZG9fKxVua1uLUG2xPn1 3nRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KDQvRMNMCDsySKsLvfWU4d3cyjxohNNvIIg/FZa633s=; fh=AilG5DwEGuLqGl78/1nxyk0W4Li6L5QGIzTBumtkZas=; b=C36Ma90LHH/goH+yx6N/URHltCUeDoSkCV5anvrNPslF0r/a4NsEOEdJRLk1E+UEoG nv1+jRHEKx2gJc/lh0M3kd+PwU6DGXa+jgxD5dWyB1DRyhe3bBQPCj5zaRCfwwWT9pUO CgZQ/7+K2VxKIwxs1QgFyun5QEBI1NMY802Qk3MDUGyWQ6nzVzYkWp/wm973POphDXNg EAsvJcC5lArXnWSp1XelP3c/KphpyU+lK1Xwy7XCnhwdk4S8pc5rIOpsLr3R8+jE5HRa yGK7HzZLBpZcNXGnAiwmRrj9zxCMB/ZJ07xdag+CagD1oNX8mXT7NKk4FC92hJAfFpc1 keiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Zn3Iyeem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id u13-20020a17090341cd00b001d0107ee537si207218ple.428.2023.12.05.01.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 01:23:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Zn3Iyeem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3EB5F807F4B6; Tue, 5 Dec 2023 01:23:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235495AbjLEJWz (ORCPT + 99 others); Tue, 5 Dec 2023 04:22:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235465AbjLEJWv (ORCPT ); Tue, 5 Dec 2023 04:22:51 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 756BC194 for ; Tue, 5 Dec 2023 01:22:48 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40a4848c6e1so57584045e9.1 for ; Tue, 05 Dec 2023 01:22:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701768167; x=1702372967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KDQvRMNMCDsySKsLvfWU4d3cyjxohNNvIIg/FZa633s=; b=Zn3IyeemD7sk0z64sIoJskAbnJSUM9NbCbfz/OOqIJN8Ff9wG2B+jrmvXDlySLsnJK NBDXbE073M4bybSdjtR9VR6t4aRhOjgPbOAGe/kyMxYOhTzRYsQ7kaDz0tfGJ5M7mknY /HsjVwYYQxTsfAANvZZ+GwyCWWDKVxlv76soGzBCG3M6SahyHDq1Eb3ru1LhCdN9KYhy 14bKJl9Z98nNAZXCkctMFDm+zANgrGvtSx1lB+5JFcIL1lgRtOau9HhZ7ginREHq5NUK mu27Wo4MPpOED8BDYBDey0jbbloVnnb689jZv29WFZjE/mKcCB/Su1/+1/AWGqsDcVY+ 2NwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701768167; x=1702372967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KDQvRMNMCDsySKsLvfWU4d3cyjxohNNvIIg/FZa633s=; b=J8e3PAV7DcQ6jKwXCTfvUjm0/rcTtpAGU+exwBvvyhiLJL7sYpOqmDRUrfyPtm+FY5 onqFzfLP8NGuajVMVvi6mAKYqCNnx1TkkN4xPcSHOXqcVuiZZakauKfsUAlWPs0TtSUQ U8dmJ3fIeU6mCpsjHMGPsLfh+KLa/qr/+NrO+OlsUwNyiMMS7pTGCKoEIA6jjjd6FsZi WnfMYN9UBtcUVWJn0htObqIH2d2TACUBFd10vDj7vXauh+4RaCFrz/SEu6tdboT6w3Dw wmR5MHjDmb+4/7ZYfK/tcPwa1tzl/q6zJUaPeT6lWEwELad/pjuFEEquqoH5MOxLh3nF GZBw== X-Gm-Message-State: AOJu0YxUFvqWLYnvB/2uFYUwuMy4NWrHWKnCtLpvhCg8RM2k0HFF4vk1 lRyK4HgVBT+W+unJmNlCqScqdw== X-Received: by 2002:a05:600c:21ce:b0:40b:acfb:5d04 with SMTP id x14-20020a05600c21ce00b0040bacfb5d04mr247995wmj.222.1701768167020; Tue, 05 Dec 2023 01:22:47 -0800 (PST) Received: from krzk-bin.. ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id g10-20020a05600c4eca00b0040596352951sm21692287wmq.5.2023.12.05.01.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 01:22:46 -0800 (PST) From: Krzysztof Kozlowski To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Greg Kroah-Hartman , Jiri Slaby , Wim Van Sebroeck , Guenter Roeck , linux-fsd@tesla.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/6] dt-bindings: watchdog: samsung: add specific compatible for Tesla FSD Date: Tue, 5 Dec 2023 10:22:28 +0100 Message-Id: <20231205092229.19135-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231205092229.19135-1-krzysztof.kozlowski@linaro.org> References: <20231205092229.19135-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 01:23:04 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784433281281469018 X-GMAIL-MSGID: 1784433281281469018 Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the others it reuses several devices from older designs. Historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add Tesla FSD compatible specific to be used with an existing fallback. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../bindings/watchdog/samsung-wdt.yaml | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml index 8fb6656ba0c2..ea2d206b05ab 100644 --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml @@ -16,14 +16,19 @@ description: |+ properties: compatible: - enum: - - samsung,s3c2410-wdt # for S3C2410 - - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 - - samsung,exynos5250-wdt # for Exynos5250 - - samsung,exynos5420-wdt # for Exynos5420 - - samsung,exynos7-wdt # for Exynos7 - - samsung,exynos850-wdt # for Exynos850 - - samsung,exynosautov9-wdt # for Exynosautov9 + oneOf: + - enum: + - samsung,s3c2410-wdt # for S3C2410 + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 + - samsung,exynos5250-wdt # for Exynos5250 + - samsung,exynos5420-wdt # for Exynos5420 + - samsung,exynos7-wdt # for Exynos7 + - samsung,exynos850-wdt # for Exynos850 + - samsung,exynosautov9-wdt # for Exynosautov9 + - items: + - enum: + - tesla,fsd-wdt + - const: samsung,exynos7-wdt reg: maxItems: 1