From patchwork Mon Dec 4 14:03:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 173355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2782070vqy; Mon, 4 Dec 2023 06:04:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IHOVNn7+QCbCQXgrl8pd4pvg2LlNX2obw0vDq+i63b7LB9O4LaFEzSilj0nAupFZvKDvmCh X-Received: by 2002:a17:90b:4b46:b0:286:8daf:85b4 with SMTP id mi6-20020a17090b4b4600b002868daf85b4mr3083486pjb.2.1701698690374; Mon, 04 Dec 2023 06:04:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701698690; cv=none; d=google.com; s=arc-20160816; b=C2FwLEVeWW0/iCxzC7vR21g1TYm7CXeUHcud5xzf1CzNUTfVtlaidIk6ni9yB/i2Ho eI/CLgMXEMesIynwVO17I0W9+LWJdaAPp6uukt/kzv7+g7QOIHrAAxGvsrZUsErUmHMU NsOFceTljj+2STz0uROKi7bz2fu+pA1CrBJZLOUIT2Pd8c98yIHj8YA+6rfYI5RjnarT gVsrK6BEi1tP6tsGH7PCWi3y3+FoNLwJP5hkabdUpWf+pw1YrGNO5VVunpXR/F004jFF VBwhGCbeQLHxFt+OEIyQD5O+quNDSOWZAu9ScyAZsmyg3OjzH9luQG3Tb5iiJTdhRN7J 3ahg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EauQ2wrK+wrLp0dftTWFW30qJjPlPW+KVuBL537ybvE=; fh=lq3uIejE9+UCb9GhFK9s8FDaMDYUiH23kGvWD8KW0Eg=; b=oxxITYp0gXcAmto+maAq+0yZ5cYdguOUy6HRnB0T0G3XhxrkA0Jiw+5ZFWlw9U1XNJ DrGtGFCmGb0F60cjn6swiwPpVvIcmKkFBHkQ7mLbwv3pzaJIl0VDmX7BTUiSMu+rpNnm +RpavTzysSw7eiznlem6etZxyHHpVh9cG8gmRwj5RsTL8aPWit70HGg6SPo4CAMFhwsj XsWtt94BD+Teso8BCmG8reuKZf0w+gHV2LnoyObV4V/36Esp9j/Zydt/YMQ8YAvLtig2 mHSGNCOPdhsCmOuJldI8h+hsM6rEyI9BIh3GUwJtTKsaTn6d1rccCVggfosxZCgWYJpR 4qWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=sqhSiRUn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id pb16-20020a17090b3c1000b00286d452783esi16698pjb.5.2023.12.04.06.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 06:04:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=sqhSiRUn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DE1D380A5FAA; Mon, 4 Dec 2023 06:04:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344920AbjLDOEd (ORCPT + 99 others); Mon, 4 Dec 2023 09:04:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344944AbjLDOEc (ORCPT ); Mon, 4 Dec 2023 09:04:32 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6ED6106; Mon, 4 Dec 2023 06:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1701698645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EauQ2wrK+wrLp0dftTWFW30qJjPlPW+KVuBL537ybvE=; b=sqhSiRUnlnoXtZWveiRp1jISoIWmyTlvKkcLmp5C07pvU84zyl6Q7NTsW13auL+QliM2WW 9dKbELEL5y50o0nee7w61mwRwS8281vbiyKKMzADxg67OuPkfkADEvvCZGd3aM7S9YYVvl ZgkPq4XbNTsdIdVtknno/FA3aKeaRoY= From: Paul Cercueil To: Vinod Koul Cc: Lars-Peter Clausen , =?utf-8?q?Nuno_S=C3=A1?= , Michael Hennerich , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: [PATCH 4/4] dmaengine: axi-dmac: Use only EOT interrupts when doing scatter-gather Date: Mon, 4 Dec 2023 15:03:52 +0100 Message-ID: <20231204140352.30420-5-paul@crapouillou.net> In-Reply-To: <20231204140352.30420-1-paul@crapouillou.net> References: <20231204140352.30420-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 06:04:44 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784360405663570949 X-GMAIL-MSGID: 1784360405663570949 Instead of notifying userspace in the end-of-transfer (EOT) interrupt and program the hardware in the start-of-transfer (SOT) interrupt, we can do both things in the EOT, allowing us to mask the SOT, and halve the number of interrupts sent by the HDL core. Signed-off-by: Paul Cercueil --- drivers/dma/dma-axi-dmac.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 5109530b66de..beed91a8238c 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -415,6 +415,7 @@ static bool axi_dmac_transfer_done(struct axi_dmac_chan *chan, list_del(&active->vdesc.node); vchan_cookie_complete(&active->vdesc); active = axi_dmac_active_desc(chan); + start_next = !!active; } } else { do { @@ -1000,6 +1001,7 @@ static int axi_dmac_probe(struct platform_device *pdev) struct axi_dmac *dmac; struct regmap *regmap; unsigned int version; + u32 irq_mask = 0; int ret; dmac = devm_kzalloc(&pdev->dev, sizeof(*dmac), GFP_KERNEL); @@ -1067,7 +1069,10 @@ static int axi_dmac_probe(struct platform_device *pdev) dma_dev->copy_align = (dmac->chan.address_align_mask + 1); - axi_dmac_write(dmac, AXI_DMAC_REG_IRQ_MASK, 0x00); + if (dmac->chan.hw_sg) + irq_mask |= AXI_DMAC_IRQ_SOT; + + axi_dmac_write(dmac, AXI_DMAC_REG_IRQ_MASK, irq_mask); if (of_dma_is_coherent(pdev->dev.of_node)) { ret = axi_dmac_read(dmac, AXI_DMAC_REG_COHERENCY_DESC);