From patchwork Mon Dec 4 14:03:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 173353 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2781740vqy; Mon, 4 Dec 2023 06:04:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmRzqPHcyYFUpQZpcGdKYEjHkKrkQHHAGdbWMgoQxa14W5qjNMhsc48ZtuQguLwh6PrEhF X-Received: by 2002:a17:903:32d0:b0:1d0:9660:fac3 with SMTP id i16-20020a17090332d000b001d09660fac3mr1057168plr.109.1701698666636; Mon, 04 Dec 2023 06:04:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701698666; cv=none; d=google.com; s=arc-20160816; b=r3QRO+DgdVamIZ5yeqAu5RTWCTUR1rVLf3gxXlV46qyu2iwuQsP6jO+u/Lk0oo7nTr v+Oo2CL5gNsGtLbeXoFle5zBy89vfzH9kr7/lPQUJoWM2uTdV3dVJzWDyPosFL/QCeiG 8ErH9eD7bx4lWh2ZUL/59EYW2+qJM08Xxbkke+F06l6Q8oXlu/5XExt7yg0gcSJ89t9x Q8jV1YM+nwtkp3wl2JgWQ8vWPk5tuiVq5x0sFVzqvUTW9F4PGeGS0VKSqYgbexuQGKX7 OUF2qeM173SBYfwS8aKc+7qWzoknNVJE7qVjM6QbfvM6giocdpDcrCiekOaBQh/UNBs9 1RMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=t53LIR4hled+zaU+hMQumxi96x360KE+fXgFa+68WO0=; fh=lq3uIejE9+UCb9GhFK9s8FDaMDYUiH23kGvWD8KW0Eg=; b=onKJoc9KkJ9LhoMvBftDkWhkcGgxgwrrlARQ0oYSOtfw9rruhaEX3YrP9slSrqHGve kLMWo7vitYyYphOLa9Eghg3JBuyFJIgZb2aBT7a1HlY+l/2WXZHgR0avvv/eBB6RsF6J hJAjyA1kLB+zHjS5JxwmKuLxb8OEBhrIE3JKooUP6W+vc4T6raAGkM0T46k0zuKtH2mK tg2wQsJchf8LXgcFZUTNA7PfFcuqP6hnhNUmLBqyrdAstxLbuEZYHb63RqFCWl0U1lgL ihagf7Dm3qJsPduCi18FlEdP36cUwmUUWK1sFj02h3CpB5/MjB0k0n4Fy8EzT2bO+f6Z iiqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=TDJaYPmj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id v10-20020a170902b7ca00b001d0259167f4si415232plz.287.2023.12.04.06.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 06:04:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=TDJaYPmj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8239A80A13A4; Mon, 4 Dec 2023 06:04:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235740AbjLDOEK (ORCPT + 99 others); Mon, 4 Dec 2023 09:04:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234485AbjLDOEI (ORCPT ); Mon, 4 Dec 2023 09:04:08 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF0ED106; Mon, 4 Dec 2023 06:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1701698643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t53LIR4hled+zaU+hMQumxi96x360KE+fXgFa+68WO0=; b=TDJaYPmjldl/ePtWEpqi3WHE5UesyvkxNu+zsaaQtjq/n8Vvnri9vvSYRWT2oGDHG+8lXC D8wfcN7colyxcta5CRvVF6saoZZ/bIZSAJmFABC8UdutQymfKP69sr8eehCafhquSZ9t8P T/5uA+bXwGO9j/+34leXH11fWp5Trlk= From: Paul Cercueil To: Vinod Koul Cc: Lars-Peter Clausen , =?utf-8?q?Nuno_S=C3=A1?= , Michael Hennerich , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: [PATCH 1/4] dmaengine: axi-dmac: Small code cleanup Date: Mon, 4 Dec 2023 15:03:49 +0100 Message-ID: <20231204140352.30420-2-paul@crapouillou.net> In-Reply-To: <20231204140352.30420-1-paul@crapouillou.net> References: <20231204140352.30420-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 06:04:18 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784360381049987175 X-GMAIL-MSGID: 1784360381049987175 Use a for() loop instead of a while() loop in axi_dmac_fill_linear_sg(). Signed-off-by: Paul Cercueil --- drivers/dma/dma-axi-dmac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 2457a420c13d..760940b21eab 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -508,16 +508,13 @@ static struct axi_dmac_sg *axi_dmac_fill_linear_sg(struct axi_dmac_chan *chan, segment_size = ((segment_size - 1) | chan->length_align_mask) + 1; for (i = 0; i < num_periods; i++) { - len = period_len; - - while (len > segment_size) { + for (len = period_len; len > segment_size; sg++) { if (direction == DMA_DEV_TO_MEM) sg->dest_addr = addr; else sg->src_addr = addr; sg->x_len = segment_size; sg->y_len = 1; - sg++; addr += segment_size; len -= segment_size; }