From patchwork Mon Dec 4 13:22:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 173307 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2758256vqy; Mon, 4 Dec 2023 05:24:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IGH63Z+DUFUCFQBHjjgjgB6QItyrAe2bNATLswGxL/xIq3X4tmfaMaC1xz2VQg2N5QlctUG X-Received: by 2002:a17:903:183:b0:1d0:7490:4ab8 with SMTP id z3-20020a170903018300b001d074904ab8mr1414720plg.7.1701696242158; Mon, 04 Dec 2023 05:24:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696242; cv=none; d=google.com; s=arc-20160816; b=0F9BVX0cwcCMo5AeXM3bXhP+Z5qHd453K3Ir0J7H/R9b2w7Dp0Av+YCwftnvyc79bU bqUmgo8O4/xDQCgglEHSKBit4sc+if1F3nhu9lJYNuh0usW+QfmP3Iog+rAbiM7fNIMq Vwyr4gfVTZ6OBiX9Eniq8htP4Zbc2mih0BaDdKiLhWzzn+KLH+8B2QhRZDcrZmGYaWQ4 Uc1EQ0bwGylModhrOLK5t/P8Z4RrskDyvastK6yU2YRWAR//DrcbMn8YUPyYGa+FdDx8 WZtIKw1CBHT1f+MoQKNeaZ51bQjlP4g884xRcAUQ+madsr5/BhWUxplp6gATnfkAgrhY YP8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IioXqpymACN/MUPM5Sp8OLRTPUEwCR4gTME6troSshg=; fh=oTBxGcRaftrfJQcSJqf1JrjXWq/M+yCOtUYEywDUzy8=; b=oiVn3AikgYVpJ+s/plQp93zQ8VE1JLXhYXSBsv9TA1E/oMC5yuXw5di4P3/ik90MW5 XaSSE63Fz9FasSSEdF0nHJvOursS70EJXaFcTm50IiIWKZSeUm1Du7/rP4OlPD6ltbAE 4ye1CVgFUF4/76Uchky16qlmkJ0f/duGJmaZNLQRkV1SjGRXVO/+otCGIH3jlctkzIrF vkgVN70UvDshqIh4E4VgAt98FcAxIKw+WTbV4egJwzKeJwq0sg5qYY99ZT4EdbbMm3Ke +KI7UdUq7ldIpIlpyfNFTElHmfeM2/47bBHruYHprKTjz0FYVuR2Yn6H44AylQSpAiur 7bDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=c8OUxYNU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u6-20020a170902e5c600b001d0be32b0c2si112851plf.48.2023.12.04.05.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=c8OUxYNU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B454380B908B; Mon, 4 Dec 2023 05:23:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344271AbjLDNXj (ORCPT + 99 others); Mon, 4 Dec 2023 08:23:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344250AbjLDNXg (ORCPT ); Mon, 4 Dec 2023 08:23:36 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09020AC; Mon, 4 Dec 2023 05:23:41 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 29BB566071EF; Mon, 4 Dec 2023 13:23:40 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696220; bh=K4kc6aE30aNr8fEMgPpgyQo0QhobUXDuFfbQVHAZRG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c8OUxYNUoNxpwYJm3Jv1Eccbec9duUXulRVJcZPfah9Ps5AxoQrGTqY9Nv/rDIkZd h62H0JaJhtnjssg41JXC9W5DGjCMj5BWY5sTBh92Kxnf/sG7jvw7G1D01v5iRYpRmN WO0axwUsNrncXkx+FahUSDNjJwJZAB9tU6slULf7AkaH68Vrpk/6c7Ex54bQIp1WUl byfVGg/mOmQDngw1WY0Vv2857SGk0e4dvCarAKy2h9qn9Y8HkKjrvN8AJj7KLwcqjr HluZdiPgsWptSJVBwv7eDhx6XB3H7nY2DlEwiy/w48o+9fnOc2O+zgD7lC9Vu3JnH8 JCCiULoihos1Q== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Eugen Hristev Subject: [PATCH v2 03/36] media: microchip: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:50 +0100 Message-Id: <20231204132323.22811-4-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:23:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784357838471040911 X-GMAIL-MSGID: 1784357838471040911 This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Eugen Hristev --- drivers/media/platform/microchip/microchip-isc-base.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/microchip/microchip-isc-base.c b/drivers/media/platform/microchip/microchip-isc-base.c index 3fba0e2844b6..63c39981f47a 100644 --- a/drivers/media/platform/microchip/microchip-isc-base.c +++ b/drivers/media/platform/microchip/microchip-isc-base.c @@ -1821,7 +1821,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier) q->mem_ops = &vb2_dma_contig_memops; q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->lock = &isc->lock; - q->min_buffers_needed = 1; q->dev = isc->dev; ret = vb2_queue_init(q);