From patchwork Mon Dec 4 13:23:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 173335 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2759668vqy; Mon, 4 Dec 2023 05:26:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFoEThoGQDy8BrFFWywGPrErSoyf0Gdc3zJmEbdtcfw2ZEG4uuPZD8cF5WsEK+ux8a8US1A X-Received: by 2002:a05:6358:3a03:b0:170:a67:899c with SMTP id g3-20020a0563583a0300b001700a67899cmr1674167rwe.17.1701696398822; Mon, 04 Dec 2023 05:26:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696398; cv=none; d=google.com; s=arc-20160816; b=rs6wsjpF3scO5B4LZ1XSzVFL9EgeugxDBG2ehxWQHeIy4NUee4u8h1sFsFkTh+6HiW dqwwWnzIAui0uJNLxGyqqIOPAq9+JzwmSAfqwTzklOpTbyH2NSUXKJm3+1NMKVTLLAEl fzNY69ywtCuvg7pnNHGsrlwdms1MfEo65xexc3c/L+P7wbPz4qtRNQZ4J2tys9z2w/FE tx68HT8WAREz2a0YM1XKwVXPzlnErzY0mk2DKwmq9wlG8bnFPUPraNhnPDHc+3ldQHi+ 8S+9oLn6Ha8MWOwcMUuASizqSHZmBWZtctJWBtPsAb64dHwP+8Hlok1daO82ADcFX892 HbxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PbkRfZSSZ4srLIlz7mtfVunyM/RVCejLVDmj0XSYABo=; fh=nikTID0PJ6NwkGNufN11Ag6f/xC6mcRAltiCDIW3jKo=; b=YESPwXtrzobDRgp7M0s72dIDKflpVyQI2M/3Zuq01JZD5VU0GdwNzvx1lW9luuSlDN Oz677yR8fMRldQ9bhjtyj2YTufimRiUdP57VYuWyL3wH5bjRazxDfpsYFtR+s9o78EY9 sWqWJDGWaYvfhRstkx0Eqg6P+pHR5BBoWFs6lucnzYdwzlHYIS/c39ik/67zyVbTIhvO hq5wrTrjrnkq8/d5U9HbqKm+V1dy0IeWe150ymeNwrQczIaNouC6TxQ0TT9yqHZWjHzU ngBFInsFj4tx7XNibKABcgaaeeeZaMLc1CKUX8cF1RIigs2E+/jt7/DpK8p5V4ULXPox eAnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kCooEnmk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id z21-20020a630a55000000b005bdbe64cc26si7882010pgk.535.2023.12.04.05.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:26:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kCooEnmk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D8E3D8067628; Mon, 4 Dec 2023 05:26:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235601AbjLDN0S (ORCPT + 99 others); Mon, 4 Dec 2023 08:26:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344478AbjLDNZ3 (ORCPT ); Mon, 4 Dec 2023 08:25:29 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8121C1BE1; Mon, 4 Dec 2023 05:24:30 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9F272660737C; Mon, 4 Dec 2023 13:24:28 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696269; bh=6CSGRDiRO2lms0wmXZEstJJokqkWndIp5smKK5ehYIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kCooEnmkndIKQN0862GmZwqQIUBTkRANgsq1oGTjWto1LNmPYLRdTfup0Xe/IADHA XW6ubO67cr1Ol1bSKaZ0iWVwX4J3DerDiRTM3Qi/cDhtvyeGs2RDVmKGSdfH2euK64 N/C3juaKclp90MPs/e0oHYFfUuAi4/UCavpliPji0c6iPNf1des2X9QVf1L8TD4SdL 49kmO1YOK3+iQk7uh7j2BN1b1SU24T/JFfOkHami6tc4tQZvvc/DN8Ha9hBvx6j3JA pad2IELQ3EhvWhGBHlCH7N4yOt2O7+FcJJIDwemaR2Y75qX8Y1h9aUeqsBOElvahwX BxdUahsQ2IN5Q== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH v2 34/36] media: saa7146: Fix misuse of min_buffers_needed field Date: Mon, 4 Dec 2023 14:23:21 +0100 Message-Id: <20231204132323.22811-35-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:26:35 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784358002835715735 X-GMAIL-MSGID: 1784358002835715735 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. saa7146 driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard --- drivers/media/common/saa7146/saa7146_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/saa7146/saa7146_fops.c b/drivers/media/common/saa7146/saa7146_fops.c index 79214459387a..db4d725a05d4 100644 --- a/drivers/media/common/saa7146/saa7146_fops.c +++ b/drivers/media/common/saa7146/saa7146_fops.c @@ -387,7 +387,7 @@ int saa7146_register_device(struct video_device *vfd, struct saa7146_dev *dev, q->gfp_flags = __GFP_DMA32; q->buf_struct_size = sizeof(struct saa7146_buf); q->lock = &dev->v4l2_lock; - q->min_buffers_needed = 2; + q->min_reqbufs_allocation = 2; q->dev = &dev->pci->dev; err = vb2_queue_init(q); if (err)