From patchwork Mon Dec 4 13:23:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 173323 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2759157vqy; Mon, 4 Dec 2023 05:25:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4bOST2AwrfEgFom2kzNIJmcQT2gYnjpDCQRY3+o0bhw0C3VHW5AtfPAStXwQ2daIc5DsZ X-Received: by 2002:a17:902:968d:b0:1d0:6ffd:9e25 with SMTP id n13-20020a170902968d00b001d06ffd9e25mr4185181plp.119.1701696344952; Mon, 04 Dec 2023 05:25:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696344; cv=none; d=google.com; s=arc-20160816; b=MrrgyoQU1106mSWF8LTvfFbH71L/vnQsT99WEtbzEByIb7JQXZixi6fcKc2Q+wsg4Y tJK1WEL2yQMoqcbfpxNP9uM4vdxyhfY3kXnV1z1/KfEdtI08SO8LutvIm7ZXo9/e+Zce 8TjQCfUfEgLkvG4tmXr6kf3bGgHx54jIqryX2y+UVnDbjrlW31Zso+upi1+HKGa5THDe pgh5O6uJhSDQRMOrLAPdxmU2MGBMz/u/bgfhe9ITzdiRX/7/xOUE3k7WhNMmh4TFe/K3 1q1dscRKxz3GPQtkTDR21Vzvhq8IEtImoOESJoa737tob4VkA9+QNB/Q7BURB/LWcB5k +XoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PQJwEtmOmV1WWnAc4EjHXMpTePpnZokIAEbYo6DAeY8=; fh=Q2+fBkTJFlOmvn/gakNfgOGMSuLeah3jspZE8+tcJ+8=; b=GVJIqXhZxy44O0oJVXrQ+icbwf29nGKih2LJ1vNr9hVcCFqYmQtqfOY8iAk6LYuZ71 76YGJEfA/g0U0zlCKHJx35KABpZSDyk0JY2VSMoZWk390ZCSgYHUY6sHpP7CZnt7wXsf ys2ghbT8RSAMh/V9Grp8NIT71Ix2G+sLRuzLAv3kLPSY4oz44p6tp6cYvaTRZM50Q/Fc nIDwAY5PbFXjhoH9sHM84Q6qkgup/glXPoDpF1hiUml8YBoGv4Xxba9829mgO2Q00lTi 6gdnCtLEVFqmtpwUksUGa+OFNG4Bugr0W1HLVDsfuuYVcLPwj8LzyT4eGfyJAWR0Npc6 B7wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=d+ot2jI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id n7-20020a170902d2c700b001c60c5bbff2si7879849plc.201.2023.12.04.05.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:25:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=d+ot2jI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id EFF46809F893; Mon, 4 Dec 2023 05:25:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344206AbjLDNY5 (ORCPT + 99 others); Mon, 4 Dec 2023 08:24:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344513AbjLDNYT (ORCPT ); Mon, 4 Dec 2023 08:24:19 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00410D8; Mon, 4 Dec 2023 05:24:15 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 50E6B66072A4; Mon, 4 Dec 2023 13:24:14 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696254; bh=q+PBOieh7TUOZfOTD/eax3kPGizf1naDWVCgdVzk/Rg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d+ot2jI04YYP3nNR4UaNzhMsi2OZw+QIwwxMc1qtNVNr2FZVmsM8qk2SnXAwymoiy YHFHpH26jUSYcsTSJc6NDNnWsNSvL/vEirCI4D7Vyi4u2d/Mi5y92f3c+qQ0toA4rF iaZp4BOWgLaUUYk+DCauT/jaJJc8KTNzBQIfo1XNVjDHfLMkQWDiEV7uXyllW1Pu8S F/OQ7P/8s2+syp5bL39Sggb3KDBEcVSC1896Y2CSbVC0VeO8EEaDiFyJ9ETdYGq/ij 7Zz8sIdixI6XoEX5+pC6Z1c4z2Uh8wMmDQKSoMl2flZjeu0owqGUSp4AOPKQsb2kfy 6lWfp2P42sW5g== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Jean-Christophe Trotin Subject: [PATCH v2 23/36] media: sti: hva: Fix misuse of min_buffers_needed field Date: Mon, 4 Dec 2023 14:23:10 +0100 Message-Id: <20231204132323.22811-24-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:25:38 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784357946287897253 X-GMAIL-MSGID: 1784357946287897253 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. hva driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Jean-Christophe Trotin --- drivers/media/platform/st/sti/hva/hva-v4l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/st/sti/hva/hva-v4l2.c b/drivers/media/platform/st/sti/hva/hva-v4l2.c index cfe83e9dc01b..d7bc25b0d69e 100644 --- a/drivers/media/platform/st/sti/hva/hva-v4l2.c +++ b/drivers/media/platform/st/sti/hva/hva-v4l2.c @@ -1142,7 +1142,7 @@ static int hva_queue_init(void *priv, struct vb2_queue *src_vq, src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; src_vq->buf_struct_size = sizeof(struct hva_frame); - src_vq->min_buffers_needed = MIN_FRAMES; + src_vq->min_reqbufs_allocation = MIN_FRAMES; src_vq->dev = ctx->hva_dev->dev; ret = queue_init(ctx, src_vq); @@ -1151,7 +1151,7 @@ static int hva_queue_init(void *priv, struct vb2_queue *src_vq, dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; dst_vq->buf_struct_size = sizeof(struct hva_stream); - dst_vq->min_buffers_needed = MIN_STREAMS; + dst_vq->min_reqbufs_allocation = MIN_STREAMS; dst_vq->dev = ctx->hva_dev->dev; return queue_init(ctx, dst_vq);