Message ID | 20231204132323.22811-16-benjamin.gaignard@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2759307vqy; Mon, 4 Dec 2023 05:26:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBnb6Q6m06N10UD2+jLUA8TJTVf5olJirBdFKN6aILKN5WrLMf3Wf3mfohAJNGTDAxh7Sq X-Received: by 2002:a17:902:a98b:b0:1d0:6ffd:8348 with SMTP id bh11-20020a170902a98b00b001d06ffd8348mr1304881plb.83.1701696360527; Mon, 04 Dec 2023 05:26:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696360; cv=none; d=google.com; s=arc-20160816; b=jL/FrLS9wdYWUUd2wmOPD9/h1o/EoyqCLpbVjvl6xWb3mRysS6NqkT24RMvvyLNfOL wPqFSuXK/hvi2JraKkrit1fvoJQOGk+a1FaApc6ZHKKZqq7+B0Tek2sZwAaTZyzV6gzl DGWcwHyViWnUjxsu3IAvMYC26AjimJ5wcPeHFjDyA3TU8y0csGQK9Qfzr4JnCHKzYjjL VEYvhSBW6vOYmIG4IUrZBw4EC+N3w0f6o5jtTwalyWxFcu8jY4ffn05YRYty0Pzg2iwT vGRe3OgU0+m1KYZa9u5XZap2airwEeN1yAbOY6VN9knXDDQn0ZkQQ+xEuyBsH6xg8633 bbdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lY//fy0IHfLBSa9Pn2kLo+eycY/XdjQVI/4ZSSgpz5I=; fh=kFeEET2Sn7AfPPwZWtXJEfQj1r+0ZzDCkmJDn3z6yDY=; b=ShIbT2EGIjylCveF5UZ7bHp1Tt4HiuOFkxVpT8IuEfLnDPvrUUj0AdG7MvZKp1CAjv VG7DcsF1X13XuLU0xGlcTEIEQWiJG0yuVD1LZ147tZsY8Cl0aeinJeXJumx4Ce3L9cz3 fMS2TYa9PD2iYGMBeLeSLRQGTv76EXojb67ImhTGTU25dpaNU7MvE61zaRCKJ4fAeeqZ /2qmiJ/3DCkSTK2+I6a+fB/6nEOK6fqVvR5NWSQnp0C9Ybqx9xPYvDAIhbYw3E0ecq3A sACUBfH+m49d48khrX5s2KlRgBsjw/eNav8Q53bCGF4vb2ZBQ1SFh10vSWIm6ds9L8/n Gw3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ScY/owUY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id x18-20020a170902ec9200b001d0b3c280f9si932645plg.501.2023.12.04.05.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:26:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ScY/owUY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id E732D80966E2; Mon, 4 Dec 2023 05:25:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235565AbjLDNYe (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Mon, 4 Dec 2023 08:24:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344468AbjLDNYF (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 4 Dec 2023 08:24:05 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92C1418F; Mon, 4 Dec 2023 05:24:04 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id B79946607090; Mon, 4 Dec 2023 13:24:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696243; bh=hw+EcJmQWwZPR1A5B99ReLj35TY7AMeTL9JoTuzkKAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ScY/owUYVMArpLwsZLqwD8BURKTytyZwaGhIdZHnATD5V85sPJdmyfgFtfJ3W58n1 AzJOV3V9/JsgScBZdgNAdJY9+25vMZ5RiDFw9inseTsVPtLLrZ+jueagxnryoW3wk0 3Krn8WecTG7xtTt3bIhU/cwVFCTe7JG7YYmjkJLgi3dkMOw9vVOqt5Puo4w3vwMvrr dTxcbbpDVNka5SRJH3yZagQbR3c96AdjTNGETYIVjf1cQvRFDZkUEKXg9qT7b7CTe3 aFnm2Cg6rjBUGVDvm5fxjhAtsj/PK3ikUklYREsbhNeyZD/tQpaFVkqWXKI5TmAM1r GaIgzX1iEKCzw== From: Benjamin Gaignard <benjamin.gaignard@collabora.com> To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard <benjamin.gaignard@collabora.com>, Yong Zhi <yong.zhi@intel.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Bingbu Cao <bingbu.cao@intel.com>, Dan Scally <djrscally@gmail.com>, Tianshu Qiu <tian.shu.qiu@intel.com> Subject: [PATCH v2 15/36] media: pci: intel: ipu3: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:23:02 +0100 Message-Id: <20231204132323.22811-16-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:25:13 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784357963001753635 X-GMAIL-MSGID: 1784357963001753635 |
Series |
Clean up min_buffers_needed misusages
|
|
Commit Message
Benjamin Gaignard
Dec. 4, 2023, 1:23 p.m. UTC
This driver uses min_buffers_needed which vb2 uses to ensure
start_streaming is called when at least 'min_buffers_needed'
buffers are queued. However, this driver doesn't need this,
it can stream fine without any buffers queued.
Just drop this unnecessary restriction.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
CC: Yong Zhi <yong.zhi@intel.com>
CC: Sakari Ailus <sakari.ailus@linux.intel.com>
CC: Bingbu Cao <bingbu.cao@intel.com>
CC: Dan Scally <djrscally@gmail.com>
CC: Tianshu Qiu <tian.shu.qiu@intel.com>
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 -
1 file changed, 1 deletion(-)
Comments
On 04/12/2023 14:23, Benjamin Gaignard wrote: > This driver uses min_buffers_needed which vb2 uses to ensure > start_streaming is called when at least 'min_buffers_needed' > buffers are queued. However, this driver doesn't need this, > it can stream fine without any buffers queued. > Just drop this unnecessary restriction. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> > CC: Yong Zhi <yong.zhi@intel.com> > CC: Sakari Ailus <sakari.ailus@linux.intel.com> > CC: Bingbu Cao <bingbu.cao@intel.com> > CC: Dan Scally <djrscally@gmail.com> > CC: Tianshu Qiu <tian.shu.qiu@intel.com> > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > index 5d3b0ffd3d08..7f72be686981 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -1589,7 +1589,6 @@ static int cio2_queue_init(struct cio2_device *cio2, struct cio2_queue *q) > vbq->mem_ops = &vb2_dma_sg_memops; > vbq->buf_struct_size = sizeof(struct cio2_buffer); > vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; > - vbq->min_buffers_needed = 1; > vbq->drv_priv = cio2; > vbq->lock = &q->lock; > r = vb2_queue_init(vbq); I can't really tell if this is needed or not. Definitely needs to be reviewed by Sakari or someone else with sufficient knowledge of this driver. Regards, Hans
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c index 5d3b0ffd3d08..7f72be686981 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c @@ -1589,7 +1589,6 @@ static int cio2_queue_init(struct cio2_device *cio2, struct cio2_queue *q) vbq->mem_ops = &vb2_dma_sg_memops; vbq->buf_struct_size = sizeof(struct cio2_buffer); vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; - vbq->min_buffers_needed = 1; vbq->drv_priv = cio2; vbq->lock = &q->lock; r = vb2_queue_init(vbq);