From patchwork Mon Dec 4 13:22:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 173312 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2758520vqy; Mon, 4 Dec 2023 05:24:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGisvoPEPGapmG6AKw0h2cfUIRKLBDQEeYz2tVclszZN+YI4Q06FvHuQoaw0kgmI8LoxZuW X-Received: by 2002:a05:6a00:6c98:b0:6ce:3e7a:cfad with SMTP id jc24-20020a056a006c9800b006ce3e7acfadmr1911785pfb.0.1701696273442; Mon, 04 Dec 2023 05:24:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696273; cv=none; d=google.com; s=arc-20160816; b=H8OwvdUu++T9La6s/ljJzo7EPbNOjbanjpfJ2agV11RS9w6F/0JbEcokvVnjr/aMRa /QBBACkJFjY0JvWh8aULWk85Ks/oTSBY4XWamOhbhC+lXyrjDo3hRHN2E+QGyBHay2MS ZBEimsbKYJap+3VUsrYSsBvcg4jwJFqrgSg8uUK7zxT0kUpb0QyE1AFaTT2vXB6e2Gxj A92Pv1uGAu2Mo42cQgzgZobnxQhgwW9MvNxn1etKTXWM0xmSEyrQkvioPcjqQ9iRSUHv ffshEZJmndLOfpDvTmH3TvDtmkH+MHGY0ra/CctOPhxoW2Q6vJRAuwUF22xvwJ5xtnS8 xy+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=epgr0b+kV0rT5B64r8fFXjPHDkYZ0xSm0fbjMGiOpr4=; fh=kHaBZwgUF1FrZPBMSZEmpAMyWRf4p+095v8m4+7t5pQ=; b=MiQk0V3dmNrdnTHcdav//wRat996srn9/RlA5oc/bxz9bL4yoW760OabBx8Cby3wYu ay00O9hDP5Z2YVJBoZc76v6x4PKLvV/8wv40hYVHdpK7z0yDyzJVDaHa127WqBGZCoz+ WA+rUSe1nRR72tyMaRufdV0bKCho8WSLmST348DYlI8rEYoujARkSOtBc6auibPPKuIH pCiom6+itXSiHqX6XOFeKUgzp/jsxPerw8+Xv98aMN+kyQrw1SpnDpdPk6UbYd22PVqL dI1zAsJ6LCemZt5vf31e0EAljsKD86+zdc4WACocWCmP9bhr6vwF5bLHf9GQIhwfvgSG 9T1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=fpiHlguw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id r5-20020a632b05000000b005c670f98a72si2831844pgr.116.2023.12.04.05.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=fpiHlguw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1B297809E8F7; Mon, 4 Dec 2023 05:24:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235505AbjLDNYF (ORCPT + 99 others); Mon, 4 Dec 2023 08:24:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235425AbjLDNXw (ORCPT ); Mon, 4 Dec 2023 08:23:52 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D71151B8; Mon, 4 Dec 2023 05:23:54 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0085F6607090; Mon, 4 Dec 2023 13:23:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696233; bh=oOWz24gQ5YvCYqxsrt9/vTKzJDstMTwD0f8jUu4NRTk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fpiHlguwrMYeN1mEYBkELVL33tKiT1KR1nwYsrEn7jLbmYp4MWuEE2MQQ89kigGaS yiQkxZn5OjeQE6coLIgMLBpL6BUnC8Hxzlg44paOrvCSuKR3YBpPHmPc9zkaHWY4NV vU6EeU0+6cVc/8WmEtol8w1LDdFE6uEA5k4yN+zchWyxCK+X+OI/A3ozs8+fJ3hmBK ZixewklE7l4VrRbXm1HKQs4N/xwTNfA7icvXNmILAHbE4B/dBzM3N+zDaeAmIwEckF GmmQriTDYBxHDpJi4NRMUBVg+itb6l75/d9niz8NrIf3jmVvYh+2SxyAnz1VXzBgx/ inX3JLYW+QaSg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Sakari Ailus , Bingbu Cao , Tianshu Qiu Subject: [PATCH v2 09/36] media: ipu3: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:56 +0100 Message-Id: <20231204132323.22811-10-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784357871526377933 X-GMAIL-MSGID: 1784357871526377933 This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Sakari Ailus CC: Bingbu Cao CC: Tianshu Qiu --- drivers/staging/media/ipu3/ipu3-v4l2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c index 0fe2b858da83..7f9104411edc 100644 --- a/drivers/staging/media/ipu3/ipu3-v4l2.c +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c @@ -1197,8 +1197,6 @@ static int imgu_v4l2_node_setup(struct imgu_device *imgu, unsigned int pipe, sizeof(struct imgu_vb2_buffer); vbq->buf_struct_size = imgu->buf_struct_size; vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; - /* can streamon w/o buffers */ - vbq->min_buffers_needed = 0; vbq->drv_priv = imgu; vbq->lock = &node->lock; r = vb2_queue_init(vbq);