From patchwork Mon Dec 4 09:35:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 173158 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2647593vqy; Mon, 4 Dec 2023 01:36:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWjB8nHonriW+FqlFvzhoDhMVz8ZtYRStYjCeX2zHw4bB5E4OLU2IWeeshNibM6SKeZydX X-Received: by 2002:a05:6870:304a:b0:1fa:1719:dce2 with SMTP id u10-20020a056870304a00b001fa1719dce2mr4439452oau.28.1701682579556; Mon, 04 Dec 2023 01:36:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701682579; cv=none; d=google.com; s=arc-20160816; b=GiGsNTP2t8/t4mGZrvHG0XiXxMf2bBAAnwI0+2SAij7BJBzVy0INkQl5OHSAmakZ7y wxzopIpFTzGwedV6Txd00A+T5Z73PP2LrTWgbtlEB5haHTDr0mwkThtFyxn5ayi+K3sk b2BsdL0jz4dAnOv1H0B5qd60/+twGzduw0pv6H1O1KXQT2L41uDi6BC3SesDSZsBHv9Z DfIcM1gL5mXRa/TZ+/k2Td37xDwIn4ycFkfQ+Akmm0bnmxhPKkf6mXMV4YFqR4ZpcRCT Ca3eGlfJNHF3kAZLBzbHgTU3PnzfUfs5ZEG+L3eTLSjraTuhl3zyhyfNMi+hmOUoOiRA DQcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/NPguL+egm1B/3hLyNOqRomxlJRtvAY3YVXSaylJwM0=; fh=fw6biwzn34ngIUS3OuPB+D+TvAzoz1YwnvitHxA+Jyw=; b=ZPgiC5ZWm8k1MT+qXaPYvm+u6laia7+N5t21jqLknqzsCv9LqKBmc1NQFkcfqpbCW5 Do4FFeTBHsp/ujUC+BF+LgiEBl7VF+H/HQ9+JeRV4ZonP62U3GquIgGRD0bO9bZSUIIX ZtPDyk9/f0SmgZe6q4veyDARnFNygATkN17P6mh840GbdeyO/Lg/FPxdPa86Or41QJ5R msnxHm3r+lXOQTTgINLNWnmvWNscNniKGLgXn7lBbwfU/JIn3MDjnUmJI1DHoSXO3U3G weTkAGBoOOj+Ov6WAMOiI7Mfa0yr3eOpbc5fKYPEC57lGM65I97ZNskmjwB3Mvdksrmh HRVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=ZQseQcjj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id v21-20020a63d555000000b005c661efffcbsi3294680pgi.78.2023.12.04.01.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 01:36:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=ZQseQcjj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2C5F98057E18; Mon, 4 Dec 2023 01:36:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235270AbjLDJfg (ORCPT + 99 others); Mon, 4 Dec 2023 04:35:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234826AbjLDJfT (ORCPT ); Mon, 4 Dec 2023 04:35:19 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08F30189 for ; Mon, 4 Dec 2023 01:35:22 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40b2ad4953cso32575675e9.0 for ; Mon, 04 Dec 2023 01:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1701682520; x=1702287320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/NPguL+egm1B/3hLyNOqRomxlJRtvAY3YVXSaylJwM0=; b=ZQseQcjjE+vW5TPsgSz5KrYkfQTCIA6JQRU8NbwG8EpVeNocOrwzqc7U0UJ60XS6Ql aZfduINkqhk14CIRz9EtuRkJ5HxXKgZziDI109WUmJbDC1FP3IvZBPKfab8JCMlmNiaS J4qsMBI0fG9gPt0xBUPdZBazOjrFPNb9opGkN6ouytFKynm5mr7Nk6DzsTDW7vltbpwh 6nxUBzZ76jyzMEH+jDpa13qurOt/e/CJjoH381HYQQVfhfNnlQZmK8H+F9fN4fjXvZTj lyB/i4P/1fsapV3gv/vhs8o3CEfjVm09AJRLjqMlncll6S6HsOqQ5Je2rLGE5LHxCtt+ EmJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701682520; x=1702287320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/NPguL+egm1B/3hLyNOqRomxlJRtvAY3YVXSaylJwM0=; b=uLWM3Px5fQxgTRg4kLJCJIBv8+64w6g0Ejq0mI5L8NFFyYxrZRLGx5paocp7fJAAr8 KsaJgLnbA/JaaIVRiHhdh8t0rstwd0Mr+6eZw6c1jsSMJbmRzOP9CotD+Z2cnOQXS1To 2iKFPXMkm1ImF+Yxum1CCAYEpDIo7CF/O2d0fJ4z96qukyekfA0FoA9k4kFpoDRJoA3/ Weg6MF2fuBZJAcKFU+6oKb6WKJLN1L7AlMubah+3JMyRXsg8VVPWY55WQdAK+GLPR1Hg 5UhT7JYAfJI9kD5UssUVP3TQ5F1O3rlz5fA1ns7rWfF2BgDYUEm5Z4Zs1NaOjEhUsbHA TvpQ== X-Gm-Message-State: AOJu0YxWa/WMS+XDRSIXqHjElxr6SNd+VMcbpyOpbmKoGO9xIT8zuAJ1 o0EzZgNHJ2lTlfUbN6BypDwaSg== X-Received: by 2002:a05:600c:44c7:b0:40b:5e4a:2376 with SMTP id f7-20020a05600c44c700b0040b5e4a2376mr2513988wmo.120.1701682520303; Mon, 04 Dec 2023 01:35:20 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:4cb1:229e:8c33:122a]) by smtp.gmail.com with ESMTPSA id fs16-20020a05600c3f9000b0040b48690c49sm14266219wmb.6.2023.12.04.01.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 01:35:19 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 06/10] pinctrl: nomadik: use gpiochip_dup_line_label() Date: Mon, 4 Dec 2023 10:35:05 +0100 Message-Id: <20231204093509.19225-7-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231204093509.19225-1-brgl@bgdev.pl> References: <20231204093509.19225-1-brgl@bgdev.pl> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 01:36:12 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784343512958290328 X-GMAIL-MSGID: 1784343512958290328 From: Bartosz Golaszewski Use the new gpiochip_dup_line_label() helper to safely retrieve the descriptor label. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 863732287b1e..7911353ac97d 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -8,6 +8,7 @@ * Copyright (C) 2011-2013 Linus Walleij */ #include +#include #include #include #include @@ -917,7 +918,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev, struct gpio_chip *chip, unsigned offset, unsigned gpio) { - const char *label = gpiochip_is_requested(chip, offset); struct nmk_gpio_chip *nmk_chip = gpiochip_get_data(chip); int mode; bool is_out; @@ -934,6 +934,10 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s, [NMK_GPIO_ALT_C+4] = "altC4", }; + char *label = gpiochip_dup_line_label(chip, offset); + if (IS_ERR(label)) + return; + clk_enable(nmk_chip->clk); is_out = !!(readl(nmk_chip->addr + NMK_GPIO_DIR) & BIT(offset)); pull = !(readl(nmk_chip->addr + NMK_GPIO_PDIS) & BIT(offset));