From patchwork Sun Dec 3 09:49:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 172923 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2158873vqy; Sun, 3 Dec 2023 01:50:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3ifZDeIPqIFtcH3sYCLi7+06PMOFg5MdplVabdIQLACXE/Q23MDuU/TjmTv8cijFH6Cht X-Received: by 2002:a17:902:e883:b0:1d0:93d1:b19c with SMTP id w3-20020a170902e88300b001d093d1b19cmr455057plg.13.1701597016331; Sun, 03 Dec 2023 01:50:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701597016; cv=none; d=google.com; s=arc-20160816; b=FtGO8j75dmbto+hZ24LYlVLKfzuK7uUQkrMB4ZGLz9QYHlzNEisy9Zt5KZ+HH37WxV ASZwUkcUMr+ZXVyny2XPCedE+HoH2Ukp5ZJRMeBFwlzceKRCpHpLm+OlCD0kD014B8IQ vA4XDj4YsPzQAfxuKvyRlehpCXzgNkjrvDTJcD2QbIR2v4fiwsHi5Zr28QPBBEHJ8j9O 1xr/tmTHC3vYZokkX5oA9NdUK3ydNH1aN93XHqgvhrhKPXPl4Sex4wh3O8HgHg1hHmNp dVBlLGwdqn/ybsnVt1n4JCji7M67tIryLgYMyWPHzObnFzlbsoddW/opXxQu0BjI4lI6 3r6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WwSUxpvNbpHEFj89ltje+ECirCiC4B9RnOHF5NAiUz4=; fh=C99EpQazXaiSvqwsMVoK+n5/qdfhLqLnxroWjLlHl7s=; b=zv//nFI9caF7smY2vuDj+kiA/r2PFWQCNH0Ul2xZpIGvoyFLR0o3s1DJPrV0IntWBr at+WB+jlJCR17SSvZopcYDZfAxj30osrSiDVyv0v/dST0r7TOyRfriBFCxj6pzFnpt3D Ts1LgAwo+WwJlWe5yGTreHpUx+gB/QqDP+cc4+4iHO7hhbvYmzLdUTXqVpfUzCxSAohT +eKJXXQAD0XcjawoEOiEyYv7C1pJnfQuWcffpeNcTvtFHQf5lEDM4T6hFW1cm8f0obAe iYw1TJuprjd0+aKmA/PfzddLSM/CFk3KxKUJu/6VJ2jbdRW0nqvg7x8RW4gJsoWkpbfE 8ZPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdCQBWpJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id 6-20020a170902c14600b001d091c3aaefsi531237plj.485.2023.12.03.01.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 01:50:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdCQBWpJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7E1D88097884; Sun, 3 Dec 2023 01:50:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233322AbjLCJtx (ORCPT + 99 others); Sun, 3 Dec 2023 04:49:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjLCJtv (ORCPT ); Sun, 3 Dec 2023 04:49:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 005B8DA for ; Sun, 3 Dec 2023 01:49:55 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19F62C433C9; Sun, 3 Dec 2023 09:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701596995; bh=DQgligyVko6JOkpsukWsLHEde1ox5xe3QB7/zY+o3mc=; h=From:To:Cc:Subject:Date:From; b=MdCQBWpJATcuy0G8YGsVOOdYN6tVbI+HTba5TIrjOmIdUpI/IfuDMiUCCkk7sxNOq f3f/l9bHGyWii4wNCS7cbYACpBT403QtK+zJ5DgB2ui3BjGnMUuALVc3pH6EgBV+ZI bQoRQ43aqM5VVIqg4x2SgfId0j9Na0Kpei38vJLAFyQZjbZpa6FY388+nCMt+T9mz2 WCCxyX4ceHbHSwI6nMxJRsjNCwtJZZe417YofNj8Ew+3LU0mvm/YcM1BqlurDizojU D/xH2D1K9j8HnYPQ3I/ptSgdJbp5bvb3/ejDqp5Cz9+Qw3776utGljLpRllPyvimkF cOzThHeNnVlxg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Nathan Chancellor , Andi Kleen , Nick Desaulniers , Nicolas Schier , Sam Ravnborg , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] modpost: move __attribute__((format(printf, 2, 3))) to modpost.h Date: Sun, 3 Dec 2023 18:49:31 +0900 Message-Id: <20231203094934.1908270-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 03 Dec 2023 01:50:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784253793014296887 X-GMAIL-MSGID: 1784253793014296887 This attribute must be added to the function declaration in a header for comprehensive checking of all the callsites. Fixes: 6d9a89ea4b06 ("kbuild: declare the modpost error functions as printf like") Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor --- (no changes since v1) scripts/mod/modpost.c | 3 +-- scripts/mod/modpost.h | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index cb6406f485a9..ca0a90158f85 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -60,8 +60,7 @@ static unsigned int nr_unresolved; #define MODULE_NAME_LEN (64 - sizeof(Elf_Addr)) -void __attribute__((format(printf, 2, 3))) -modpost_log(enum loglevel loglevel, const char *fmt, ...) +void modpost_log(enum loglevel loglevel, const char *fmt, ...) { va_list arglist; diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h index 69baf014da4f..9fe974dc1a52 100644 --- a/scripts/mod/modpost.h +++ b/scripts/mod/modpost.h @@ -197,7 +197,8 @@ enum loglevel { LOG_FATAL }; -void modpost_log(enum loglevel loglevel, const char *fmt, ...); +void __attribute__((format(printf, 2, 3))) +modpost_log(enum loglevel loglevel, const char *fmt, ...); /* * warn - show the given message, then let modpost continue running, still