Message ID | 20231202125948.10345-3-karelb@gimli.ms.mff.cuni.cz |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1754906vqy; Sat, 2 Dec 2023 05:18:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9aEvSoP6dgRw6W9fkiRM/+vOMlLiWcg1cWqYxZrFJfiJGHYHRl51slW/EpOwDgOgJDTZ0 X-Received: by 2002:a05:6a20:12c6:b0:18c:726:920a with SMTP id v6-20020a056a2012c600b0018c0726920amr1469690pzg.26.1701523101197; Sat, 02 Dec 2023 05:18:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701523101; cv=none; d=google.com; s=arc-20160816; b=w2nh/TsamolGAGee8q5uuQP5i7Q57JUTYLG2aUn9DBxUJiblvGFMzex0dI0z+ms422 3BHYJgecPc8wP15O/Mvjza4MgisDc2tbiI3oFGgcCCjUPPA+1MA8S+jZpYW0ASFrsrFm 5ebpZRcsav1vkBHJ4kt9heLb5jz/o+mvTORHeho2ksLfrEC+9nPWEr9lbqswpMstjWJi 1XPSq1X3tzBSmGfOUVpY/6nZfDMpGXZAOmi1cVvknqOLsNfomhD4LfbgJKGFiCSGkCGW T/vhpT2qH2WQbxJmurtr2ciZEAAtf1eezkDppyRHR1AUnH/axJQ18uJQTEPg40poFyoj 9RAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AU4qbb6SFdiunbgMHDeonXdJnOEkLjt+I8oSX+xThLI=; fh=JqA0Xee0/CWumczA5TuyC+7WXtsf+tJMEa8SbRnVgwI=; b=GPL5Aa7BTuuqGasML+m+iaib2IYIzTwhOzK/yUyx4hAKPjEt0x+ZWGTRJ5ihpRMoGS Iixmm2p+/mAqkpVxXAypgg2ldKLspJaRH0zLsNiEdJoKyIBq37n5U4qefs7jraTswrt9 BUdGCjh04AiUPKcih0/fCurYUMPyVkhu308Sby5reSH3ZrHQbcGB800SXbXzTEQCTEj4 Qxp1WLm4pfUn6i2FFHrtjBz+ZIsIIsq8xzlesS39gei2aqJxRLgxV0FUF65v4KvzLmt9 FxxWLeq2eGPs7Hs4bkVhY6DyUZ9v7aSUGGMdb9VWyHf4wefwTZeSntoVZSFh0Bvi5As+ 2xWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=yWsKCIZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id k29-20020a63561d000000b005c6251da182si4925567pgb.226.2023.12.02.05.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 05:18:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=yWsKCIZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D825680937B3; Sat, 2 Dec 2023 05:10:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232844AbjLBNJm (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Sat, 2 Dec 2023 08:09:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjLBNJf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 2 Dec 2023 08:09:35 -0500 Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4F3D188; Sat, 2 Dec 2023 05:09:39 -0800 (PST) Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id D418C28BDE9; Sat, 2 Dec 2023 14:00:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1701522034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AU4qbb6SFdiunbgMHDeonXdJnOEkLjt+I8oSX+xThLI=; b=yWsKCIZSnA25XjwyVVm+kLs7v1G4h7lnQYarPdD5V7EagiEdfxHqzrW6MNj7cKJLpjuLgZ 8zSmJ6D294ILuKzKjvRgNG2osEZyD6Ys4JJ/8jyYJe1240rjXq2g6RXopBw1MIlbNg3paA z81rDkNeqivWtxl3BDzrIGDa+nYwE7M= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id B07E544C9FF; Sat, 2 Dec 2023 14:00:34 +0100 (CET) From: Karel Balej <karelb@gimli.ms.mff.cuni.cz> To: Markuss Broks <markuss.broks@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Henrik Rydberg <rydberg@bitmath.org>, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr>, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Karel Balej <balejk@matfyz.cz> Subject: [PATCH v3 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B Date: Sat, 2 Dec 2023 13:48:33 +0100 Message-ID: <20231202125948.10345-3-karelb@gimli.ms.mff.cuni.cz> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231202125948.10345-1-karelb@gimli.ms.mff.cuni.cz> References: <20231202125948.10345-1-karelb@gimli.ms.mff.cuni.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 02 Dec 2023 05:10:14 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784176287319119380 X-GMAIL-MSGID: 1784176287319119380 |
Series |
input/touchscreen: imagis: add support for IST3032C
|
|
Commit Message
Karel Balej
Dec. 2, 2023, 12:48 p.m. UTC
From: Markuss Broks <markuss.broks@gmail.com> Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, add the compatible for it to the IST3038C bindings. Signed-off-by: Markuss Broks <markuss.broks@gmail.com> Signed-off-by: Karel Balej <balejk@matfyz.cz> --- .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + 1 file changed, 1 insertion(+)
Comments
On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote: > From: Markuss Broks <markuss.broks@gmail.com> > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, > add the compatible for it to the IST3038C bindings. This one is better, but would be well served by mentioning what specifically is different (register addresses or firmware commands?) Cheers, Conor. > > Signed-off-by: Markuss Broks <markuss.broks@gmail.com> > Signed-off-by: Karel Balej <balejk@matfyz.cz> > --- > .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > index 0d6b033fd5fb..b5372c4eae56 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > @@ -18,6 +18,7 @@ properties: > > compatible: > enum: > + - imagis,ist3038b > - imagis,ist3038c > > reg: > -- > 2.43.0 >
Hi Conor, On 12/3/23 13:20, Conor Dooley wrote: > On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote: >> From: Markuss Broks <markuss.broks@gmail.com> >> >> Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, >> add the compatible for it to the IST3038C bindings. > This one is better, but would be well served by mentioning what > specifically is different (register addresses or firmware commands?) I don't think anyone knows this other than Imagis itself. I would guess it's different hardware, since register addresses are indeed different, but on the other hand, there is a possibility that firmware on the MCU could be responding to those commands. I suppose "... IST3038B is a hardware variant of ... IST3038" would be more correct. The reason why I think it could be firmware-defined is because we have a lot of variants (30xxA, 30xxB, 30xxC, plain 30xx), and the numbers usually mean feature level/completeness, e.g. some don't support the touch pressure or touchkeys, and we don't know what A/B/C/none means. > > Cheers, > Conor. > >> Signed-off-by: Markuss Broks <markuss.broks@gmail.com> >> Signed-off-by: Karel Balej <balejk@matfyz.cz> >> --- >> .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml >> index 0d6b033fd5fb..b5372c4eae56 100644 >> --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml >> +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml >> @@ -18,6 +18,7 @@ properties: >> >> compatible: >> enum: >> + - imagis,ist3038b >> - imagis,ist3038c >> >> reg: >> -- >> 2.43.0 >> - Markuss
On Mon, Dec 04, 2023 at 02:40:44PM +0200, Markuss Broks wrote: > On 12/3/23 13:20, Conor Dooley wrote: > > On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote: > > > From: Markuss Broks <markuss.broks@gmail.com> > > > > > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, > > > add the compatible for it to the IST3038C bindings. > > This one is better, but would be well served by mentioning what > > specifically is different (register addresses or firmware commands?) > > I don't think anyone knows this other than Imagis itself. I would guess it's > different hardware, since register addresses are indeed different, but on > the other hand, there is a possibility that firmware on the MCU could be > responding to those commands. I suppose "... IST3038B is a hardware variant > of ... IST3038" would be more correct. Only Imagis might know the specifics, but you (plural) have made driver changes so you know what is different in terms of the programming model. I'm just asking for you to mention how the programming model varies in the commit message. Otherwise I can't know whether you should have added a fallback compatible, without going and reading your driver change. The commit message for the bindings should stand on its own merit in that regard. "Variant" alone does not suffice, as many variants of devices have a compatible programming model, be that for a subset of features or complete compatibility. > The reason why I think it could be firmware-defined is because we have a lot > of variants (30xxA, 30xxB, 30xxC, plain 30xx), and the numbers usually mean > feature level/completeness, e.g. some don't support the touch pressure or > touchkeys, and we don't know what A/B/C/none means. Ultimately whether it is due to firmware or the hardware isn't particular important, just mention what is incompatibly different. Cheers, Conor. > > > Signed-off-by: Markuss Broks <markuss.broks@gmail.com> > > > Signed-off-by: Karel Balej <balejk@matfyz.cz> > > > --- > > > .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > > index 0d6b033fd5fb..b5372c4eae56 100644 > > > --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > > @@ -18,6 +18,7 @@ properties: > > > compatible: > > > enum: > > > + - imagis,ist3038b > > > - imagis,ist3038c > > > reg: > > > -- > > > 2.43.0 > > > > - Markuss
On Mon Dec 4, 2023 at 1:52 PM CET, Conor Dooley wrote: > On Mon, Dec 04, 2023 at 02:40:44PM +0200, Markuss Broks wrote: > > On 12/3/23 13:20, Conor Dooley wrote: > > > On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote: > > > > From: Markuss Broks <markuss.broks@gmail.com> > > > > > > > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, > > > > add the compatible for it to the IST3038C bindings. > > > This one is better, but would be well served by mentioning what > > > specifically is different (register addresses or firmware commands?) > > > > I don't think anyone knows this other than Imagis itself. I would guess it's > > different hardware, since register addresses are indeed different, but on > > the other hand, there is a possibility that firmware on the MCU could be > > responding to those commands. I suppose "... IST3038B is a hardware variant > > of ... IST3038" would be more correct. > > Only Imagis might know the specifics, but you (plural) have made driver > changes so you know what is different in terms of the programming model. > I'm just asking for you to mention how the programming model varies in > the commit message. Otherwise I can't know whether you should have added > a fallback compatible, without going and reading your driver change. The > commit message for the bindings should stand on its own merit in that > regard. > "Variant" alone does not suffice, as many variants of devices have a > compatible programming model, be that for a subset of features or > complete compatibility. > > > The reason why I think it could be firmware-defined is because we have a lot > > of variants (30xxA, 30xxB, 30xxC, plain 30xx), and the numbers usually mean > > feature level/completeness, e.g. some don't support the touch pressure or > > touchkeys, and we don't know what A/B/C/none means. > > Ultimately whether it is due to firmware or the hardware isn't > particular important, just mention what is incompatibly different. I propose to update the commit description as such: Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC differing from IST3038C in its register interface. Add the compatible for it to the IST3038C bindings. > > Cheers, > Conor. > > > > > > Signed-off-by: Markuss Broks <markuss.broks@gmail.com> > > > > Signed-off-by: Karel Balej <balejk@matfyz.cz> > > > > --- > > > > .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > > > index 0d6b033fd5fb..b5372c4eae56 100644 > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > > > @@ -18,6 +18,7 @@ properties: > > > > compatible: > > > > enum: > > > > + - imagis,ist3038b > > > > - imagis,ist3038c > > > > reg: > > > > -- > > > > 2.43.0 > > > > > > - Markuss Kind regards, K. B.
On Sat, Dec 09, 2023 at 10:05:27AM +0100, Karel Balej wrote: > On Mon Dec 4, 2023 at 1:52 PM CET, Conor Dooley wrote: > > On Mon, Dec 04, 2023 at 02:40:44PM +0200, Markuss Broks wrote: > > > On 12/3/23 13:20, Conor Dooley wrote: > > > > On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote: > > > > > From: Markuss Broks <markuss.broks@gmail.com> > > > > > > > > > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, > > > > > add the compatible for it to the IST3038C bindings. > > > > This one is better, but would be well served by mentioning what > > > > specifically is different (register addresses or firmware commands?) > > > > > > I don't think anyone knows this other than Imagis itself. I would guess it's > > > different hardware, since register addresses are indeed different, but on > > > the other hand, there is a possibility that firmware on the MCU could be > > > responding to those commands. I suppose "... IST3038B is a hardware variant > > > of ... IST3038" would be more correct. > > > > Only Imagis might know the specifics, but you (plural) have made driver > > changes so you know what is different in terms of the programming model. > > I'm just asking for you to mention how the programming model varies in > > the commit message. Otherwise I can't know whether you should have added > > a fallback compatible, without going and reading your driver change. The > > commit message for the bindings should stand on its own merit in that > > regard. > > "Variant" alone does not suffice, as many variants of devices have a > > compatible programming model, be that for a subset of features or > > complete compatibility. > > > > > The reason why I think it could be firmware-defined is because we have a lot > > > of variants (30xxA, 30xxB, 30xxC, plain 30xx), and the numbers usually mean > > > feature level/completeness, e.g. some don't support the touch pressure or > > > touchkeys, and we don't know what A/B/C/none means. > > > > Ultimately whether it is due to firmware or the hardware isn't > > particular important, just mention what is incompatibly different. > > I propose to update the commit description as such: > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC > differing from IST3038C in its register interface. Add the > compatible for it to the IST3038C bindings. SGTM. You can add Acked-by: Conor Dooley <conor.dooley@microchip.com> with that commit message update. Thanks, Conor.
Markuss, On Sat Dec 9, 2023 at 11:58 AM CET, Conor Dooley wrote: > On Sat, Dec 09, 2023 at 10:05:27AM +0100, Karel Balej wrote: > > On Mon Dec 4, 2023 at 1:52 PM CET, Conor Dooley wrote: > > > On Mon, Dec 04, 2023 at 02:40:44PM +0200, Markuss Broks wrote: > > > > On 12/3/23 13:20, Conor Dooley wrote: > > > > > On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote: > > > > > > From: Markuss Broks <markuss.broks@gmail.com> > > > > > > > > > > > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, > > > > > > add the compatible for it to the IST3038C bindings. > > > > > This one is better, but would be well served by mentioning what > > > > > specifically is different (register addresses or firmware commands?) > > > > > > > > I don't think anyone knows this other than Imagis itself. I would guess it's > > > > different hardware, since register addresses are indeed different, but on > > > > the other hand, there is a possibility that firmware on the MCU could be > > > > responding to those commands. I suppose "... IST3038B is a hardware variant > > > > of ... IST3038" would be more correct. > > > > > > Only Imagis might know the specifics, but you (plural) have made driver > > > changes so you know what is different in terms of the programming model. > > > I'm just asking for you to mention how the programming model varies in > > > the commit message. Otherwise I can't know whether you should have added > > > a fallback compatible, without going and reading your driver change. The > > > commit message for the bindings should stand on its own merit in that > > > regard. > > > "Variant" alone does not suffice, as many variants of devices have a > > > compatible programming model, be that for a subset of features or > > > complete compatibility. > > > > > > > The reason why I think it could be firmware-defined is because we have a lot > > > > of variants (30xxA, 30xxB, 30xxC, plain 30xx), and the numbers usually mean > > > > feature level/completeness, e.g. some don't support the touch pressure or > > > > touchkeys, and we don't know what A/B/C/none means. > > > > > > Ultimately whether it is due to firmware or the hardware isn't > > > particular important, just mention what is incompatibly different. > > > > I propose to update the commit description as such: > > > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC > > differing from IST3038C in its register interface. Add the > > compatible for it to the IST3038C bindings. is this change OK with you? > > > SGTM. You can add > Acked-by: Conor Dooley <conor.dooley@microchip.com> > with that commit message update. > > Thanks, > Conor. Kind regards, K. B.
diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml index 0d6b033fd5fb..b5372c4eae56 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml @@ -18,6 +18,7 @@ properties: compatible: enum: + - imagis,ist3038b - imagis,ist3038c reg: