mbox series

[GIT,PULL] firewire fixes for v6.7-rc4

Message ID 20231202080648.GA34377@workstation.local
State New
Headers
Series [GIT,PULL] firewire fixes for v6.7-rc4 |

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git tags/firewire-fixes-6.7-rc4

Message

Takashi Sakamoto Dec. 2, 2023, 8:06 a.m. UTC 
  Hi Linus,

Please take this pull request for v6.7-rc4 release. It includes a slight
change to fix scarce memory leak.

As I noted in pull request for v6.7[1], Linux FireWire subsystem still
has an issue of unexpected system reboot in AMD Ryzen machine with a
kind of PCI card. Recently I got a help of AMD developer[2] and got some
advices to investigate the mechanism of system reboot, but never catch
its tail yet... I wish to fix it within the development period for v6.8
kernel.

[1] https://lore.kernel.org/lkml/20231105144852.GA165906@workstation.local/
[2] https://lore.kernel.org/lkml/20231128052429.GA25379@workstation.local/

----------------------------------------------------------------

The following changes since commit 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab:

  Linux 6.7-rc3 (2023-11-26 19:59:33 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git tags/firewire-fixes-6.7-rc4

for you to fetch changes up to 891e0eab32a57fca4d36c5162628eb0bcb1f0edf:

  firewire: core: fix possible memory leak in create_units() (2023-11-30 09:16:35 +0900)

----------------------------------------------------------------
firewire fixes for 6.7-rc4

This pull request includes a single patch to fix long-standing issue of
memory leak at failure of device registration for fw_unit. We rarely
encounter the issue, while it should be applied to stable releases, since
it fixes inappropriate API usage.

----------------------------------------------------------------
Yang Yingliang (1):
      firewire: core: fix possible memory leak in create_units()

 drivers/firewire/core-device.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

Comments

Linux regression tracking (Thorsten Leemhuis) Dec. 2, 2023, 8:32 a.m. UTC | #1 
On 02.12.23 09:06, Takashi Sakamoto wrote:
> 
> As I noted in pull request for v6.7[1], Linux FireWire subsystem still
> has an issue of unexpected system reboot in AMD Ryzen machine with a
> kind of PCI card. Recently I got a help of AMD developer[2] and got some
> advices to investigate the mechanism of system reboot, but never catch
> its tail yet... I wish to fix it within the development period for v6.8
> kernel.
>
> 
> [1] https://lore.kernel.org/lkml/20231105144852.GA165906@workstation.local/
> [2] https://lore.kernel.org/lkml/20231128052429.GA25379@workstation.local/

Thx for your efforts on this, much appreciated. It seems more than just
one or two users are hitting this crash and a fix despite all your
tremendous efforts it not yet in sight. Hence please allow me to ask:
would it cause a significant regression for users of 6.5 and later, if
we'd temporarily revert the culprit and anything depending on it until
this is solved? Because if not I wonder if we should go down that route,
even if it's a drastic measure; but then Greg could fix this in soon in
6.6.y as well.

Ciao, Thorsten
pr-tracker-bot@kernel.org Dec. 3, 2023, 1:24 a.m. UTC | #2 
The pull request you sent on Sat, 2 Dec 2023 17:06:48 +0900:

> git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git tags/firewire-fixes-6.7-rc4

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/55abae438c3cf39f66c3e0cb922c3d915363afb5

Thank you!