Message ID | 20231201235031.475293-8-irogers@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1486827vqy; Fri, 1 Dec 2023 15:51:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhwo9yzyssA68PoS/ThasRXMSunk/j+/r0iSBetC8Uj4pSPnwR1fFmHCaMxLCZ7Xd88Ay3 X-Received: by 2002:a17:902:b087:b0:1d0:6ffd:8345 with SMTP id p7-20020a170902b08700b001d06ffd8345mr143467plr.80.1701474683900; Fri, 01 Dec 2023 15:51:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701474683; cv=none; d=google.com; s=arc-20160816; b=r07nBuEi0pvFZdPNTvtGXJwWP46q8hkSS3hnOHij7V0f5xyeglTV5zyFlEvmxowg6j Nf7iML/GT2hNZpDcfWFtSMjYkniM9aHQoSSNtFipDq/xYMHOLgpt7FBJF/rCr7Ii6tBG DXDZjXFLo6rZ/canm6K8LSwLZsyb2Fb0pPKYx2UpYl6EVKChZahF5e+XRvf4PnvwRh1E njwZJFRC55iJCsFHVuZWXSc3XWDyW84+VEiHzfJ3GXnR1qe3qA3XMz/+gli8yjBMI5OZ 15oH7AYynArU+D5UIB690e/6gzeEFZ/tYgybu2sM1IwxDrXkSmzccVwCA5Bg4JIpPxM1 86Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=9lUnGKwfnXUenrlTEoRlDOWCoPKyTMDM98VpoOLbg3Q=; fh=C7ZN3tzOUVR3J206ZGKp6+yGr+dWwfty/7cvNxfc8X0=; b=yzkTztme6iiALKOr2FzW8vXj3pPYTdbo02s6l0kk6I4OudFByY9cO6NzIS0n4Obs6+ Sd4yIFBTLHKKmtRV8JPzamVT8ylBkR07x5aPe9J7U6mz7MSLQOVeQLsx/OGElAFhBD/9 XUx2VlDqQoM6KDWHqsslPc86bDO73kFO6aDPbRz0MEYjE70iXicf9GDGmQ+J3CFcY/IF 24Z6hIiomnOlk5/rcXJ3Akod1M1XvFvCdnc3X9/xkEzUTkaSVmPfHgW+YwcF72YzwuBM f8/k4+ijlbTHXfaPCJYGXi+bwjipii8RYdWawlyHvY6ootxcz2tkVDhNA7XRM2iZggGY 0O6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=Huz+6C2N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id b1-20020a170902a9c100b001b8ba81d04dsi4023249plr.395.2023.12.01.15.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 15:51:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=Huz+6C2N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E144A81668B8; Fri, 1 Dec 2023 15:51:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441922AbjLAXvN (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Fri, 1 Dec 2023 18:51:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235336AbjLAXu6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 1 Dec 2023 18:50:58 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09EC219AB for <linux-kernel@vger.kernel.org>; Fri, 1 Dec 2023 15:50:57 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-daf6c1591d5so1422119276.1 for <linux-kernel@vger.kernel.org>; Fri, 01 Dec 2023 15:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701474657; x=1702079457; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=9lUnGKwfnXUenrlTEoRlDOWCoPKyTMDM98VpoOLbg3Q=; b=Huz+6C2NqmiG/UkpuwkCmC6sEWSHrlhxShYluejTROtV6E81hDMcxG0bfuIdqR1q3x gImPvhktLUBrkbPoFkHQQMNMMkWg4bt3KMLBaD7SVSrxTynEfJG751Ycd/cfG5RLNTmc fkaPxZB4V9VbYLEeXiH50dILKf5lH2fgaM/Ke31q5qIXZpd3DJ9QHD+4GYlUUEYB48HY fxKcWVcfocnwLiXow21P6W2hAJZHPmQJ5CsIfIyziWMsV0Vttrqjgk+x9ftQvGB6ho65 IoAjTMmjB2g37s6hXqt5w9WWvOZ9v8Nnn9k5QM87rzyjqXWC0DHbFAmxO+KR8h6q7efr SAIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701474657; x=1702079457; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9lUnGKwfnXUenrlTEoRlDOWCoPKyTMDM98VpoOLbg3Q=; b=vw7ayolxQQr48da6kbIqyN6eFzKJFbwT1DEKThu+5jizcrvhQ4OPUefDnFlj0xSyZZ 4vtUqJ98Yr6gaNJcSujvaVodVTi4WJMa+85CumopV+Vq2EPw2euXt9UtYup0bwyx5HYa 7NmzlAkdrJBtwayAy77du2j+q08g6abE6taWd8J4nD3FgxhYghW5oxMmcu66324lBN5V qNu6DQQQEZMz2jjtaspUYXxmqciJq/l0SN1DLVsTT2bnsrrJ8T2L6pQ8TMGCi/1Feh7w gn3tSnFHYM0vROlvsfDi8HY1LVcjLCITV+244/YA92z1Oca9qg38EDtyLqlWYhDE23Rt pdAA== X-Gm-Message-State: AOJu0YytyucjDnMrzhF4soVUIcNxPoLjj201EbYMYORceoaZgj6yQ+gq oSMhhS471DGpYHlxIoQ1yJIliVORuNV0 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:df3:224b:7b7f:efc5]) (user=irogers job=sendgmr) by 2002:a25:74c9:0:b0:db5:3b4b:ad1e with SMTP id p192-20020a2574c9000000b00db53b4bad1emr240617ybc.10.1701474656852; Fri, 01 Dec 2023 15:50:56 -0800 (PST) Date: Fri, 1 Dec 2023 15:50:30 -0800 In-Reply-To: <20231201235031.475293-1-irogers@google.com> Message-Id: <20231201235031.475293-8-irogers@google.com> Mime-Version: 1.0 References: <20231201235031.475293-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Subject: [PATCH v1 8/9] perf srcline: Add missed addr2line closes From: Ian Rogers <irogers@google.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, Ravi Bangoria <ravi.bangoria@amd.com>, James Clark <james.clark@arm.com>, Kan Liang <kan.liang@linux.intel.com>, John Garry <john.g.garry@oracle.com>, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 15:51:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784125517877972993 X-GMAIL-MSGID: 1784125517877972993 |
Series |
[v1,1/9] perf thread_map: Skip exited threads when scanning /proc
|
|
Commit Message
Ian Rogers
Dec. 1, 2023, 11:50 p.m. UTC
The child_process for addr2line sets in and out to -1 so that pipes
get created. It is the caller's responsibility to close the pipes,
finish_command doesn't do it. Add the missed closes.
Fixes: b3801e791231 ("perf srcline: Simplify addr2line subprocess")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/srcline.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c index 034b496df297..7addc34afcf5 100644 --- a/tools/perf/util/srcline.c +++ b/tools/perf/util/srcline.c @@ -399,6 +399,8 @@ static void addr2line_subprocess_cleanup(struct child_process *a2l) kill(a2l->pid, SIGKILL); finish_command(a2l); /* ignore result, we don't care */ a2l->pid = -1; + close(a2l->in); + close(a2l->out); } free(a2l);