From patchwork Fri Dec 1 23:50:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 172690 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1486897vqy; Fri, 1 Dec 2023 15:51:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEvD+ii0vIZbqFGE80HS4IpgrOaDcYioJ3NFedF8UOhu3V5ivc5Bc7abomMKV3b3//HeBwL X-Received: by 2002:a05:6830:18f6:b0:6d3:19bf:2d16 with SMTP id d22-20020a05683018f600b006d319bf2d16mr343575otf.12.1701474692685; Fri, 01 Dec 2023 15:51:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701474692; cv=none; d=google.com; s=arc-20160816; b=VZYXlG/fltormua1FHVX1M6q2gRdqZcQ09PtraIl4nZ67XCcd+etBgEdrTdhB+qeDv U5hQnpnMthqNzoj2up+2rnL+6rqyar47LVRa0NPIQGYh2VWqhV+HE7yfkvCA8vm8fbcT 96XQd5MDRV3W6JVtFBurJmkhkHEbjJX7N9tgjA2nnnY2dPB9cY8U3ZjL2LrzIbv7QL8W 7IqtShnaKL/ogV/qqZDo7+ouKOaIwgJkWt5Fh3Lq4rkyBWnrWaczZdie3iRLGj4qiR4z ilTjKVxLg+X4JuWYNWL5pZS3+nFRP4jZN6OUSS0SeopfU1m6TcOoPrasTMfGpvntZlP0 snpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=uS8pGWtETXg2WFdrfgf4aQEd7sN6fnFiI3KEJAmFcnQ=; fh=C7ZN3tzOUVR3J206ZGKp6+yGr+dWwfty/7cvNxfc8X0=; b=li6bGU8J+PK3ERCc+hHWPCWv3xqzWTMDlO25Sn3dfr0Mh8w/XxReaBHmLl37CHf846 Wg8dSCEtW/nWe5YhhknIkgrPWKPZDj0VixASet5KUUG5E23vuruMA7ODfMHHUplSpyHE 1+JtTWV2igGYsVLdr+P5DMPClUZPFcl9NExtpg6vMbFEPSkRB9IN1NQmtJ8fFquB/CpT WXuwBGAdIPxxMsXiOEqlodwaFjdyzwuoZEs8CNl2dTnf8/9Y6nwwC7lmcEE1rP1Qgkht PzttRgQWuylXFtVLZ3kd9Je9TqI4I/D2XFHOnvaufwQTOR+xSk/ActNgHh5RL6D/wc8i 788w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=Qwxdpe+O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id s21-20020a63d055000000b00578d3f8d4d4si3941688pgi.448.2023.12.01.15.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 15:51:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=Qwxdpe+O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 94E988271DE1; Fri, 1 Dec 2023 15:51:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235274AbjLAXut (ORCPT + 99 others); Fri, 1 Dec 2023 18:50:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230313AbjLAXul (ORCPT ); Fri, 1 Dec 2023 18:50:41 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A832A10E4 for ; Fri, 1 Dec 2023 15:50:47 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-db548aff7baso1765093276.2 for ; Fri, 01 Dec 2023 15:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701474647; x=1702079447; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=uS8pGWtETXg2WFdrfgf4aQEd7sN6fnFiI3KEJAmFcnQ=; b=Qwxdpe+OvR2aKj5F5/OWkSDLPN8gkV3TD4oWKi/FRVcHKy59OFHkqYG/Qtu3PNpyhj 3K5OzbRqz1Tu36EYtMdFSF4iVKTnrHflQOyLqvDKx8IdRWJb2UX4yJyu+7pGoIsnjbkn ax9NxqoP6R9RsCgY+RwmeCH8AWTXuJRLR2/wKldqYKsmrPJfEo6MK9CT1sXD2wtSuR7J 1Pt5vzWuWP/Y7yoVXWs8FzyzcD4hU1atr6DesP2w3n66qreGosBo8GFymYoxYuccLIXk MgkHDciLgE9pyEvKCnlyG/j3yOkKt+gp7qq4zTg+5qxvciEbTN6eUYgNTkarONbOPtYn 8wjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701474647; x=1702079447; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uS8pGWtETXg2WFdrfgf4aQEd7sN6fnFiI3KEJAmFcnQ=; b=dNueBr3ia1zTQKQKCKFTXsQZffiYkjuGWyaNHyn4C5l1rf5U2UYahYkItuNadR9RQx UXCna0W7kVepLXKml8cne7NeFj5N14YcpQ3XhFwmtdueCPCXTT+9+XpK/Jf5TegqdgHW UnMsfO+kThNfQNQxlNTnVJLVCSrhV/S6KZX/GjrYTpsFPGq6jQUJvphLm7+JhGYMYQ1u QOCoypmW0lgfQxivbJCq2iiXNnHe2VlbGjxhT10cSQCVDNUsOjA56vijTM3Xx9Z0kEgZ kPiJFvhkyQrhaLo44gj1QHbLDepkiUxD77eRNp8kzxB4gANaS0kcMjsJWwnSZmTw6Zb/ 3OJQ== X-Gm-Message-State: AOJu0Yy9hUmjOSrMDVJJRNgOfJuethzpdpgoUIuYnLWikzWptfWV34fj m7LjPR4QXBzK2hTFvQRO8W+yuJWxRMX5 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:df3:224b:7b7f:efc5]) (user=irogers job=sendgmr) by 2002:a25:ddc1:0:b0:db5:347d:44b with SMTP id u184-20020a25ddc1000000b00db5347d044bmr257636ybg.11.1701474646915; Fri, 01 Dec 2023 15:50:46 -0800 (PST) Date: Fri, 1 Dec 2023 15:50:26 -0800 In-Reply-To: <20231201235031.475293-1-irogers@google.com> Message-Id: <20231201235031.475293-4-irogers@google.com> Mime-Version: 1.0 References: <20231201235031.475293-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Subject: [PATCH v1 4/9] tools subcmd: Add a no exec function call option From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ravi Bangoria , James Clark , Kan Liang , John Garry , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 01 Dec 2023 15:51:12 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784125527794129035 X-GMAIL-MSGID: 1784125527794129035 Tools like perf fork tests in case they crash, but they don't want to exec a full binary. Add an option to call a function rather than do an exec. The child process exits with the result of the function call and is passed the struct of the run_command, things like container_of can then allow the child process function to determine additional arguments. Signed-off-by: Ian Rogers --- tools/lib/subcmd/run-command.c | 2 ++ tools/lib/subcmd/run-command.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tools/lib/subcmd/run-command.c b/tools/lib/subcmd/run-command.c index 5cdac2162532..d435eb42354b 100644 --- a/tools/lib/subcmd/run-command.c +++ b/tools/lib/subcmd/run-command.c @@ -122,6 +122,8 @@ int start_command(struct child_process *cmd) } if (cmd->preexec_cb) cmd->preexec_cb(); + if (cmd->no_exec_cmd) + exit(cmd->no_exec_cmd(cmd)); if (cmd->exec_cmd) { execv_cmd(cmd->argv); } else { diff --git a/tools/lib/subcmd/run-command.h b/tools/lib/subcmd/run-command.h index 17d969c6add3..d794138a797f 100644 --- a/tools/lib/subcmd/run-command.h +++ b/tools/lib/subcmd/run-command.h @@ -47,6 +47,8 @@ struct child_process { unsigned exec_cmd:1; /* if this is to be external sub-command */ unsigned stdout_to_stderr:1; void (*preexec_cb)(void); + /* If set, call function in child rather than doing an exec. */ + int (*no_exec_cmd)(struct child_process *process); }; int start_command(struct child_process *);