From patchwork Fri Dec 1 18:13:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Knecht X-Patchwork-Id: 172617 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1321198vqy; Fri, 1 Dec 2023 10:14:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFpvPbxyuIn9H61UZNZoNibEr7VoYfdQrzr29X15fw9F7XDn/IW/Hq7JZCvr18bBWsKHomJ X-Received: by 2002:a17:90a:f48c:b0:285:490d:10cd with SMTP id bx12-20020a17090af48c00b00285490d10cdmr40157309pjb.3.1701454488798; Fri, 01 Dec 2023 10:14:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701454488; cv=none; d=google.com; s=arc-20160816; b=jyYdRgyFeB3eIH7QDKD0j66zezU1YzLvA87WQi7cLJlJ0j99FaBqhXS+Hl7f4NR+yv 2AJbuSV+zo9uubbvVNg3B1qXWcJ+jzJUntvWDtW1KnmBC8IYyzdnpz4iCfBepND4RbtV si1VzMOBVJTrHGh9zYUYSlZ40a7/eKC4i/XKVvOg4wgsLIDqRGbJEaSiiGq7DuvNzs4U 3/pSBGcCKTC79hEIYgCv6SGSYhBDDMpJIGOaHrrmso7aGvUYio2rXjYFeDHKYs8PyN/I SyZPxyneMFn3vkVTm+Gtd6gnT4+iuIoR2lf/MnBTzUMoErTsIiNZ7HpD+05XOfuTF5n4 33Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uAkKAESQs5jnE70rUQhjNeaKmjUqRWEj8dpJUKQErKE=; fh=MLPIpDvSgLSH2RGMkeMywVQ9Tq8l5iBh5cHKbDQAJCA=; b=JKmkD1woIL7zqsK7eLJEsMhdzaC3zqdZwIHiX1CHlYuI/04TKtOiHhI83YnZoHabPk yhjnl1VXF3gMlm/BrzE7YY/eEo9x7GRp2ysjdbsxJX+1L5aRdlBoJTTibhZBIx7OamIn ileQuMF4ETDTsEej9IjLjPssnDA6FQvL5nMF6dp8p2lj+POPywyZlzk5r8RcXOBglCsg RJDe805pjIv5IGZJSziHRkxc/eiHAaq0M+VE420DxsYET1DY3XvI6gqxEJCvA2VXvkaK S7DLW/d+5NZ/cCLqTw02qNhTcVu9Qnhm2KSrjbrgI9q3ns2pnIxVj/hmgHRyE1R0mpQS DMmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailoo.org header.s=mailo header.b=BlRJe1Xo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailoo.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ot13-20020a17090b3b4d00b002839e1cb23csi6467323pjb.117.2023.12.01.10.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 10:14:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=fail header.i=@mailoo.org header.s=mailo header.b=BlRJe1Xo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailoo.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id DDFBC8116E75; Fri, 1 Dec 2023 10:14:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbjLASOe (ORCPT + 99 others); Fri, 1 Dec 2023 13:14:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjLASOd (ORCPT ); Fri, 1 Dec 2023 13:14:33 -0500 Received: from mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3F3A10D; Fri, 1 Dec 2023 10:14:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1701454446; bh=8ItrQJpfnYJNBvx9/ZxfYVCB4X1PSHGmZpReeVMVCbM=; h=X-EA-Auth:From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding; b=BlRJe1XoLRRfLfBlqX9FKJXDcczc9GjGwiHexrrf2wJDGyH4QwQYFcMP2gml325Ew x7N8QzhHSsMKY7CiqKsYPa6vBzklsiX/NIoj3ILcNFVOLU8i9gQdnDCOwfhj/oiF8Q B3zFDEDOCYN62u80TcrXeY4f3rb7yGbgSSfNzuis= Received: by b221-6.in.mailobj.net [192.168.90.26] with ESMTP via ip-22.mailoo.org [213.182.54.22] Fri, 1 Dec 2023 19:14:05 +0100 (CET) X-EA-Auth: ym1ciIqVgZ9eNjymoAMtLEFtuPM6bDp74qWVWVEHmy5LVtFvlqvwNHZnHGLyOdmKhJr18Ui7S9JftJCkKqCam+ZcJB/sbMs1XtBetbwXJJ0= From: Vincent Knecht To: Tianshu Qiu , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , Yassine Oudjana , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Vincent Knecht Subject: [PATCH v2 3/3] media: i2c: ak7375: Add support for ak7345 Date: Fri, 1 Dec 2023 19:13:50 +0100 Message-ID: <20231201181350.26454-3-vincent.knecht@mailoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231201181350.26454-1-vincent.knecht@mailoo.org> References: <20231201181350.26454-1-vincent.knecht@mailoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 01 Dec 2023 10:14:44 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784104342200580480 X-GMAIL-MSGID: 1784104342200580480 Add support for ak7345 VCM, which has 9 bits position values, longer power-up delay, and no known standby register setting. Might be compatible as-is with ak7348. Tested on msm8916-alcatel-idol347 phone. Signed-off-by: Vincent Knecht --- v2: no change --- drivers/media/i2c/ak7375.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ak7375.c b/drivers/media/i2c/ak7375.c index 3a14eff41531..9a2432cea3ff 100644 --- a/drivers/media/i2c/ak7375.c +++ b/drivers/media/i2c/ak7375.c @@ -16,6 +16,7 @@ struct ak73xx_chipdef { u8 shift_pos; u8 mode_active; u8 mode_standby; + bool has_standby; /* Some chips may not have standby mode */ u16 focus_pos_max; /* * This sets the minimum granularity for the focus positions. @@ -37,12 +38,26 @@ struct ak73xx_chipdef { u16 power_delay_us; }; +static const struct ak73xx_chipdef ak7345_cdef = { + .reg_position = 0x0, + .reg_cont = 0x2, + .shift_pos = 7, /* 9 bits position values, need to << 7 */ + .mode_active = 0x0, + .has_standby = false, + .focus_pos_max = 511, + .focus_steps = 1, + .ctrl_steps = 16, + .ctrl_delay_us = 1000, + .power_delay_us = 20000, +}; + static const struct ak73xx_chipdef ak7375_cdef = { .reg_position = 0x0, .reg_cont = 0x2, .shift_pos = 4, /* 12 bits position values, need to << 4 */ .mode_active = 0x0, .mode_standby = 0x40, + .has_standby = true, .focus_pos_max = 4095, .focus_steps = 1, .ctrl_steps = 64, @@ -249,10 +264,12 @@ static int __maybe_unused ak7375_vcm_suspend(struct device *dev) usleep_range(cdef->ctrl_delay_us, cdef->ctrl_delay_us + 10); } - ret = ak7375_i2c_write(ak7375_dev, cdef->reg_cont, - cdef->mode_standby, 1); - if (ret) - dev_err(dev, "%s I2C failure: %d\n", __func__, ret); + if (cdef->has_standby) { + ret = ak7375_i2c_write(ak7375_dev, cdef->reg_cont, + cdef->mode_standby, 1); + if (ret) + dev_err(dev, "%s I2C failure: %d\n", __func__, ret); + } ret = regulator_bulk_disable(ARRAY_SIZE(ak7375_supply_names), ak7375_dev->supplies); @@ -312,6 +329,7 @@ static int __maybe_unused ak7375_vcm_resume(struct device *dev) } static const struct of_device_id ak7375_of_table[] = { + { .compatible = "asahi-kasei,ak7345", .data = &ak7345_cdef, }, { .compatible = "asahi-kasei,ak7375", .data = &ak7375_cdef, }, { /* sentinel */ } };