From patchwork Fri Dec 1 17:21:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos Llamas X-Patchwork-Id: 172589 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1286458vqy; Fri, 1 Dec 2023 09:23:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGirFK8tGfoaO7KWG5nY8njLjUemnKrVpDNm8UjOZYUCGi89ESzLT5JVnr5u+zJLgf/DFdr X-Received: by 2002:a05:6358:e48b:b0:16b:f704:15a0 with SMTP id by11-20020a056358e48b00b0016bf70415a0mr25766237rwb.8.1701451399162; Fri, 01 Dec 2023 09:23:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701451399; cv=none; d=google.com; s=arc-20160816; b=iQCdc7ENY+7OrlF0wh4CPfL4CIGTLzLXpx7gaPo7omIxLEWtBALkDGnlk65QAbU7ui EnmP0MrgB7vUL/DJiN73fapNCK2k+fW65nHmeh/bqjja4FgHYXmYw54ajg7ArzJL8uv7 yvJFF802Q/MKV3vsclGqkFK3KGIcOCgGSq9Jy9IeNLSiVtXlZveWEFicw6Vecf5h3stI n18nu4XEroLhJXF6DHGsP775ubDXJexwDT23ZWXHeKFI+oKggPc7nr/E23ib99hwJIsY Rg5X69577NsZKUnBpdAH50j73X+iJzcf0ODiemmHOYboG++KrS/qkbdkL9h80DoY/+3P 0WLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=i8lzNNyGh9YxFrbdbNM0dDCNT8qnC2FAkz/L9borbvI=; fh=5258fcz8bthyOwst3mm0arZN8X7W1esAOgUg8PP1tIk=; b=OHRpmShPHv0TN1gGVyNOp9VRpF8A15n2JShPDEIUKwe461wYPZ38gxrric8ra4haiN Ru32ftwNHPqTlKpX6OR0ff3wcpahZFBSx2EiVwNWWNjmHBfn6/eLx+6I5LnWarsvuxRS +/Odq6oOYpSAuSGr+eiirDKjr4oWcdU+Sg18CfyJW7lDIhRILtfjMsVJ7iIBVkKcyBqu zQV40+z/SUFYohqY4L+Cp9mosScyHOE9Cz6hp74OWQecOPh2oT5idaQITvUD2RgEj/rT VvrX4akvbnMPSe3IDfEBPw7UF83o42aQcaWpVRi22TyQ8Ki86+fPLBAUYI1TC5koBqry ZOcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=DPujzvQX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id be14-20020a656e4e000000b005be1b2503ebsi4018366pgb.194.2023.12.01.09.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:23:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=DPujzvQX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D329681A2069; Fri, 1 Dec 2023 09:23:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378871AbjLARXF (ORCPT + 99 others); Fri, 1 Dec 2023 12:23:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378938AbjLARWw (ORCPT ); Fri, 1 Dec 2023 12:22:52 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE5A610FC for ; Fri, 1 Dec 2023 09:22:49 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-db4038d7cfdso990208276.2 for ; Fri, 01 Dec 2023 09:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701451369; x=1702056169; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=i8lzNNyGh9YxFrbdbNM0dDCNT8qnC2FAkz/L9borbvI=; b=DPujzvQX/ijuvdElTrA+p6r+aHAN3CRTOq14R2EmCz6skT8/TO2GM61SIKl1qeXp0n fZ+Pr+0z6gznhqPFzbLfO3bTNj3zpwqWuNnbhpot4Zx9rOtr6YPGSzWO9pzuzadOARX4 re7TI5zrcG4CGCpmHyNLCOJMRuXQXpPFqOh6MIXUZecKgXgZ9/3NmHHvt5rBUAVEIdzN b6q6wKVD7UwiSDrsCt9TdgAyXDW0ml9LncrmJSrtgUTZdEPk6AREk9ex1FLh98lOxg/V NnwLVqVLzSDFrHWNokgl8dWnxFqNYrmBTHKU3GsEppIEvIf/6yHOa/tx/fRJkBaIsK67 9/fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701451369; x=1702056169; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i8lzNNyGh9YxFrbdbNM0dDCNT8qnC2FAkz/L9borbvI=; b=YBoQeZe9oI0BUzkJsan56vfCjlNH7ynAVJTsHoeVP1DpPd3MFVxlxHvQlbYMyvvv80 cZH/5cPSKZ75kISWMbIedGlru2qUAJMBvSayQ+/nvHr9v4fdVbFQ840Grwt3Eg0nqG8e BdWXF7cm0uSpU5MjZUa50DtZj19Nh8qUNPyxyHwkP8M9TjL5G2jWb40Abq5NZaYsb6Ed Tc9vXhEjYDd30jYgd/kzX8zeIY9V1eZMJYDwnr1YhYbMsMIpIH/hjBWpfIH2JusTR5Ck D5Vyn7wQKv6HTQrUryGcpOEngotI/DhnVxwviMzEroRoo1d32En/2AYOZyMuCOTrKLUx mduQ== X-Gm-Message-State: AOJu0Yw5Un3LJTG9M4qqJekechpR2atvJHWM84B21KsSYeTFXNLG9GMs XZ0hKajGFSLGaB4hqT21tNn72SvhlkAZrQ== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a25:d6c8:0:b0:db5:452a:8e4f with SMTP id n191-20020a25d6c8000000b00db5452a8e4fmr171087ybg.4.1701451368959; Fri, 01 Dec 2023 09:22:48 -0800 (PST) Date: Fri, 1 Dec 2023 17:21:36 +0000 In-Reply-To: <20231201172212.1813387-1-cmllamas@google.com> Mime-Version: 1.0 References: <20231201172212.1813387-1-cmllamas@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <20231201172212.1813387-8-cmllamas@google.com> Subject: [PATCH v2 07/28] binder: fix comment on binder_alloc_new_buf() return value From: Carlos Llamas To: Greg Kroah-Hartman , " =?utf-8?q?Arve_Hj?= =?utf-8?q?=C3=B8nnev=C3=A5g?= " , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org, Alice Ryhl X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 01 Dec 2023 09:23:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784101101873344179 X-GMAIL-MSGID: 1784101101873344179 Update the comments of binder_alloc_new_buf() to reflect that the return value of the function is now ERR_PTR(-errno) on failure. No functional changes in this patch. Cc: stable@vger.kernel.org Fixes: 57ada2fb2250 ("binder: add log information for binder transaction failures") Reviewed-by: Alice Ryhl Signed-off-by: Carlos Llamas --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c index a124d2743c69..a56cbfd9ba44 100644 --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -556,7 +556,7 @@ static struct binder_buffer *binder_alloc_new_buf_locked( * is the sum of the three given sizes (each rounded up to * pointer-sized boundary) * - * Return: The allocated buffer or %NULL if error + * Return: The allocated buffer or %ERR_PTR(-errno) if error */ struct binder_buffer *binder_alloc_new_buf(struct binder_alloc *alloc, size_t data_size,