From patchwork Fri Dec 1 14:04:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 172501 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1142142vqy; Fri, 1 Dec 2023 06:05:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFpb07rloB4ip6vW7ndTiiAX/sy6EcVAsBFxmrKfj8pqHEr9r6iRfH4RuEINHHlhkpgOY3 X-Received: by 2002:a05:6a00:2190:b0:6cd:fda4:b57c with SMTP id h16-20020a056a00219000b006cdfda4b57cmr2672845pfi.15.1701439513652; Fri, 01 Dec 2023 06:05:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701439513; cv=none; d=google.com; s=arc-20160816; b=xsSShwiJFxb/QgoIvrC8m7nw91/g/tyQYqXesWoUJSCsGKGKr0Z0IufRJ60rp9GsH5 9WItvJM1P4bYx5UsO3uHxCw1bXu9GGrb+WsXWPpTn7lRZJRN7vemDvrYCCDUiSS/Dw/t DgNCT3cIh1t5V/IQ6HtGU3mTEavpOt1IFphFlrkotWOFO34tyGXic3MRYcyfQeYaALml r2FW6jd97TIZPyoAykK3RSy9QfL0Jt5UBfZCZH9ZAQHy9yN9N5fZ3TcMv1WunAeUikrI PM5pT03UpJTapLRRHN3Uf2bK/1PnhD8ua2OE9XV/lRZ9FT4qZPN+NCQJ6DaUCIN8Hlj6 OLjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=u8uzoOZqDr+Dg8oZJeDFBZYVMXOdSPyGupQb2yLgWW4=; fh=zrfhwYqK3v7+0qLNkzAy3gisHg4j69MIGE7UPruxbVs=; b=oLPXYjj8XH3KSTs9JLs60LHepIHbYuVjMl822ZC1hMkPyIUWsRHlMIzjwXN7xs907R frlp9t3S9TZC1jfxFl4CKKNCh6FOFJ2/n/4eOjtXzq8ySBERgwHycnb39BkhnYHvLdMh hcn1ULkLPhxYLWNQY/bl1c2ZXRh7bmBos3egFzxE53d+Th0cJRgy4Bj0wyLVv8G67TIU FlW+VgRkDOD5d0Wsq/WeKzSSwqU8uFPtrCoPTuOwXfZtaoVcB86mTkj6eiuTNkKh1Qwy oTXYfIBZ3oe90++eFitzDMBWqYc7plHiq7n2t6VRSvZVMjmfkq/DKdFVehaUgPVp/Ec/ CCZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=Bn5kQflY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id n185-20020a6327c2000000b005c2188ae892si3504761pgn.583.2023.12.01.06.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 06:05:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=Bn5kQflY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9D179810683B; Fri, 1 Dec 2023 06:05:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379106AbjLAOE4 (ORCPT + 99 others); Fri, 1 Dec 2023 09:04:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379060AbjLAOEy (ORCPT ); Fri, 1 Dec 2023 09:04:54 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D796094; Fri, 1 Dec 2023 06:05:00 -0800 (PST) Received: from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E3A3118A2; Fri, 1 Dec 2023 15:04:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701439462; bh=GCySINWmuCR5JodNHhNRp4B30t3rx5GHASe7kUWliPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bn5kQflYY6ZjgS3HSwJuWGk06QH7hZbvaEufHauqZ8LtlOMT0f3Ob9ErzD5scA+MX i+DjWr/Z8tjLamXiSMxFBHzBdYekA3spRIeZiAMLD2E15GempKuwoQNWg5Gmi/yQCh Nw7LbxSuHjE/MCUOV1LqL//sPyfgn8pSkDDCloVo= From: Paul Elder To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Paul Elder , Alexander Stein , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/4] media: rkisp1: debug: Add register dump for IS Date: Fri, 1 Dec 2023 23:04:31 +0900 Message-Id: <20231201140433.2126011-3-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201140433.2126011-1-paul.elder@ideasonboard.com> References: <20231201140433.2126011-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 06:05:05 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784088639524621626 X-GMAIL-MSGID: 1784088639524621626 Add register dump for the ISP image stabilizer module to debugfs. This helps debugging issues related to digital zoom. Signed-off-by: Paul Elder Tested-by: Alexander Stein Reviewed-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes in v2: - Move from IS debugfs file into the ISP debugfs file drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c index 71df3dc95e6f..d2fbed42164e 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c @@ -92,6 +92,10 @@ static int rkisp1_debug_dump_isp_regs_show(struct seq_file *m, void *p) RKISP1_DEBUG_REG(ISP_FLAGS_SHD), RKISP1_DEBUG_REG(ISP_RIS), RKISP1_DEBUG_REG(ISP_ERR), + RKISP1_DEBUG_SHD_REG(ISP_IS_H_OFFS), + RKISP1_DEBUG_SHD_REG(ISP_IS_V_OFFS), + RKISP1_DEBUG_SHD_REG(ISP_IS_H_SIZE), + RKISP1_DEBUG_SHD_REG(ISP_IS_V_SIZE), { /* Sentinel */ }, }; struct rkisp1_device *rkisp1 = m->private;