Message ID | 20231201120942.680075-1-LeoLiu-oc@zhaoxin.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1069809vqy; Fri, 1 Dec 2023 04:10:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8zmVwESfT52BFFJwp3f3AzjyfmLJyOvKqWyzRcxSoK1tjPMk/UboUTteeLw14Z0n0wcip X-Received: by 2002:a05:6a20:841e:b0:188:444e:2b74 with SMTP id c30-20020a056a20841e00b00188444e2b74mr26953266pzd.50.1701432603218; Fri, 01 Dec 2023 04:10:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701432603; cv=none; d=google.com; s=arc-20160816; b=AZGqqF4AtPNX6nK5nzVYLcCMSLCDTmJ4MEtSU8+GWoVWQKU2A2MBZFYqKTqFNkRI5v ceU57nyyAizPyCwLv3WYezOHAC/vr3wkju1CvwoWdaeQnKPqi8cA9GT5b5jCqq66pqbO 3SkxdHvjIECWiS8U3qfrz7Z9ZYX9U1ok6utq7D8qW3fv7fA5Vk3zY93wEdHGqHVZYjOU PGIu49pVVZUys0ybDP43aVqTlDWmIFNWp1q9ESvf0LmB9e+DgJvTZsOWWFvDkgJEj2Uy p1XCaxGsbHCRL30s/lOiW0cWnIsAjfxOqfV25R4MpRsQ2YTwr19CFm9aqjDHRZLDh5kl xqeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=TwVdEZfAByhuuLYhsIEM4gScya7vXiCGu5IUcuVk17Y=; fh=l9IBQTR3JGzmComeJ3VEfXzGuHzyK7ZINzrVU4nybbQ=; b=e+VTYTzdikxt69LwttKWRw6UmoZb+hmDwxUoE2q40yWTw4H1qzcFvstaWMreCQXl8Y YHuN5IiFFBGWPvMNLlZlQgm9H1EgEM6MyMuV4QHArzYD/7axiqJT+nMGbJtceeQX4StT HR4yCIqgmELkDRwPK1maj+E2G6XDeqeuBtGOfwsgRclyR5z5xlWhwEMREUVEBaNQMB7Y dLdOmOyBTFYXGKE6rnuvoPYz+PIwiSXvfwVt2sysIJX5Vcu/EmYPLEmpmdC/8VDmJi3a IMHOkIrt0eOFnDjweo5Gqkos5CAoaDsTI6hBeKyR2XXlh+wCH2/Kh/WZ56bfE+WeipG3 3CTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id z15-20020a63e54f000000b005c221909d4asi3214151pgj.830.2023.12.01.04.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 04:10:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 66D4580F9CBE; Fri, 1 Dec 2023 04:09:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378719AbjLAMJn (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Fri, 1 Dec 2023 07:09:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378702AbjLAMJm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 1 Dec 2023 07:09:42 -0500 Received: from mx2.zhaoxin.com (mx2.zhaoxin.com [203.110.167.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB6313E for <linux-kernel@vger.kernel.org>; Fri, 1 Dec 2023 04:09:47 -0800 (PST) X-ASG-Debug-ID: 1701432584-1eb14e538d26c50001-xx1T2L Received: from ZXSHMBX2.zhaoxin.com (ZXSHMBX2.zhaoxin.com [10.28.252.164]) by mx2.zhaoxin.com with ESMTP id ACybemeJXW88gc2e (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 01 Dec 2023 20:09:44 +0800 (CST) X-Barracuda-Envelope-From: LeoLiu-oc@zhaoxin.com X-Barracuda-RBL-Trusted-Forwarder: 10.28.252.164 Received: from ZXBJMBX03.zhaoxin.com (10.29.252.7) by ZXSHMBX2.zhaoxin.com (10.28.252.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 1 Dec 2023 20:09:44 +0800 Received: from xin.lan (10.32.64.1) by ZXBJMBX03.zhaoxin.com (10.29.252.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 1 Dec 2023 20:09:43 +0800 X-Barracuda-RBL-Trusted-Forwarder: 10.28.252.164 From: LeoLiu-oc <LeoLiu-oc@zhaoxin.com> X-Barracuda-RBL-Trusted-Forwarder: 10.29.252.7 To: <bhelgaas@google.com>, <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <CobeChen@zhaoxin.com>, <TonyWWang@zhaoxin.com>, <YeeLi@zhaoxin.com>, <Leoliu@zhaoxin.com>, leoliu-oc <leoliu-oc@zhaoxin.com> Subject: [PATCH] PCI: Extend PCI root port device IDs for Zhaoxin platforms Date: Fri, 1 Dec 2023 20:09:42 +0800 X-ASG-Orig-Subj: [PATCH] PCI: Extend PCI root port device IDs for Zhaoxin platforms Message-ID: <20231201120942.680075-1-LeoLiu-oc@zhaoxin.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.32.64.1] X-ClientProxiedBy: zxbjmbx1.zhaoxin.com (10.29.252.163) To ZXBJMBX03.zhaoxin.com (10.29.252.7) X-Barracuda-Connect: ZXSHMBX2.zhaoxin.com[10.28.252.164] X-Barracuda-Start-Time: 1701432584 X-Barracuda-Encrypted: ECDHE-RSA-AES128-GCM-SHA256 X-Barracuda-URL: https://10.28.252.36:4443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at zhaoxin.com X-Barracuda-Scan-Msg-Size: 792 X-Barracuda-BRTS-Status: 0 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.117509 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 01 Dec 2023 04:09:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784081393779213632 X-GMAIL-MSGID: 1784081393779213632 |
Series |
PCI: Extend PCI root port device IDs for Zhaoxin platforms
|
|
Commit Message
LeoLiu-oc
Dec. 1, 2023, 12:09 p.m. UTC
From: leoliu-oc <leoliu-oc@zhaoxin.com> Add more PCI root port device IDs to the pci_quirk_zhaoxin_pcie_ports_acs() for some new Zhaoxin platforms. Signed-off-by: leoliu-oc <leoliu-oc@zhaoxin.com> --- drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Dec 01, 2023 at 08:09:42PM +0800, LeoLiu-oc wrote: > From: leoliu-oc <leoliu-oc@zhaoxin.com> > > Add more PCI root port device IDs to the > pci_quirk_zhaoxin_pcie_ports_acs() for some new Zhaoxin platforms. Can you please add a note about the plan to deal with this for future devices, e.g., something like "future Zhaoxin devices now in development will advertise an ACS Capability as described in the PCIe spec"? The point of quirks is to work around hardware that is broken or doesn't conform to the spec in some way. We have to add quirks when broken hardware is already in the field, but we should have a plan to fix newer devices so they don't require quirks. > Signed-off-by: leoliu-oc <leoliu-oc@zhaoxin.com> > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index ea476252280a..db74f8f07096 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -4709,7 +4709,7 @@ static int pci_quirk_zhaoxin_pcie_ports_acs(struct pci_dev *dev, u16 acs_flags) > switch (dev->device) { > case 0x0710 ... 0x071e: > case 0x0721: > - case 0x0723 ... 0x0732: > + case 0x0723 ... 0x073b: > return pci_acs_ctrl_enabled(acs_flags, > PCI_ACS_SV | PCI_ACS_RR | PCI_ACS_CR | PCI_ACS_UF); > } > -- > 2.34.1 >
在 2023/12/1 23:53, Bjorn Helgaas 写道: > On Fri, Dec 01, 2023 at 08:09:42PM +0800, LeoLiu-oc wrote: >> From: leoliu-oc <leoliu-oc@zhaoxin.com> >> >> Add more PCI root port device IDs to the >> pci_quirk_zhaoxin_pcie_ports_acs() for some new Zhaoxin platforms. > > Can you please add a note about the plan to deal with this for future > devices, e.g., something like "future Zhaoxin devices now in > development will advertise an ACS Capability as described in the > PCIe spec"? > > The point of quirks is to work around hardware that is broken or > doesn't conform to the spec in some way. We have to add quirks when > broken hardware is already in the field, but we should have a plan to > fix newer devices so they don't require quirks. > Okay, note will be added in the next version. Sincerely, Leoliu-oc >> Signed-off-by: leoliu-oc <leoliu-oc@zhaoxin.com> >> --- >> drivers/pci/quirks.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c >> index ea476252280a..db74f8f07096 100644 >> --- a/drivers/pci/quirks.c >> +++ b/drivers/pci/quirks.c >> @@ -4709,7 +4709,7 @@ static int pci_quirk_zhaoxin_pcie_ports_acs(struct pci_dev *dev, u16 acs_flags) >> switch (dev->device) { >> case 0x0710 ... 0x071e: >> case 0x0721: >> - case 0x0723 ... 0x0732: >> + case 0x0723 ... 0x073b: >> return pci_acs_ctrl_enabled(acs_flags, >> PCI_ACS_SV | PCI_ACS_RR | PCI_ACS_CR | PCI_ACS_UF); >> } >> -- >> 2.34.1 >>
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index ea476252280a..db74f8f07096 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4709,7 +4709,7 @@ static int pci_quirk_zhaoxin_pcie_ports_acs(struct pci_dev *dev, u16 acs_flags) switch (dev->device) { case 0x0710 ... 0x071e: case 0x0721: - case 0x0723 ... 0x0732: + case 0x0723 ... 0x073b: return pci_acs_ctrl_enabled(acs_flags, PCI_ACS_SV | PCI_ACS_RR | PCI_ACS_CR | PCI_ACS_UF); }