Message ID | 20231201102747.3854573-1-treapking@chromium.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1018083vqy; Fri, 1 Dec 2023 02:27:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIMoJazuo6VOsN0J9oL5XByYWulOp0CvWy0c+knko/JBUge3K15CQp34OLswNIeG0AR8Tk X-Received: by 2002:a05:6a00:3a04:b0:6cb:ccea:e2fd with SMTP id fj4-20020a056a003a0400b006cbcceae2fdmr27285934pfb.5.1701426478507; Fri, 01 Dec 2023 02:27:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701426478; cv=none; d=google.com; s=arc-20160816; b=FXLk1jtPGVKef6Fuy7tkmfKdLwZQVD1lvTbabYfwQo3BKjMWAOurcID5jbrNFFf1ud es4gm913TakDV0Pt7Rkpa63YtCv4zuepgnqbIrg9AUqgeCpar57EVDKyaV0VQn22tipk AEHKHs8zYS0I9j0Jk5BOSSB8am57VQajnGmLpXYoKufP/PNuBbI5fzMEBj3COu+EXkaE /G0nWDqFfgkaiu5+Uu5AWHy4aMboLnCHlgiz9T3yCHdobpr8fzcgcoH/kGqMJkcMq/Ww LVtcpkE64u4bdTXeKJH03m26pO5wtaSk8LCcBedyb9jmNYYDeMMDT+qlm+2eWWaGMccf Ilpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2RC9FzC7iwPwgtlDLuitx0S/ZDsUva1kaWzL6Ox9kqE=; fh=2LhNxQZQNNp6OyiMxZt7vOYfJxkTWSLoRkqjUTNGlVg=; b=kik3Yud2YevcWSyBsn7VpUSflpCrHZeBvRuvEHy3N3j4X0oJ6SlsAfdMSb+onElXvT m6guYe96ZwukwRZSEzLh3FPHcWq0OvAme+NPCexBwQUMcxtKuU90tGew7PnA12iiyV88 QlvD2YVtHFRn7EOSpXtE8dJzzQKBRkMtgxptIOqxwesEl0xh61f9Fxk+YI/amdhL4doH bbAhm2QNT7tgVlXd2YkpltrM2Cs+DdB3sV8wt45k2GggNxsrsRvi6d/4bdTSmVWEpAzF MixhNu4CjUUL9VGBF3QFVFFARY/j7sf6GT3dQInhXo/9/67733yUIfOSl67gn9ODM18z MHDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZE3XClYr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id v25-20020a631519000000b005c625af78acsi3004995pgl.881.2023.12.01.02.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 02:27:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZE3XClYr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3FD4180FDDD8; Fri, 1 Dec 2023 02:27:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378265AbjLAK1s (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Fri, 1 Dec 2023 05:27:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378226AbjLAK1r (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 1 Dec 2023 05:27:47 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11E3EDE for <linux-kernel@vger.kernel.org>; Fri, 1 Dec 2023 02:27:54 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1d048d38881so3087215ad.2 for <linux-kernel@vger.kernel.org>; Fri, 01 Dec 2023 02:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701426473; x=1702031273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2RC9FzC7iwPwgtlDLuitx0S/ZDsUva1kaWzL6Ox9kqE=; b=ZE3XClYr4BVJiR8xQqnDgwK7N4dvewF74tM1Qr5e7+gqyhl19uzeEzj+88vKyD2EPe DegYpYafj7x/hWERI6vcHSsJoe0DGFvPtWUe61C4ztIe/Go3Qn/2YLs8WObS/CvLR7KV TJEFP6neF8m1eID2zUZ9Eu6LVJfXma/LhRP+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701426473; x=1702031273; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2RC9FzC7iwPwgtlDLuitx0S/ZDsUva1kaWzL6Ox9kqE=; b=LvIGZh3PF2ctjsbZrMtPtdJifGVqNQcfVJ/sykOfT8tEx2KmbdRSrzAVvtulURiYVG CDhSFpsNvKPPd+qoFB1g9k+t4JEbgTCF7uiOPyrvekEZcLAbQS3mz5HuJ44kLsG9jxth Xgr7OrNu9dymxu6wjcB+xgagOzXrWO2jfMWs/EShAMSvQ1rYQDBsQlmLj2wB1Ai9+k/7 oi39WQLoL5b8A8P7DJghghT52j9lnio1srNhXleu3nIIMoZa+DjJ/SyT8FY89ZbVliHa HUheiuno7j+v10vIeAJTOw53vKKV17evrnI0Mc9yErMJk/vVPSgvu5YjeYXPo89O3nJd qvWQ== X-Gm-Message-State: AOJu0YxZVRgDCSpHzIQQOlAMCDzgX7ATcpkgrrojw2LFOi16vYTRo3eQ OxuS1alMpU/EMvYK8rmdVCn+wA== X-Received: by 2002:a17:902:ce8a:b0:1cf:df4f:30d9 with SMTP id f10-20020a170902ce8a00b001cfdf4f30d9mr18630789plg.29.1701426473520; Fri, 01 Dec 2023 02:27:53 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:39b5:c526:2f63:2eb4]) by smtp.gmail.com with ESMTPSA id z21-20020a170902ee1500b001cfc9c926b7sm2999507plb.75.2023.12.01.02.27.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 02:27:53 -0800 (PST) From: Pin-yen Lin <treapking@chromium.org> To: Chaotian Jing <chaotian.jing@mediatek.com>, Ulf Hansson <ulf.hansson@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ot_shunxi.zhang@mediatek.corp-partner.google.com, linux-mediatek@lists.infradead.org, Chen-Yu Tsai <wenst@chromium.org>, linux-mmc@vger.kernel.org, Pin-yen Lin <treapking@chromium.org> Subject: [PATCH v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data Date: Fri, 1 Dec 2023 18:26:51 +0800 Message-ID: <20231201102747.3854573-1-treapking@chromium.org> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 02:27:57 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784074971209699180 X-GMAIL-MSGID: 1784074971209699180 |
Series |
[v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data
|
|
Commit Message
Pin-yen Lin
Dec. 1, 2023, 10:26 a.m. UTC
This log message is necessary for debugging, so enable it by default to
debug issues that are hard to reproduce locally.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
Changes in v3:
- Only print the warning when -ETIMEDOUT or not in tuning process
Changes in v2:
- Use dev_warn() instead of dev_err()
drivers/mmc/host/mtk-sd.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
Comments
On Fri, 2023-12-01 at 18:26 +0800, Pin-yen Lin wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > This log message is necessary for debugging, so enable it by default > to > debug issues that are hard to reproduce locally. > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > Reviewed-by: Wenbin Mei <wenbin.mei@mediatek.com> > --- > > Changes in v3: > - Only print the warning when -ETIMEDOUT or not in tuning process > > Changes in v2: > - Use dev_warn() instead of dev_err() > > drivers/mmc/host/mtk-sd.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 97f7c3d4be6e..6ae5e0a9fca9 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct > msdc_host *host) > > static void msdc_track_cmd_data(struct msdc_host *host, struct > mmc_command *cmd) > { > - if (host->error) > - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host- > >error=0x%08X\n", > - __func__, cmd->opcode, cmd->arg, host->error); > + if (host->error && > + ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) || > + cmd->error == -ETIMEDOUT)) > + dev_warn(host->dev, "%s: cmd=%d arg=%08X; host- > >error=0x%08X\n", > + __func__, cmd->opcode, cmd->arg, host->error); > } > > static void msdc_request_done(struct msdc_host *host, struct > mmc_request *mrq) > -- > 2.43.0.rc2.451.g8631bc7472-goog >
Il 01/12/23 11:26, Pin-yen Lin ha scritto: > This log message is necessary for debugging, so enable it by default to > debug issues that are hard to reproduce locally. > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Fri, 1 Dec 2023 at 11:27, Pin-yen Lin <treapking@chromium.org> wrote: > > This log message is necessary for debugging, so enable it by default to > debug issues that are hard to reproduce locally. > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> Applied for next, thanks! Kind regards Uffe > > --- > > Changes in v3: > - Only print the warning when -ETIMEDOUT or not in tuning process > > Changes in v2: > - Use dev_warn() instead of dev_err() > > drivers/mmc/host/mtk-sd.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 97f7c3d4be6e..6ae5e0a9fca9 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host) > > static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd) > { > - if (host->error) > - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n", > - __func__, cmd->opcode, cmd->arg, host->error); > + if (host->error && > + ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) || > + cmd->error == -ETIMEDOUT)) > + dev_warn(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n", > + __func__, cmd->opcode, cmd->arg, host->error); > } > > static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq) > -- > 2.43.0.rc2.451.g8631bc7472-goog >
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 97f7c3d4be6e..6ae5e0a9fca9 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host) static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd) { - if (host->error) - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n", - __func__, cmd->opcode, cmd->arg, host->error); + if (host->error && + ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) || + cmd->error == -ETIMEDOUT)) + dev_warn(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n", + __func__, cmd->opcode, cmd->arg, host->error); } static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq)