diff mbox series

[4/4] dt-bindings: mfd: pm8008: fix example node names

Message ID 20231130172547.12555-5-johan+linaro@kernel.org
State New
Headers
Series dt-bindings: mfd: fix up PMIC examples |

Commit Message

Johan Hovold Nov. 30, 2023, 5:25 p.m. UTC 
  Devicetree node names should be generic; fix up the pm8008 binding
example accordingly.

Fixes: b0572a9b2397 ("dt-bindings: mfd: pm8008: Add bindings")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Dec. 1, 2023, 8:35 a.m. UTC | #1 
On 30/11/2023 18:25, Johan Hovold wrote:
> Devicetree node names should be generic; fix up the pm8008 binding
> example accordingly.
> 
> Fixes: b0572a9b2397 ("dt-bindings: mfd: pm8008: Add bindings")

No, there is no bug here. The generic node names rule is just a style
issue, not a bug. We have never marked these as bugs even in DTS where
they matter. Here, it is an example, so it would not matter anyway.

Best regards,
Krzysztof
Johan Hovold Dec. 1, 2023, 9:37 a.m. UTC | #2 
On Fri, Dec 01, 2023 at 09:35:30AM +0100, Krzysztof Kozlowski wrote:
> On 30/11/2023 18:25, Johan Hovold wrote:
> > Devicetree node names should be generic; fix up the pm8008 binding
> > example accordingly.
> > 
> > Fixes: b0572a9b2397 ("dt-bindings: mfd: pm8008: Add bindings")
> 
> No, there is no bug here. The generic node names rule is just a style
> issue, not a bug. We have never marked these as bugs even in DTS where
> they matter. Here, it is an example, so it would not matter anyway.

Here I agree with you, this is just a cleanup.

Johan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
index 24c6158f73ae..32ea898e3ca9 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
@@ -88,10 +88,11 @@  examples:
   - |
     #include <dt-bindings/interrupt-controller/irq.h>
     #include <dt-bindings/gpio/gpio.h>
-    qupv3_se13_i2c {
+    i2c {
       #address-cells = <1>;
       #size-cells = <0>;
-      pm8008i@8 {
+
+      pmic@8 {
         compatible = "qcom,pm8008";
         reg = <0x8>;