Message ID | 20231130172547.12555-3-johan+linaro@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp553635vqy; Thu, 30 Nov 2023 09:25:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5p0UQMuD9HqtRHxub9Qv8M36RitBtrb62uxK7KlA/dgoHWT9yk9RwZukz9m3XsSLuqOe3 X-Received: by 2002:a05:6a20:3948:b0:18b:d2f5:122f with SMTP id r8-20020a056a20394800b0018bd2f5122fmr25157260pzg.26.1701365142927; Thu, 30 Nov 2023 09:25:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701365142; cv=none; d=google.com; s=arc-20160816; b=DuGuzp599IWrfO+JXVNi2GOqtnrGU17JHK2CJLsYP0q9rCZCihJ/gitcD5RGt6ypmd B1p6tZXkRtc1nfZ1Owax0XdgjXiVugoWUcDZSqeHgg2BL4X2j0TncALLWsF9VTBt7gMZ MvBP+G7MkozKlmBdOHsJxe/AZfE5TLezJoz1fmUCtpbe9W7yFEXEFq8AZluXKNCgGx0O zPywbOlu8FwNKj5/IEir11qXkTVaN95krWjetpQwKm71rFnCZXskIlpTozz1bFM6/Q4v OhoWI+L77ckPQ3Q1ajU5j2plv7TFJ9oWqMIaA5jkLFhr9UikgOEWneVyzb6Gk3xS/Lvs FWMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Wxk1hIxvtKfgJPBAldPrNe7V3LYLeOsw9aM6p71k6Sg=; fh=hWeeVyf1HK5HLn009ewyx5z8J9dlBGpb3HWEii9Ckzk=; b=zY6WTEubRMTTLgAq5uqAgrGaBZgMZsf7ZHM28zND8cs6iRbssc1Vo9M4QOIxX9tCJv 6y0CvL+q1PsufCngY3WWS8RuSi1mYmWYUc5UfHGf+PXH1O1s/xbZ3kp+TAj9xslYqL5/ pjhMfBIJz65zAlM/ZE7v5weqbqq5lxyyLfuL3CKK5krDXaBcjigBtAXtNORd0DPyoY2a /DLutGbKTCtPnOAA0PpbI88VIQTaSLg3sEFZCSPc9fpZR3pv9KKDv+9h+OadFWpd6nyk VmVk2L+g9AKBfO1Wd6fq3hI7QB9CyeiLR9y5XUjFzHcaoUBIS0Q6LDJoWDBtVOf0ryS1 vUFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lTc8+qpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id r37-20020a635d25000000b005c5e2488c32si1645269pgb.405.2023.11.30.09.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 09:25:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lTc8+qpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7A4478025836; Thu, 30 Nov 2023 09:25:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346270AbjK3RZ3 (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Thu, 30 Nov 2023 12:25:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232230AbjK3RZU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 30 Nov 2023 12:25:20 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 371F410F1 for <linux-kernel@vger.kernel.org>; Thu, 30 Nov 2023 09:25:26 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB183C433C7; Thu, 30 Nov 2023 17:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701365125; bh=vdx1NNQgu58UERU8Tsdj0HzBKD91c4adGn6nypp5e88=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lTc8+qpxWuK0rdqA1+FARRSbdXot+DtmzyNeuQTpipNrqm/LK97DmvRs5r9Abfpht NCjnrPHsxNQaZQXNe/j1wP/uqsZJlV+eO5DNmmoUMXTQhI9pmeARwhmrIhdnCyKFH0 O/NHlaDHr4Y+VY4AyMuXyq9vp8F6/Esay5ORqGIAbQS7dKaYuxS1H2NDyXK+21cdY4 LyTm9FF5vYDAcuioI+KQNsxAE/xDzQ515SirNAcAi43Tgdl80kIir95dBFCl6ZRUBU ZJhpI8uPE0IiZa4yFwwaOOA3diEJ9fukpQZDgu8yxZYGGIWxBMSq76ldqoq470jj3/ UWUu3Tx7yfXrw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from <johan+linaro@kernel.org>) id 1r8knX-0003Gx-1B; Thu, 30 Nov 2023 18:25:59 +0100 From: Johan Hovold <johan+linaro@kernel.org> To: Lee Jones <lee@kernel.org> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org> Subject: [PATCH 2/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix example regulator node Date: Thu, 30 Nov 2023 18:25:45 +0100 Message-ID: <20231130172547.12555-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231130172547.12555-1-johan+linaro@kernel.org> References: <20231130172547.12555-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 09:25:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784010656131574263 X-GMAIL-MSGID: 1784010656131574263 |
Series |
dt-bindings: mfd: fix up PMIC examples
|
|
Commit Message
Johan Hovold
Nov. 30, 2023, 5:25 p.m. UTC
The example regulator child nodes do not have unit addresses so drop the
incorrect '#address-cells' and '#size-cells' properties from the parent
node.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 3 ---
1 file changed, 3 deletions(-)
Comments
On 30/11/2023 18:25, Johan Hovold wrote: > The example regulator child nodes do not have unit addresses so drop the > incorrect '#address-cells' and '#size-cells' properties from the parent > node. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote: > The example regulator child nodes do not have unit addresses so drop the > incorrect '#address-cells' and '#size-cells' properties from the parent > node. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > .../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > index e36e5ce58136..60d5e6b3de33 100644 > --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > @@ -77,9 +77,6 @@ examples: > interrupts = <0 0>; > > regulators { > - #address-cells = <1>; > - #size-cells = <0>; > - It's the right fix, but I have to wonder why these are not schema errors? Seems like something in the schemas needs fixing. > ldo3: ldo3 { > regulator-name = "ldo3"; > regulator-min-microvolt = <1500000>; > -- > 2.41.0 >
On 01/12/2023 15:40, Rob Herring wrote: > On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote: >> The example regulator child nodes do not have unit addresses so drop the >> incorrect '#address-cells' and '#size-cells' properties from the parent >> node. >> >> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >> --- >> .../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml >> index e36e5ce58136..60d5e6b3de33 100644 >> --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml >> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml >> @@ -77,9 +77,6 @@ examples: >> interrupts = <0 0>; >> >> regulators { >> - #address-cells = <1>; >> - #size-cells = <0>; >> - > > It's the right fix, but I have to wonder why these are not schema > errors? Seems like something in the schemas needs fixing. > Good point. The fix is just not sufficient. This binding explicitly allow it, so it should be removed there as well. I retract my Ack/Review. :) Best regards, Krzysztof
On Fri, Dec 01, 2023 at 03:42:38PM +0100, Krzysztof Kozlowski wrote: > On 01/12/2023 15:40, Rob Herring wrote: > > On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote: > >> The example regulator child nodes do not have unit addresses so drop the > >> incorrect '#address-cells' and '#size-cells' properties from the parent > >> node. > >> regulators { > >> - #address-cells = <1>; > >> - #size-cells = <0>; > >> - > > > > It's the right fix, but I have to wonder why these are not schema > > errors? Seems like something in the schemas needs fixing. > > Good point. The fix is just not sufficient. This binding explicitly > allow it, so it should be removed there as well. Ah, I missed that. Now fixed up in v2. Johan
diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml index e36e5ce58136..60d5e6b3de33 100644 --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml @@ -77,9 +77,6 @@ examples: interrupts = <0 0>; regulators { - #address-cells = <1>; - #size-cells = <0>; - ldo3: ldo3 { regulator-name = "ldo3"; regulator-min-microvolt = <1500000>;