diff mbox series

dt-bindings: leds: qcom,spmi-flash-led: fix example node name

Message ID 20231130171940.12391-1-johan+linaro@kernel.org
State New
Headers
Series dt-bindings: leds: qcom,spmi-flash-led: fix example node name |

Commit Message

Johan Hovold Nov. 30, 2023, 5:19 p.m. UTC 
  The led controller is a child of an SPMI PMIC, which in turn sits on an
SPMI bus.

While at it, add some newline separators to improve readability.

Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 .../devicetree/bindings/leds/qcom,spmi-flash-led.yaml         | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Dec. 1, 2023, 8:42 a.m. UTC | #1 
On 30/11/2023 18:19, Johan Hovold wrote:
> The led controller is a child of an SPMI PMIC, which in turn sits on an
> SPMI bus.
> 
> While at it, add some newline separators to improve readability.
> 
> Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")

Nothing to fix here, just an example code.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Johan Hovold Dec. 1, 2023, 9:38 a.m. UTC | #2 
On Fri, Dec 01, 2023 at 09:42:02AM +0100, Krzysztof Kozlowski wrote:
> On 30/11/2023 18:19, Johan Hovold wrote:
> > The led controller is a child of an SPMI PMIC, which in turn sits on an
> > SPMI bus.
> > 
> > While at it, add some newline separators to improve readability.
> > 
> > Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller")
> 
> Nothing to fix here, just an example code.

I'll just refer to my reply here for completeness:

	https://lore.kernel.org/all/ZWmn6uicNIqqSwoE@hovoldconsulting.com/

Johan
Lee Jones Dec. 7, 2023, 3:25 p.m. UTC | #3 
On Thu, 30 Nov 2023 18:19:40 +0100, Johan Hovold wrote:
> The led controller is a child of an SPMI PMIC, which in turn sits on an
> SPMI bus.
> 
> While at it, add some newline separators to improve readability.
> 
> 

Applied, thanks!

[1/1] dt-bindings: leds: qcom,spmi-flash-led: fix example node name
      commit: e9a3374e5c545e5eade4623098b958d2f4073455

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
index a8736fd5a539..1ba607685f5f 100644
--- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
+++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
@@ -89,9 +89,11 @@  additionalProperties: false
 examples:
   - |
     #include <dt-bindings/leds/common.h>
-    spmi {
+
+    pmic {
         #address-cells = <1>;
         #size-cells = <0>;
+
         led-controller@ee00 {
             compatible = "qcom,pm8350c-flash-led", "qcom,spmi-flash-led";
             reg = <0xee00>;