diff mbox series

[v1,1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()

Message ID 20231130143206.1475831-1-andriy.shevchenko@linux.intel.com
State New
Headers
Series [v1,1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors() |

Commit Message

Andy Shevchenko Nov. 30, 2023, 2:32 p.m. UTC 
  The pci_alloc_irq_vectors() returns a positive number on success.
Hence we have to filter the negative numbers for error condition.
Update the check accordingly.

Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
Reported-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/intel-lpss-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heikki Krogerus Nov. 30, 2023, 2:44 p.m. UTC | #1 
On Thu, Nov 30, 2023 at 04:32:06PM +0200, Andy Shevchenko wrote:
> The pci_alloc_irq_vectors() returns a positive number on success.
> Hence we have to filter the negative numbers for error condition.
> Update the check accordingly.
> 
> Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
> Reported-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for the quick fix.

Tested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/mfd/intel-lpss-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 8f5e10817a9c..4621d3950b8f 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
>  		return ret;
>  
>  	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> -	if (ret)
> +	if (ret < 0)
>  		return ret;
>  
>  	info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);

thanks,
Lee Jones Dec. 1, 2023, 11:32 a.m. UTC | #2 
On Thu, 30 Nov 2023 16:32:06 +0200, Andy Shevchenko wrote:
> The pci_alloc_irq_vectors() returns a positive number on success.
> Hence we have to filter the negative numbers for error condition.
> Update the check accordingly.
> 
> 

Applied, thanks!

[1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()
      commit: d1432c3fc6c1d6a3fe9ab20332ac01336ee98371

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 8f5e10817a9c..4621d3950b8f 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -44,7 +44,7 @@  static int intel_lpss_pci_probe(struct pci_dev *pdev,
 		return ret;
 
 	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
-	if (ret)
+	if (ret < 0)
 		return ret;
 
 	info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);