From patchwork Thu Nov 30 14:16:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 171929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp419135vqy; Thu, 30 Nov 2023 06:17:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkxPecLjteFH2hwa5bZsT5a4jvfyzslV7Y8GAegitP3HWIn/UkSVKr02pus0Jo15RypM1N X-Received: by 2002:a05:6a20:4423:b0:187:a6ee:9d6f with SMTP id ce35-20020a056a20442300b00187a6ee9d6fmr37825233pzb.0.1701353847652; Thu, 30 Nov 2023 06:17:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353847; cv=none; d=google.com; s=arc-20160816; b=N0CEtyTUGhB9dR2METGcbGGg48RXos8n6kVFroR7lPZhs9arOU7/cN2YlIqSPS9fy/ ZIMEu667SP/9JqbCC2XgC6LFwRaYfwjV9RdVYk9q8rDfpDhh7uzc80orHaMLLW5SJhGN zmbkZ6Jclg16Lsx9tQInNKMK61Ulid15U9v4v5Dv9+ILgjLJLPcpoRtjCP09RXfimKSx p3fiVlvAb56/t1P385WgEV3PbldlXxwKn85lB9MVgGzxWfY7a3JSy62aApOdw7UbB1AW RWiwD9TjPjLxyDdSyWHuntT3YHK1z1y/wJnkjJL0qOFH19Jm9e/1oIJ/30S43ooigza9 1kgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; fh=yrurfj0wqsNBtuv2/DS7hXM5gjUdNl0RGba7zZuGnHQ=; b=PjPqk0+VKZ7ogXOyaZ/U9qXSITLFaSmaanJd3gYn6pK41T1KKpUmtBX/atAO7h7aMJ iEP5HOZvHPRiU1ADv6FIxaxk1V6edtkZV9CPJf9kjVe1xuypTsruUCSjo9g5yHskNlEA 911F4NTIrVVmV/5qldzvEidledtqGOrmUTNIPHx3kc1p3j5FMNLCPxT0WvLaXqmBPowe xBvlRbadg7b0kgx1xhRsBf4p6YMc1xDRxBdnaQhnfLWRTR4hgDZRILB2FY02Loh6dxh+ 3hKQW8jZSFdv/V21NSivFpnN0ysJl6fAiDnUacEKUgD3kdKdG/GrfkMdNK70T8lKYUHy TAxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=XvsyvLyM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id k190-20020a6384c7000000b005c2783b71cesi1268128pgd.661.2023.11.30.06.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=XvsyvLyM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 514608026DCA; Thu, 30 Nov 2023 06:17:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345931AbjK3ORL (ORCPT + 99 others); Thu, 30 Nov 2023 09:17:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345896AbjK3ORJ (ORCPT ); Thu, 30 Nov 2023 09:17:09 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5054BBD for ; Thu, 30 Nov 2023 06:17:16 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a08e4352992so141214666b.1 for ; Thu, 30 Nov 2023 06:17:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701353834; x=1701958634; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=XvsyvLyMPtI3GoxpMgck/+6f8D16FWCeyBAj4ANEBmPkBmx+q+vTAUOUb8BejlHyjk EQZvhWM/8WGmMdji1wmdWlmommNl3gPz8Nz31x6I9zNOoU8PfDbE9d4aOeGGl+4H7Ol1 7Yy3LDZW81uuMf/z8awAtYPRUqtsEkxXVBkbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701353834; x=1701958634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=hBFxxQpJSSgylxzxXYrpU9DiAc+gP3rrA1Wvx1J/zYti+DuPEqjL9CysMVmgFYR/+U mRuRMs8CQVSOYFpcCsb8tlvLwAEYA9vhn9+DU2N8l/wKCpSgi7PS15DYI1mkiECorU9q gZxZywz34DLDlgaP60rmHtBwcasfs5Zdk+enbRL+wZuudZdKiYaeQvry2BNyOfCG26pF n0VdnzKREroukOuKfhtQOsQTAslD9W4OS6PRtRG0dbXhqSPIS/hI1YrRvt0avhIns/Ny ssQMgbiHXFLha+nblQhGRz+RL736YXUWq3g/pPfmBW052kcpR76dAUBbOIz+lDGzEkBS IliQ== X-Gm-Message-State: AOJu0YxmWvLSCs2hngBjs81vBvM5JnnSEoAHnOtd+neG0jikm4hHvViz 8YfbjMHd5KbZRarfRZycz6Sshj87dSH/zx5ydhhBmA== X-Received: by 2002:a17:906:15a:b0:9e4:651f:60cf with SMTP id 26-20020a170906015a00b009e4651f60cfmr14558074ejh.1.1701353834502; Thu, 30 Nov 2023 06:17:14 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:d1eb:b106:516d:db0a]) by smtp.gmail.com with ESMTPSA id my18-20020a1709065a5200b009f28db2b702sm716064ejc.209.2023.11.30.06.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:14 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , Dave Stevenson , David Airlie , Frieder Schrempf , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 01/10] drm/bridge: Fix bridge disable logic Date: Thu, 30 Nov 2023 15:16:18 +0100 Message-ID: <20231130141705.1796672-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> References: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:17:25 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998812155195336 X-GMAIL-MSGID: 1783998812155195336 As explained by the comment of the fixed code, we need to find the next bridge that hasn't set the "pre_enable_prev_first" flag to true. The code, on the contrary, was doing the opposite. So, the order of disabling the bridges couldn't be altered as required by setting the "pre_enable_prev_first" flag to true. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 30d66bee0ec6..f66bf4925dd8 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -686,7 +686,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, */ list_for_each_entry_from(next, &encoder->bridge_chain, chain_node) { - if (next->pre_enable_prev_first) { + if (!next->pre_enable_prev_first) { next = list_prev_entry(next, chain_node); limit = next; break;