[v5,1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub
Message ID | 20231130053130.21966-2-linux.amoon@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp169172vqy; Wed, 29 Nov 2023 21:32:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjZ2tzSflWvQiPH1xTaqJJNhVNEJCMZb95THGxw4c0JIbfv59wkPND38GMfPyuummL+VVY X-Received: by 2002:a05:6a20:3d03:b0:185:a762:9179 with SMTP id y3-20020a056a203d0300b00185a7629179mr28248591pzi.1.1701322348316; Wed, 29 Nov 2023 21:32:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701322348; cv=none; d=google.com; s=arc-20160816; b=K7tUebUuziDVhRiKmuA4QseTn8BzLI7nLvUs4valBuA2qqQmTpcNGOevfL89B1FcA1 eGks2KPb+WPqucMCAYVsi8ygMNRboClECtFoENjDS3syrq7vVUspmgRl7c/S0xk44aqx nYYbat1RCWfmg6q6xJDRo7+C6Dm15ZvwCAuYy1BQZYir4bRwT7WFr3j79N57iChrIWwb 3Y8abjXoDG/fsiRFvt8ndjhH+qi5Cx/bwdBKRrL8ZkhoO6BGHuBirFNZ8aJ3eiSkGBaR AeMW9AQvz4IRxIklW4ZOh5GSvc/THEgf8Q/rblURZIRunRou5t4DTaaOAaAPpgluJcVG 9r+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vtLcNogZL4zUE1VKwwbOaAKoW0e8MSfA/IN4DJLgKRM=; fh=jay4Kww+mdq3zJQhM4PRMH6W4D9Xkh2c+6in7JziTNQ=; b=s0j8mGYdQNQZu2RRXul6b10CrRPfC/MmIrdvY6eeRB+5lQuzfcv8yfcJ2hFx7TNYSu fKvBnlnK0/mb+zwWUsb29aOjhHX0VsKrG7cLlu2YPLO3mTvOAeFnWtP1/4jqfKeUzC5l oFCUQwmlLSKChR4WLg/qkqnPELQa64g40EKUIxT4VmzSbNEE+hI4UYQsKF/gnEwCiVWr fJooureUjg3YgeqmO4fdufeirQuQyeZYd+QEHzC7PiCBp8wHauCb+gTJ9x3XZuTeyYoO 6I2H8LyEjmMTfG08qm6KmashOz1z2cPoW9B4PSGrou/ymNXByih0TGVkgXA3h5VOjGAq 5P6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=c44wfmX4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id g23-20020a1709029f9700b001d034be6d37si433709plq.275.2023.11.29.21.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 21:32:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=c44wfmX4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 40D5380BE868; Wed, 29 Nov 2023 21:32:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231493AbjK3Fby (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Thu, 30 Nov 2023 00:31:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbjK3Fbx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 30 Nov 2023 00:31:53 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4717BC; Wed, 29 Nov 2023 21:31:57 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1ce3084c2d1so5503665ad.3; Wed, 29 Nov 2023 21:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701322317; x=1701927117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vtLcNogZL4zUE1VKwwbOaAKoW0e8MSfA/IN4DJLgKRM=; b=c44wfmX4wj+fqdkYUVCWpmDjskMRevagcxolJ4qjr4dpnauJzm0uI0hSjiyVZri+Ul 8p/cO+wA7eCTUwiLifAG72dCOdeuSaWb5rxYMl7YKbu4eMtgErW/fxxvZ05Pt+haVFfc UcITO+zT/QdtCNCvObCFzMye0kIVovnO14vCupOQkQgDSu6CkBjcFfLLmvjTxUkc0d9x /hNSiahlFlSBlCmhVF3LqJCEi2dybotfgQaRngDSidwzOC5kUpK2IHjfiPu0vBLo2akS kfvvWLK4sLSdMlveGrrVeZ2NH+1Re+5333XFRoVFmb09ySsxwyzhQIH5FBrs5O80RWSk e+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701322317; x=1701927117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vtLcNogZL4zUE1VKwwbOaAKoW0e8MSfA/IN4DJLgKRM=; b=aEtlVC+27j8QVRLCkH+l4ygbeUlOPcQwzI/P1m5FVOmiIQwn0pony2axeXpF8iisGm iSu6JucOrDu+3S5nSWLKtnUSX/JQkopaiuwubqfAGplT7glKwLvzfEfpss2I/0/ajl0O +Sb2iysj2mxKZ8+SsQETR4QGSuLnXmOQ7ORJ1q5S0h46/4UBrsgM5b/ffmiGe+vc06fe fHyR1D7ogQaJKcIZVt9qq/FxPHTbfygLL9Y4+Ki7/9iYwzNy7UxSAhFMv1Zy5bHyBC3V xmZop9cwkSO/o7WOwhliz7NroG1Blc/WUoJVPNxQsXFLCHFL3Kr2QGvtga9dB0WlCTUS 1sUg== X-Gm-Message-State: AOJu0YyfuMZTnAkC2f34j3OI/olAYubeANHyL4SWBcJVc5mQB0XUl6p/ Ta8hbC3sk+/lquBVddBIIeE= X-Received: by 2002:a17:902:dac1:b0:1cf:edd5:f783 with SMTP id q1-20020a170902dac100b001cfedd5f783mr10924289plx.15.1701322317321; Wed, 29 Nov 2023 21:31:57 -0800 (PST) Received: from localhost.localdomain ([49.205.245.83]) by smtp.gmail.com with ESMTPSA id t5-20020a170902a5c500b001cfad1a60cesm336330plq.137.2023.11.29.21.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 21:31:56 -0800 (PST) From: Anand Moon <linux.amoon@gmail.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Icenowy Zheng <uwu@icenowy.me> Cc: Anand Moon <linux.amoon@gmail.com>, Neil Armstrong <neil.armstrong@linaro.org>, linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub Date: Thu, 30 Nov 2023 11:01:26 +0530 Message-ID: <20231130053130.21966-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231130053130.21966-1-linux.amoon@gmail.com> References: <20231130053130.21966-1-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 29 Nov 2023 21:32:25 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783965782625724543 X-GMAIL-MSGID: 1783965782625724543 |
Series |
[v5,1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub
|
|
Commit Message
Anand Moon
Nov. 30, 2023, 5:31 a.m. UTC
Add the binding example for the USB3.1 Genesys Logic GL3523
integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed
hub.
For onboard hub controllers that support USB 3.x and USB 2.0 hubs
with shared resets and power supplies, this property is used to identify
the hubs with which these are shared.
[Conor Dooley: upgrade peer-hub description]
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v5: upgrade peer-hub description : Conor Dooley
[0] https://www.genesyslogic.com.tw/en/product_view.php?show=67 [Block Diagram]
v4: Fix the description of peer-hub and update the commit message.
Schematics of the Odroid N2+
https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf
V3: fix the dt_binding_check error, added new example for Genesys GL3523
v2: added Genesys GL3523 binding
v1: none
---
.../bindings/usb/genesys,gl850g.yaml | 65 +++++++++++++++++--
1 file changed, 61 insertions(+), 4 deletions(-)
Comments
On Thu, Nov 30, 2023 at 11:01:26AM +0530, Anand Moon wrote: > Add the binding example for the USB3.1 Genesys Logic GL3523 > integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed > hub. > > For onboard hub controllers that support USB 3.x and USB 2.0 hubs > with shared resets and power supplies, this property is used to identify > the hubs with which these are shared. > > [Conor Dooley: upgrade peer-hub description] This should not be in the commit message. Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > v5: upgrade peer-hub description : Conor Dooley > [0] https://www.genesyslogic.com.tw/en/product_view.php?show=67 [Block Diagram] > v4: Fix the description of peer-hub and update the commit message. > Schematics of the Odroid N2+ > https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf > V3: fix the dt_binding_check error, added new example for Genesys GL3523 > v2: added Genesys GL3523 binding > v1: none > --- > .../bindings/usb/genesys,gl850g.yaml | 65 +++++++++++++++++-- > 1 file changed, 61 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > index ee08b9c3721f..499192ea4074 100644 > --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > @@ -9,9 +9,6 @@ title: Genesys Logic USB hub controller > maintainers: > - Icenowy Zheng <uwu@icenowy.me> > > -allOf: > - - $ref: usb-device.yaml# > - > properties: > compatible: > enum: > @@ -27,12 +24,46 @@ properties: > > vdd-supply: > description: > - the regulator that provides 3.3V core power to the hub. > + phandle to the regulator that provides power to the hub. > + > + peer-hub: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + For onboard hub controllers that support USB 3.x and USB 2.0 hubs > + with shared resets and power supplies, this property is used to identify > + the hubs with which these are shared. > > required: > - compatible > - reg > > +allOf: > + - $ref: usb-device.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - usb5e3,608 > + then: > + properties: > + peer-hub: false > + vdd-supply: false > + reset-gpios: true > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - usb5e3,610 > + - usb5e3,620 > + then: > + properties: > + peer-hub: true > + vdd-supply: true > + reset-gpios: true > + > additionalProperties: false > > examples: > @@ -49,3 +80,29 @@ examples: > reset-gpios = <&pio 7 2 GPIO_ACTIVE_LOW>; > }; > }; > + > + - | > + #include <dt-bindings/gpio/gpio.h> > + usb { > + dr_mode = "host"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* 2.0 hub on port 1 */ > + hub_2_0: hub@1 { > + compatible = "usb5e3,610"; > + reg = <1>; > + peer-hub = <&hub_3_0>; > + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; > + vdd-supply = <&vcc_5v>; > + }; > + > + /* 3.1 hub on port 4 */ > + hub_3_0: hub@2 { > + compatible = "usb5e3,620"; > + reg = <2>; > + peer-hub = <&hub_2_0>; > + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; > + vdd-supply = <&vcc_5v>; > + }; > + }; > -- > 2.42.0 >
On Thu, Nov 30, 2023 at 03:16:33PM +0000, Conor Dooley wrote: > On Thu, Nov 30, 2023 at 11:01:26AM +0530, Anand Moon wrote: > > Add the binding example for the USB3.1 Genesys Logic GL3523 > > integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed > > hub. > > > > For onboard hub controllers that support USB 3.x and USB 2.0 hubs > > with shared resets and power supplies, this property is used to identify > > the hubs with which these are shared. > > > > > [Conor Dooley: upgrade peer-hub description] > > This should not be in the commit message. Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor. > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > v5: upgrade peer-hub description : Conor Dooley > > [0] https://www.genesyslogic.com.tw/en/product_view.php?show=67 [Block Diagram] > > v4: Fix the description of peer-hub and update the commit message. > > Schematics of the Odroid N2+ > > https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf > > V3: fix the dt_binding_check error, added new example for Genesys GL3523 > > v2: added Genesys GL3523 binding > > v1: none > > --- > > .../bindings/usb/genesys,gl850g.yaml | 65 +++++++++++++++++-- > > 1 file changed, 61 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > index ee08b9c3721f..499192ea4074 100644 > > --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > @@ -9,9 +9,6 @@ title: Genesys Logic USB hub controller > > maintainers: > > - Icenowy Zheng <uwu@icenowy.me> > > > > -allOf: > > - - $ref: usb-device.yaml# > > - > > properties: > > compatible: > > enum: > > @@ -27,12 +24,46 @@ properties: > > > > vdd-supply: > > description: > > - the regulator that provides 3.3V core power to the hub. > > + phandle to the regulator that provides power to the hub. Wait, why is this text changing? I don't see it mentioned anywhere why this is no longer specifically 3.3v Thanks, Conor. > > + > > + peer-hub: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + For onboard hub controllers that support USB 3.x and USB 2.0 hubs > > + with shared resets and power supplies, this property is used to identify > > + the hubs with which these are shared. > > > > required: > > - compatible > > - reg > > > > +allOf: > > + - $ref: usb-device.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - usb5e3,608 > > + then: > > + properties: > > + peer-hub: false > > + vdd-supply: false > > + reset-gpios: true > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - usb5e3,610 > > + - usb5e3,620 > > + then: > > + properties: > > + peer-hub: true > > + vdd-supply: true > > + reset-gpios: true > > + > > additionalProperties: false > > > > examples: > > @@ -49,3 +80,29 @@ examples: > > reset-gpios = <&pio 7 2 GPIO_ACTIVE_LOW>; > > }; > > }; > > + > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + usb { > > + dr_mode = "host"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* 2.0 hub on port 1 */ > > + hub_2_0: hub@1 { > > + compatible = "usb5e3,610"; > > + reg = <1>; > > + peer-hub = <&hub_3_0>; > > + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; > > + vdd-supply = <&vcc_5v>; > > + }; > > + > > + /* 3.1 hub on port 4 */ > > + hub_3_0: hub@2 { > > + compatible = "usb5e3,620"; > > + reg = <2>; > > + peer-hub = <&hub_2_0>; > > + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; > > + vdd-supply = <&vcc_5v>; > > + }; > > + }; > > -- > > 2.42.0 > >
Hi Conor, On Thu, 30 Nov 2023 at 20:52, Conor Dooley <conor@kernel.org> wrote: > > On Thu, Nov 30, 2023 at 03:16:33PM +0000, Conor Dooley wrote: > > On Thu, Nov 30, 2023 at 11:01:26AM +0530, Anand Moon wrote: > > > Add the binding example for the USB3.1 Genesys Logic GL3523 > > > integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed > > > hub. > > > > > > For onboard hub controllers that support USB 3.x and USB 2.0 hubs > > > with shared resets and power supplies, this property is used to identify > > > the hubs with which these are shared. > > > > > > > > [Conor Dooley: upgrade peer-hub description] > > ok > > This should not be in the commit message. Otherwise, > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > Cheers, > > Conor. > > > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > > --- > > > v5: upgrade peer-hub description : Conor Dooley > > > [0] https://www.genesyslogic.com.tw/en/product_view.php?show=67 [Block Diagram] > > > v4: Fix the description of peer-hub and update the commit message. > > > Schematics of the Odroid N2+ > > > https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf > > > V3: fix the dt_binding_check error, added new example for Genesys GL3523 > > > v2: added Genesys GL3523 binding > > > v1: none > > > --- > > > .../bindings/usb/genesys,gl850g.yaml | 65 +++++++++++++++++-- > > > 1 file changed, 61 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > > index ee08b9c3721f..499192ea4074 100644 > > > --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > > +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > > > @@ -9,9 +9,6 @@ title: Genesys Logic USB hub controller > > > maintainers: > > > - Icenowy Zheng <uwu@icenowy.me> > > > > > > -allOf: > > > - - $ref: usb-device.yaml# > > > - > > > properties: > > > compatible: > > > enum: > > > @@ -27,12 +24,46 @@ properties: > > > > > > vdd-supply: > > > description: > > > - the regulator that provides 3.3V core power to the hub. > > > + phandle to the regulator that provides power to the hub. > > Wait, why is this text changing? I don't see it mentioned anywhere why > this is no longer specifically 3.3v > GL3523 has built-in 5V to 3.3V and 5V to 1.2V regulators, which saves customers’ BOM cost, and eases for PCB design. Do I have to update this in the commit message? or leave this original. > Thanks, > Conor. > Thanks -Anand
diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml index ee08b9c3721f..499192ea4074 100644 --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml @@ -9,9 +9,6 @@ title: Genesys Logic USB hub controller maintainers: - Icenowy Zheng <uwu@icenowy.me> -allOf: - - $ref: usb-device.yaml# - properties: compatible: enum: @@ -27,12 +24,46 @@ properties: vdd-supply: description: - the regulator that provides 3.3V core power to the hub. + phandle to the regulator that provides power to the hub. + + peer-hub: + $ref: /schemas/types.yaml#/definitions/phandle + description: + For onboard hub controllers that support USB 3.x and USB 2.0 hubs + with shared resets and power supplies, this property is used to identify + the hubs with which these are shared. required: - compatible - reg +allOf: + - $ref: usb-device.yaml# + - if: + properties: + compatible: + contains: + enum: + - usb5e3,608 + then: + properties: + peer-hub: false + vdd-supply: false + reset-gpios: true + + - if: + properties: + compatible: + contains: + enum: + - usb5e3,610 + - usb5e3,620 + then: + properties: + peer-hub: true + vdd-supply: true + reset-gpios: true + additionalProperties: false examples: @@ -49,3 +80,29 @@ examples: reset-gpios = <&pio 7 2 GPIO_ACTIVE_LOW>; }; }; + + - | + #include <dt-bindings/gpio/gpio.h> + usb { + dr_mode = "host"; + #address-cells = <1>; + #size-cells = <0>; + + /* 2.0 hub on port 1 */ + hub_2_0: hub@1 { + compatible = "usb5e3,610"; + reg = <1>; + peer-hub = <&hub_3_0>; + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; + vdd-supply = <&vcc_5v>; + }; + + /* 3.1 hub on port 4 */ + hub_3_0: hub@2 { + compatible = "usb5e3,620"; + reg = <2>; + peer-hub = <&hub_2_0>; + reset-gpios = <&gpio 20 GPIO_ACTIVE_LOW>; + vdd-supply = <&vcc_5v>; + }; + };