From patchwork Fri Dec 1 00:11:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 172178 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp774359vqy; Thu, 30 Nov 2023 16:12:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVoyURbnXvU4P+T9VDZNUlU6gFE0tvCoI7Iis+qFjsXwHOAWni467DaBVHJ+xCGTD95nE5 X-Received: by 2002:a17:902:dad0:b0:1cf:da41:7293 with SMTP id q16-20020a170902dad000b001cfda417293mr16622647plx.15.1701389526778; Thu, 30 Nov 2023 16:12:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701389526; cv=none; d=google.com; s=arc-20160816; b=aElU4kxe7L9YUQqsEZoy3v7Wv1Co9vcteUXjByMM5o27gEVGisB4m3yJ9BJU33giMT mM/GpUsmQ24GbDS95ILxI+pxsz2KbjYt90tQsaDJ0fllUdJkF3Sdk9Tb72Ucu8roiZ1c rlCJPLJv99tU1zoVPL2AeruPucdhsIBw7Tz7Wt5grL2txaKmMQdLGFQFfEtiKvp362Wl wJ/RSvD09P0N/jfJJwk+ywkRvc4e9GAppmfnt/StYAssolY+Bzk0AJYzePuC1a50Hy9H dzYaainTKYwIuePRZhnxfoW9MP31S78MyoJcmArcZ6qgIEZ3j4UMXuj+AAJaFyPBzQcr GifA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=x8ZaBzDXo9RnM8FSoL8MO657zArSEWDN6QPepXwp/VM=; fh=A+Ecvzvz8gZ9pzspzm0NPwQlkW2DMkqr8ZxbmZEozxQ=; b=GPwiT59CZsjriDSrr1VL59kADi3eUmtC1OAQw1bwKxovM0mfDW7mtvnRTOpgldC8Vr JPgxDJrKApzjPl9GN/m6GV6iq7n8AKJyZLGZoTV1hev1YfZbYaJ2OWV8dVha9ZFvLAAq T9KsQv4dMqUgg/qdUp3Su1LEpWIEcAGpmnVPQiHKtGsp9g9JggLZxhIGohZUSWPztNYO 7HakOGNtUua54ILtVq0gnpPOw457W0hqQZPJL3ecndRaIN4ZDjOVKcJCHvwWWoGxteW9 Qo4/xTjQ2+Bfe6njgTepCvFbLsuPPe1OxwOpxcOQXCxZ622VZLorJdaXfLMgWqvpig+2 OJNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=G8fEjdvI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id h11-20020a170902f7cb00b001cfdeb48e92si1999997plw.448.2023.11.30.16.12.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 16:12:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=G8fEjdvI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9EAE4805A799; Thu, 30 Nov 2023 16:11:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229577AbjLAALW (ORCPT + 99 others); Thu, 30 Nov 2023 19:11:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjLAALV (ORCPT ); Thu, 30 Nov 2023 19:11:21 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12B62196; Thu, 30 Nov 2023 16:11:28 -0800 (PST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AUNbKau026777; Fri, 1 Dec 2023 00:11:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : date : subject : mime-version : content-type : content-transfer-encoding : message-id : to : cc; s=qcppdkim1; bh=x8ZaBzDXo9RnM8FSoL8MO657zArSEWDN6QPepXwp/VM=; b=G8fEjdvIXly47rXWJ7Nv8sPKS8G/5Jt2/Cgfdz8jnBa9K8iPx0acz/loar2naJt21hDE tCN12S/VB5l6M/GIOJKIO+DRa+0yjO3RS/rr7GhD2jrl5r+BoKVFOjwjWfpUxEfi9oXa fbc0nMQot2z57TazTW3SmZBoP2rvY7V490GATXLytLfDz/HZXPVOPphS76whf6i2/ayA wCO9l8Im4i867/oD0P6BZTSjDomYz6RFCxxVLwnRhSN7W2YcLkvUb29rakXiObhWmW+n xNUv4uL12ngDHXY0s3LKRjJeeo2uH0aid1aHk5nuwmFX/+nugpdY35nz8qA2fJtDmXbF AA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uprhdsy90-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 00:11:23 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B10BMrx004020 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 1 Dec 2023 00:11:22 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 30 Nov 2023 16:11:21 -0800 From: Bjorn Andersson Date: Thu, 30 Nov 2023 16:11:10 -0800 Subject: [PATCH] arm64: dts: qcom: sc8180x-primus: Fix HALL_INT polarity MIME-Version: 1.0 Message-ID: <20231130-sc8180x-primus-lid-polarity-v1-1-da917b59604b@quicinc.com> X-B4-Tracking: v=1; b=H4sIAJ0kaWUC/x2NywqDMBAAf0X23IXEF9JfKT2syVoX0ii7Wiziv zf0OHOYOcFYhQ3u1QnKHzFZcgF/qyDMlF+MEgtD7erG+8ahhcEP7sBV5b0bJom4LolUti92LVH fum7qfYRSGMkYR6Uc5tLIe0pFrsqTHP/l43ldP6YQVmKCAAAA To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul CC: , , , Bjorn Andersson X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1701389481; l=1151; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=hcvBx54O8Bz7zZ8nn5xY8JomAWV5QZKJZJGauXpUmo4=; b=1H7LvLa2c4X4b4X18kJh/M9QCWbLPEDMKD5Ycsg2OBPZuCBpeYkEshhXf5fEdJDDRzrvZsIkeKio hnayN/86Dzr3vNxaSsl6JBHaodojXjWKOrKj4SDpmRlaTyTv34iR X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: FoUtAkvhBIGJYePSoixuM-oTueLruztk X-Proofpoint-GUID: FoUtAkvhBIGJYePSoixuM-oTueLruztk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-30_24,2023-11-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 mlxlogscore=580 clxscore=1011 mlxscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311300179 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 16:11:44 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784036224178219086 X-GMAIL-MSGID: 1784036224178219086 The hall sensor interrupt on the Primus is active low, which means that with the current configuration the device attempts to suspend when the LID is open. Fix the polarity of the HALL_INT GPIO to avoid this. Fixes: 2ce38cc1e8fe ("arm64: dts: qcom: sc8180x: Introduce Primus") Signed-off-by: Bjorn Andersson Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 3cd3fe06ff81cfb3a969acb12a56796cff5af23d change-id: 20231130-sc8180x-primus-lid-polarity-54aa6405f61d Best regards, diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts index fd2fab4895b3..a40ef23a2a4f 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts @@ -43,7 +43,7 @@ gpio-keys { pinctrl-0 = <&hall_int_active_state>; lid-switch { - gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>; + gpios = <&tlmm 121 GPIO_ACTIVE_LOW>; linux,input-type = ; linux,code = ; wakeup-source;