From patchwork Thu Nov 30 14:07:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Patchwork-Id: 171920 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp411533vqy; Thu, 30 Nov 2023 06:08:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGAwBOIa1SLtOTe+9wo1sLADvuGVcMeND4gxoXZQzjMSyFfj4/yOHJkJXmTKtMvw4htCa1 X-Received: by 2002:a17:903:124c:b0:1ca:7f91:aa5d with SMTP id u12-20020a170903124c00b001ca7f91aa5dmr26335044plh.16.1701353285009; Thu, 30 Nov 2023 06:08:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353284; cv=none; d=google.com; s=arc-20160816; b=l/2jfhpgkinftUUTqXLsb1ShohwP6if4rgAweVx2Yt+rRePpOUNTaAN8xO/w7cLFh+ NRdZ3SEj9eFORfuzPSYQ83ZkVt0RJ9O8dDjk7pCerCuFYf2M9DIn73FI1a6whtVorzhA xkU6b/PwJp6gzg9vzo4Y3eCZ9hYoCJlxEOkDO5kN02cDbdIofaOuxbeEre0w7NMTXKop BbOzlwH97kmR0Fq1fUgYgb6ZIx0oXlKqChRPt9ZLjNdtIi8cqibzYry3TTvkqVdXL+l4 UKdJN1feov3bGHN8VQgPuPqswXxK7rirq2MLLtbjgI46yhyprLILa7O0P7URSjCotTz1 pRxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=d9nOprxz6fcIYCBwr+hMskwGdUdDHFkRMGiyHUidsjs=; fh=AHZzcI0NKFNU1WuuS/FWF2LprSMGsTAGL8gmMiTfjNU=; b=zW8JB6cSkWpx5M5bBBnBvg/nlqFvNGykHTNLCtNAQ4V+S+do1xWNAad6cZElJdR5Jd /BhsfT3ji/QW838pILeXpMYWurFd+kt/4tILMOAYd2oTxKrIf4aBlHLMvNM0GPERtSD6 L/QYDWIT09HAjbigeNaKn2n+8NpRTUHzOzNToi+nFwTEH5xJCPrEnJpn9Em0eL543b0q pI3hJuNW2XmH7hxyquGargjW9Y1biusjneUt/kxrhLNOAJX4TdJPnJqWwp4x4fp8+qte 2vua1TpZYLi2PlmCRPshc9anU2e8HIcguqgy63JSnpkYWGVv/AKb/ZyQBL29Xpfdwn3w K1iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=NtrxVUXx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bg8-20020a1709028e8800b001cdf0388455si499158plb.111.2023.11.30.06.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:08:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=NtrxVUXx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 61480802796C; Thu, 30 Nov 2023 06:08:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345897AbjK3OHn (ORCPT + 99 others); Thu, 30 Nov 2023 09:07:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345840AbjK3OHb (ORCPT ); Thu, 30 Nov 2023 09:07:31 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 905FC1B4; Thu, 30 Nov 2023 06:07:37 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C32934000D; Thu, 30 Nov 2023 14:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701353256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9nOprxz6fcIYCBwr+hMskwGdUdDHFkRMGiyHUidsjs=; b=NtrxVUXxRHUkgyhUybuEJ67yF7/hooBVKQL1dMnaBsNQOeW0dgE1JuOf9hTahfbTmr5Bxy mI7wZaIDPb1qDd8pj+S06xXM1I13nCCKDHP9fVtPhgS7AMsG2qxOKhwuDthRAtXkdJgWoD ix+3ktB54h+eO43C7XPCr1GBWeTPIXKi6JMTSRECLrP43UCu204AgJ6XoyKBTIbEDINbbO TdHnyaLEUudR5VpKLLQ3HcJVwTfOlVTWYLkaiSaKFf6RLcahLNCUI7EAjKxZV7LFoE70O7 ipAE6OlLZxeQmxo8kRPKeUOK/zNcv8uAsqXRX4FWP1rr4an6oVdQSHAk0VGt0g== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Date: Thu, 30 Nov 2023 15:07:17 +0100 Subject: [PATCH v5 5/9] tty: serial: amba-pl011: avoid quoted string split across lines MIME-Version: 1.0 Message-Id: <20231130-mbly-uart-v5-5-6566703a04b5@bootlin.com> References: <20231130-mbly-uart-v5-0-6566703a04b5@bootlin.com> In-Reply-To: <20231130-mbly-uart-v5-0-6566703a04b5@bootlin.com> To: Russell King , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Linus Walleij , =?utf-8?q?Gr=C3=A9gory_Clement?= , Alexandre Belloni , Thomas Petazzoni , Vladimir Kondratiev , Tawfik Bayouk , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , =?utf-8?q?T?= =?utf-8?q?h=C3=A9o_Lebrun?= X-Mailer: b4 0.12.3 X-GND-Sasl: theo.lebrun@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:08:00 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998221854039271 X-GMAIL-MSGID: 1783998221854039271 Remove all instances of quoted strings split across lines. Fix four checkpatch warnings: $ ./scripts/checkpatch.pl --strict --file \ drivers/tty/serial/amba-pl011.c WARNING: quoted string split across lines [...] Signed-off-by: Théo Lebrun Reviewed-by: Ilpo Järvinen Reviewed-by: Linus Walleij --- drivers/tty/serial/amba-pl011.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 743dee75c68b..be8888db1a37 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -973,8 +973,8 @@ static void pl011_dma_rx_irq(struct uart_amba_port *uap) /* Switch buffer & re-trigger DMA job */ dmarx->use_buf_b = !dmarx->use_buf_b; if (pl011_dma_rx_trigger_dma(uap)) { - dev_dbg(uap->port.dev, "could not retrigger RX DMA job " - "fall back to interrupt mode\n"); + dev_dbg(uap->port.dev, + "could not retrigger RX DMA job fall back to interrupt mode\n"); uap->im |= UART011_RXIM; pl011_write(uap->im, uap, REG_IMSC); } @@ -1021,8 +1021,8 @@ static void pl011_dma_rx_callback(void *data) * get some IRQ immediately from RX. */ if (ret) { - dev_dbg(uap->port.dev, "could not retrigger RX DMA job " - "fall back to interrupt mode\n"); + dev_dbg(uap->port.dev, + "could not retrigger RX DMA job fall back to interrupt mode\n"); uap->im |= UART011_RXIM; pl011_write(uap->im, uap, REG_IMSC); } @@ -1158,8 +1158,8 @@ static void pl011_dma_startup(struct uart_amba_port *uap) if (uap->using_rx_dma) { if (pl011_dma_rx_trigger_dma(uap)) - dev_dbg(uap->port.dev, "could not trigger initial " - "RX DMA job, fall back to interrupt mode\n"); + dev_dbg(uap->port.dev, + "could not trigger initial RX DMA job, fall back to interrupt mode\n"); if (uap->dmarx.poll_rate) { timer_setup(&uap->dmarx.timer, pl011_dma_rx_poll, 0); mod_timer(&uap->dmarx.timer, @@ -1391,8 +1391,8 @@ __acquires(&uap->port.lock) */ if (pl011_dma_rx_available(uap)) { if (pl011_dma_rx_trigger_dma(uap)) { - dev_dbg(uap->port.dev, "could not trigger RX DMA job " - "fall back to interrupt mode again\n"); + dev_dbg(uap->port.dev, + "could not trigger RX DMA job fall back to interrupt mode again\n"); uap->im |= UART011_RXIM; pl011_write(uap->im, uap, REG_IMSC); } else {