From patchwork Wed Nov 29 22:21:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "David E. Box" X-Patchwork-Id: 171626 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:296:b0:164:83eb:24d7 with SMTP id ek22csp15707rwb; Wed, 29 Nov 2023 14:21:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEvY7P2ATNQT4dIDlhA+zXpbEYnVoEnL1xtXQF9UHYgeX+a7BbGVrjhwmms6Tc7x1fAsSb+ X-Received: by 2002:a17:902:e744:b0:1cf:bd98:633b with SMTP id p4-20020a170902e74400b001cfbd98633bmr15782147plf.64.1701296504557; Wed, 29 Nov 2023 14:21:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701296504; cv=none; d=google.com; s=arc-20160816; b=VQYDoYo75LpXfppc03N/wIjn5YfYLJ9ebv1Pj7utc+vtA+4iGT+7j5Qq/D690JxFfB iTYmK7mqiccm/1hlem2/Q1/n5mZWVqGXFoiuVq30yOZ6OSt0Ekxik5Qe4OiLNDJLHhuI a+/vJDQckqGLLMncVyR3s16Ds83L+AgaxD+cr5aWuOzaST1yJ6BGWiijFq9yhkMWs6GL Dtaah2sXjB2doG2CNzKbVWhkwJhuNXkupGxQ6AcJbxB275OmRbfZ6aG77eDEtz8y/8oP zHqQVSV9jyFXTOwOnS5loBgq0ciuiAbsmfTavYDcr/wgKqZNvNOMC9n1+29B59Ae04X+ Vu4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=tEP5qvKl11CM9G+9hBAfG3iL0vfnEaR2u2cmbqMLIIU=; fh=d9G4dsZtlI8UONIvGKwhW94hCYEPGxy6CqYeKEG646A=; b=umsWd9BMwUvvrTu9UKNGU4F7O3hiiXj8+ryoa2Srsz/RbVixUpWiTGusKHRHgM8hR/ uUq7gyq6SESYZLaY/7mLou+lUms3nKIMBbgxMPIPSnvQ7k1o+Cr6RVdUzWWcdvewuLgU /93qumCGF1/sPSw6Wd3bchMbn4MzkeqijIpsSHi73nwwyDRSYT8tfb235NEuaxBh92sb Ud40QvYPdFbsm5Zn2KaRoSGplffcNZ1krC22mzkugPSPdS0gSGBMe5Ny9NPHukaXdzB3 JQYoXGVJ9/9jFJW6OfOAE5sUHWmOpZraY5T0AF/zrSneoYbH1KMpfJX2mb55xwhntQEK uB9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c+1kLW1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id c10-20020a170903234a00b001d00a866032si3474627plh.223.2023.11.29.14.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 14:21:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c+1kLW1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 6A01E8043AF9; Wed, 29 Nov 2023 14:21:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234683AbjK2WVc (ORCPT + 99 others); Wed, 29 Nov 2023 17:21:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbjK2WVb (ORCPT ); Wed, 29 Nov 2023 17:21:31 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE181B2; Wed, 29 Nov 2023 14:21:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701296497; x=1732832497; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=cJyfY54HPBudYrh68xzafpqw9C8nqcKlO72JEQ0kcdQ=; b=c+1kLW1Q9nQ2+9S8LBddcdKvHkMpOHLz8I3T2NdGi1SGFij3Co0DvqDT h5HMpZKRaFpGdxAOLXdybmjybizZDj1hvZPcCqSdxXC64DVvOTz3pXy2k CV2RVqiiuSQMMH4IxKHotbXCHAzsLHwDrcShN9tKxbEIm181+6yrg8+VY msDuA0n/soiO4xvKHcly2klKZHGsf31tv3hgnJM4dUtS3v9uP7aYpqnlN qrVIHJfguXDayCZvqfYdPo+RWW4fTvGq4xcbcQk6OE0bU4SGH6UKBLfOW Z8J44vpm0b7+D6+jrGqTQyOek01uWE2+wGlS90bVrtghtFleOiKf+v4vQ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="11936986" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="11936986" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 14:21:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="798070411" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="798070411" Received: from linux.intel.com ([10.54.29.200]) by orsmga008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 14:21:33 -0800 Received: from debox1-desk4.lan (unknown [10.209.108.167]) by linux.intel.com (Postfix) with ESMTP id E0A485807E2; Wed, 29 Nov 2023 14:21:32 -0800 (PST) From: "David E. Box" To: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, rajvi.jingar@linux.intel.com Subject: [PATCH V6 02/20] platform/x86/intel/vsec: Remove unnecessary return Date: Wed, 29 Nov 2023 14:21:14 -0800 Message-Id: <20231129222132.2331261-3-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231129222132.2331261-1-david.e.box@linux.intel.com> References: <20231129222132.2331261-1-david.e.box@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 29 Nov 2023 14:21:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783938683848329489 X-GMAIL-MSGID: 1783938683848329489 In intel_vsec_add_aux(), just return from the last call to devm_add_action_or_reset() instead of checking its return value. Suggested-by: Ilpo Järvinen Signed-off-by: David E. Box Reviewed-by: Ilpo Järvinen --- V6 - New patch drivers/platform/x86/intel/vsec.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c index 2d568466b4e2..340562ae2041 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -174,12 +174,8 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent, return ret; } - ret = devm_add_action_or_reset(parent, intel_vsec_remove_aux, + return devm_add_action_or_reset(parent, intel_vsec_remove_aux, auxdev); - if (ret < 0) - return ret; - - return 0; } EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, INTEL_VSEC);