From patchwork Tue Nov 28 18:06:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 170904 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4121144vqx; Tue, 28 Nov 2023 10:08:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2OVYr6WzAs/1a4w2Zipe/3Zf67+ZejaGvuYUDRn49lOGIDlFJw1QrelY8y77680u2g0gr X-Received: by 2002:a05:6808:18a9:b0:3a7:6213:6897 with SMTP id bi41-20020a05680818a900b003a762136897mr17606141oib.11.1701194904799; Tue, 28 Nov 2023 10:08:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701194904; cv=none; d=google.com; s=arc-20160816; b=DpPxhr+LpH5U3xsnnNUNqfcOgU3W88HwHa3mC0WGtDd7S3jlUxw/Zsu4P0iSOyxP47 73D+bTra1X21aHnaGWEhiUfl0bKUOyHz9mMS/S4Z/f3ZDVEG6/UbpLLPpgrV9GMZu5DH QfUdb0dvbT6H7GyDEyb8L9gpznabrS0pjDTkUJQgevCcQkz3vqPGUZhI75EWx8jLM870 e1/PtYC0H6BjBK3/C5ws5oJS0tpnSxPW6L7pJYmmmTRP79GpCVYNlDI6W9BEGhIZvbzc 95It4RFAvpBun/dr+swrv3zhYdmLSMBOER1QMNyX5LVBN2/SsOUzcT2aUb/7wNQDIs4R bo7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cFNTbmEEIxAFWmLxoaX84gcXgdV7nz9vt9AUn4KD7mQ=; fh=IvYd8KmNrxjbkVLNuinPuFggVbOuQhRNQNIuKlKp6p0=; b=SIh2mSek0yJcEHbwd++GlVG4b1y+FHrup3YMkkMcMyAw8MpBrveuYQjRehznuz0euy +VNOW1/VVneiFSfBZzZQMjyDoDnF4tpsFMO1QiFFb/M8fUnS9wxDRrPnFKgpXFwPfcpV fVhikIlWp6i+a3YY37RYDR0vCIOyoDH4ETutjHFJd63dvtp9a+F6sExzVFOz5ZIduegS aXZg2DTdhkoPskZ2JLCgPg08os486pjE5z/Y8Wg3ng4wMWlF5k9M4wOLePgKUNFiHGOZ obPmQraYpI3hluyP7fc2Uo+vyGyk4fr/efAYHXX3pr0DkgDIy0LJv4mfY6s8jcQZkHw8 FJ3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VrFhqLCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id s21-20020a656915000000b005c1e78daf17si12501507pgq.485.2023.11.28.10.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 10:08:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VrFhqLCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 9174580A851A; Tue, 28 Nov 2023 10:08:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345495AbjK1SIA (ORCPT + 99 others); Tue, 28 Nov 2023 13:08:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345452AbjK1SH6 (ORCPT ); Tue, 28 Nov 2023 13:07:58 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA887D1; Tue, 28 Nov 2023 10:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701194884; x=1732730884; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5F0bjNxEgtP7x33STn/p+8Uw7VTHKy9xSYAWXxBhJGM=; b=VrFhqLCFUzVatPfxj/OenNNQ+XRtRCAkD9sj5Ljavl9zz8LrtUkul6dI Ovto1+AoX5YuWp95PCQ2uSSf3gVlG4b0HgWbAwTRC74WLaGprCZwGo6r8 1OEeIJk0oIM2r53VlR/Afk4T4UwToZKk+NmxbgisS8l+/GI5urML2Tz3w QQShuOnNOGnYAhkoBc+fwoob8skmWVLxg8Rl0EuCYgybVPA5bh8zbMoQE Oq+uxw2q0svV8H3QNXzRIenw5LN/xlzuvkIL4F5Z39sN+/8OYGQxrF7Hd uiLTG2JEf6Bs02cxXP0eP4PGJV0wCzahZg43d8mMJ1uCd/fyQVehJF0oK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="373166001" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="373166001" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 10:07:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="859523451" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="859523451" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 28 Nov 2023 10:06:59 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 12AF74D4; Tue, 28 Nov 2023 20:06:58 +0200 (EET) From: Andy Shevchenko To: Guenter Roeck , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Eric Tremblay , Jean Delvare , Andy Shevchenko Subject: [PATCH v1 2/3] hwmon: tmp513: Simplify with dev_err_probe() Date: Tue, 28 Nov 2023 20:06:03 +0200 Message-ID: <20231128180654.395692-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231128180654.395692-1-andriy.shevchenko@linux.intel.com> References: <20231128180654.395692-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 28 Nov 2023 10:08:19 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783832148745587599 X-GMAIL-MSGID: 1783832148745587599 Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Andy Shevchenko --- drivers/hwmon/tmp513.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c index 849a8c3e1020..6e01800404fc 100644 --- a/drivers/hwmon/tmp513.c +++ b/drivers/hwmon/tmp513.c @@ -630,9 +630,9 @@ static int tmp51x_vbus_range_to_reg(struct device *dev, } else if (data->vbus_range_uvolt == TMP51X_VBUS_RANGE_16V) { data->shunt_config &= ~TMP51X_BUS_VOLTAGE_MASK; } else { - dev_err(dev, "ti,bus-range-microvolt is invalid: %u\n", - data->vbus_range_uvolt); - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "ti,bus-range-microvolt is invalid: %u\n", + data->vbus_range_uvolt); } return 0; } @@ -648,8 +648,8 @@ static int tmp51x_pga_gain_to_reg(struct device *dev, struct tmp51x_data *data) } else if (data->pga_gain == 1) { data->shunt_config |= CURRENT_SENSE_VOLTAGE_40_MASK; } else { - dev_err(dev, "ti,pga-gain is invalid: %u\n", data->pga_gain); - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "ti,pga-gain is invalid: %u\n", data->pga_gain); } return 0; } @@ -679,9 +679,9 @@ static int tmp51x_read_properties(struct device *dev, struct tmp51x_data *data) // Check if shunt value is compatible with pga-gain if (data->shunt_uohms > data->pga_gain * 40 * 1000 * 1000) { - dev_err(dev, "shunt-resistor: %u too big for pga_gain: %u\n", - data->shunt_uohms, data->pga_gain); - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "shunt-resistor: %u too big for pga_gain: %u\n", + data->shunt_uohms, data->pga_gain); } return 0; @@ -721,22 +721,16 @@ static int tmp51x_probe(struct i2c_client *client) data->max_channels = (uintptr_t)i2c_get_match_data(client); ret = tmp51x_configure(dev, data); - if (ret < 0) { - dev_err(dev, "error configuring the device: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "error configuring the device\n"); data->regmap = devm_regmap_init_i2c(client, &tmp51x_regmap_config); - if (IS_ERR(data->regmap)) { - dev_err(dev, "failed to allocate register map\n"); - return PTR_ERR(data->regmap); - } + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), "failed to allocate register map\n"); ret = tmp51x_init(data); - if (ret < 0) { - dev_err(dev, "error configuring the device: %d\n", ret); - return -ENODEV; - } + if (ret < 0) + return dev_err_probe(dev, ret, "error configuring the device\n"); hwmon_dev = devm_hwmon_device_register_with_info(dev, client->name, data,