From patchwork Tue Nov 28 10:24:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 170683 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3813173vqx; Tue, 28 Nov 2023 02:25:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGu+NrvMWxwMYtHDx3A/FSNTNbkpkOymFVWQZ/EKF8h9LsMdvjIaIlbuuYSVDJ2gHPo3RjT X-Received: by 2002:a05:6808:149:b0:3af:9330:9494 with SMTP id h9-20020a056808014900b003af93309494mr16103320oie.32.1701167107117; Tue, 28 Nov 2023 02:25:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701167107; cv=none; d=google.com; s=arc-20160816; b=znBkE06t2Xe9iwpDD0fK/nfOPoFKUx7sF7ODCKY4ZfejqXOmT7EY2PIAs2Oj6nUFRY +7SDx9GaN2LzaD+x13BmFMLcuYVz1s9Sg0Lf0u5Ko3SQPVCGwp93bEOOtgFhkUugGo1J j1fzy3uJEo94hyfTYP2Bv+8iTq0TaRjw7ii2K/ZYl6ACBEPsn8dhMefqiQn3BJCKEPvn PKD9lr8EyE1pRSMi1y/huEiQhXOB+rQlA1NRHbQxZi+yZCZcU2vxMYdEW6bW8CaSt5mh /dHUjwbGE8qNx2/KTJevJ0Ddsil5SMHmrYLExKM35/N68satPubC3S1MOg6EznbD8E78 7ozA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=0BixMsYasiXIPHadonWdl51lxCVEacIVI+akBO9gDIo=; fh=e6/uyeFf2k7v8JUtB6fPyaAS5iN3eSA1hjtg35V2Rzw=; b=I2Y1S2f2Sv4AzBo/Dy4V4b03FjFI/ymqt2BvYgYwVaoGbmnfihR5UkoejugKTrYhXu ZIl5sJ4tgq/K6OgRPrEA0zst0ae0SEerXfecO7grHwGVaVxDWxDwDrp0NrHVv21qEjTA jIRJrGXSpIFyUFETZHt62TaLTpr0Tqv/hcuyXOJHXZQGUYHIKavMsOoS5zW2Hf/FYdbl dFRSmtnKEBtmE7O2iwX1wTlaKOeIC0UOQgBsULHulDrrd7YSjnzKVk/e+NhlFp/jFCy6 6zyvJ/PhsaWhSw77EvOH8cN2XpU7JcE8UtRjiX+byGQSxqgpewl1QFCJAC7U+ZrRhBdh ludQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Es823PGa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id 18-20020a630112000000b005be33e97880si11936819pgb.167.2023.11.28.02.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 02:25:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Es823PGa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9DF84807867A; Tue, 28 Nov 2023 02:25:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234903AbjK1KYs (ORCPT + 99 others); Tue, 28 Nov 2023 05:24:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344290AbjK1KYk (ORCPT ); Tue, 28 Nov 2023 05:24:40 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4592919A6 for ; Tue, 28 Nov 2023 02:24:37 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F636C433C7; Tue, 28 Nov 2023 10:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701167076; bh=T1VDwdVoznG4IGcAFm7TZYH0xfCY62bnXCmWs4ZMug8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Es823PGa7N8+2/RqZWUTPGalS09UBfOox7B6BdSAOKCoXn8PUOkUjypJJZ64fuzIo zMAB87ALQ3P2yVAo8iUbNumc2SBfTeZX6z7DLIz84dT2rRs6YSPPVTt3/MJ2WbqaK9 t6IFUAWO87PmVRy8jTpAjsXLvXi8JmMNvhNA3doYnUq/H/euKSzo0/zxJem0yfGK5D PQ4nsCURYrT/V9f69RJNyjuVvcbb4ND4+Ac43aL4fCSFupOYYM+GE8t4istKgBxGiE 541gLkQza0iC1Fx6ONRbh7xbpqSvAnM1z7cLyhs7vRoMSZEa60HJY2tmnUkdJ0kC94 Lx8k+YvoT6v4Q== From: Maxime Ripard Date: Tue, 28 Nov 2023 11:24:16 +0100 Subject: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments MIME-Version: 1.0 Message-Id: <20231128-kms-hdmi-connector-state-v4-5-c7602158306e@kernel.org> References: <20231128-kms-hdmi-connector-state-v4-0-c7602158306e@kernel.org> In-Reply-To: <20231128-kms-hdmi-connector-state-v4-0-c7602158306e@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Emma Anholt , Jonathan Corbet , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Hans Verkuil , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Maxime Ripard X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1029; i=mripard@kernel.org; h=from:subject:message-id; bh=T1VDwdVoznG4IGcAFm7TZYH0xfCY62bnXCmWs4ZMug8=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDKmp+y++fVU5/cIzv1tzXztP2P2vx3m9st/0q6cWNte2M agLmklO7ShlYRDjYpAVU2SJETZfEndq1utONr55MHNYmUCGMHBxCsBELm5j+MNl2NlnxjlVMZXv z+GJkn1ne/2eu2RavXKY/Ezpefc6m8eMDJMuH00x6BfoFTjeUq2VYb53F6tgkd9DB42sDwpNB5I tOAE= X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 02:25:03 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783803000520947331 X-GMAIL-MSGID: 1783803000520947331 All the drm_connector_init variants take at least a pointer to the device, connector and hooks implementation. However, none of them check their value before dereferencing those pointers which can lead to a NULL-pointer dereference if the author isn't careful. Let's test those pointers instead and error out if any is NULL. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index b0516505f7ae..2f60755dccdd 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -229,6 +229,9 @@ static int __drm_connector_init(struct drm_device *dev, struct ida *connector_ida = &drm_connector_enum_list[connector_type].ida; + if (!dev || !connector || !funcs) + return -EINVAL; + WARN_ON(drm_drv_uses_atomic_modeset(dev) && (!funcs->atomic_destroy_state || !funcs->atomic_duplicate_state));