From patchwork Mon Nov 27 16:54:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 170311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3287341vqx; Mon, 27 Nov 2023 08:57:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQBCjwfUnWaWPNSiocXZXRrojU4kAZfr3sMfjv+QeWxB8eXVX0+tZeePvVFKl14RQvkNIw X-Received: by 2002:a17:90a:49:b0:280:6b5b:3f40 with SMTP id 9-20020a17090a004900b002806b5b3f40mr10734061pjb.8.1701104278037; Mon, 27 Nov 2023 08:57:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701104278; cv=none; d=google.com; s=arc-20160816; b=smuG+QJ7vri1aAhHDuOl8CSEp+F7UAMI4YAV+wFLCVWXVFMjIv24hgJkOX7hH0NIsi h2FKHd9JB8oHXfyr94SBJ3lADxIovEchBrgLPlHSYmzOd8Wh2s4yc1Vc6M/5P5HAp/JJ oHm6lrdjJ3IqahZjNGs1ZVuLss+TWS42FIf4XYgLAKM0NMYBCG/PxQKI22rAAxCj4ile TH3PWcHOu9yyZyLv04iZ1eZ+Xy9nD2mO75aDQNGaS9cPZccCzsFqQU4MvCB8TwzpMZGk mG0w3Sg/PSPgmcmqlhcLYTG0YAHHt26qvVoMNkae2U/x31ZaDEq/LJahLLnsPtWZcF7A QJcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PbkRfZSSZ4srLIlz7mtfVunyM/RVCejLVDmj0XSYABo=; fh=nikTID0PJ6NwkGNufN11Ag6f/xC6mcRAltiCDIW3jKo=; b=CScI8FIHeqgQAmYwRrlNBegKM5eSbZqwLd9MHZ4/42doGh85+yUwHd5EwNxuw4fMqv 1l/ZYxdi5WeRrRgRvx8LDlxRslxDOsAlAopmSleEa8BPi3hw1ootQ/UNf/Lf8Db7oDRP t2EQ0CPzRJKoOL7U4k8pQXO7NXTDIvk37+YjxOY+8Zg/DSa43w7AWlaSLzCy6yqIfU8A acpStIfs+5EcAHOvP8td4xYC79YEwP00GqQ6vwaqnOySlPMSMYW27iMWSb6u6/5pVPN9 gjgw2IVP6d71BzcM2G34EITp/2fTU2hUmsYxsNAK00DvyP6Lh2odhikp0Tj4snZ0V0xm rmtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=J7Mw8BYc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id az22-20020a17090b029600b0028397f87e96si11133811pjb.143.2023.11.27.08.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:57:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=J7Mw8BYc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 225EB8165393; Mon, 27 Nov 2023 08:57:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234616AbjK0Q5b (ORCPT + 99 others); Mon, 27 Nov 2023 11:57:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234630AbjK0Q4B (ORCPT ); Mon, 27 Nov 2023 11:56:01 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 717462102; Mon, 27 Nov 2023 08:55:32 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 800036607332; Mon, 27 Nov 2023 16:55:30 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104131; bh=6CSGRDiRO2lms0wmXZEstJJokqkWndIp5smKK5ehYIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J7Mw8BYcjh+HAx9EHuD5fXzhsVfCxdRCEtvz6kxPPisGcj/BjvZK0XvHWOdNU65Qd it31XKO2UrDstoCrnrQT0G1QxAI2CaPBB9k8A7g8fYXE0K+T3LdwZ4KwStLepJpSC/ hJiahT1bN4TTma3pTkZ1zjLRTQK4eQMjmmZAoTl0JtFOG4xk2hdW4xDTuR2YIcA8Wu BOH6/Oy285pZ3z5U1wse4tYdhb4lsbxuK47nAAk3uMI9k7+zb40ffFYK9iGR/gnoP1 oiAWMuN3Y3uM2lz67aCyIZYMMwYABSCocGAikiGOHdgPhpKaoDwSRq/pYkPGNVPSmJ tZ1xh73ZqnCOg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH 32/55] media: saa7146: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:31 +0100 Message-Id: <20231127165454.166373-33-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:57:50 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783737119485623669 X-GMAIL-MSGID: 1783737119485623669 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. saa7146 driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard --- drivers/media/common/saa7146/saa7146_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/saa7146/saa7146_fops.c b/drivers/media/common/saa7146/saa7146_fops.c index 79214459387a..db4d725a05d4 100644 --- a/drivers/media/common/saa7146/saa7146_fops.c +++ b/drivers/media/common/saa7146/saa7146_fops.c @@ -387,7 +387,7 @@ int saa7146_register_device(struct video_device *vfd, struct saa7146_dev *dev, q->gfp_flags = __GFP_DMA32; q->buf_struct_size = sizeof(struct saa7146_buf); q->lock = &dev->v4l2_lock; - q->min_buffers_needed = 2; + q->min_reqbufs_allocation = 2; q->dev = &dev->pci->dev; err = vb2_queue_init(q); if (err)