From patchwork Mon Nov 27 16:54:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 170305 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3286957vqx; Mon, 27 Nov 2023 08:57:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjELMlr/etGBdM+76/CzWTT4GZlfTw8O1IssddRolEeJZ5+fQxM1/ltZQ8pxxI4mgs88OQ X-Received: by 2002:a05:6a00:2d96:b0:6cb:6992:4640 with SMTP id fb22-20020a056a002d9600b006cb69924640mr13251429pfb.26.1701104241759; Mon, 27 Nov 2023 08:57:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701104241; cv=none; d=google.com; s=arc-20160816; b=vtFlgNi2G+ZpLCjZOUGGv67O5TfO1wAKTJXBM92FgEVfIPzEroKH1NuC4BmTYgQNcP 6/U4HjLdfY9VciPDYet0zg8hRlUFy6iptICg1cWbvRGnVNFv7JphF3wXQrfc6HSjUXCu j8ioc48fA/12KnToCt/mzQbq2FACMzL3lzd8NIRJbpZyFIjuvwpm29KOapmMs9tqGbXB Qc197KlPj2YoTHIIg9yvd7A3ZGT9FS6BWsgVc6K52G5zWJgtIvKrBWJR7g984RCx10U8 LQWnWFkcF8MqdwOkkS+8vtX3pcwwdK+yWX+oOaCAgTtItC8NPu8tYv9j7J4pMrAzDnwz ui5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1XNjA5g3U0JbnDTKlqfvTFEyE7v4Nf0ogJ8ykq5NAvo=; fh=kHaBZwgUF1FrZPBMSZEmpAMyWRf4p+095v8m4+7t5pQ=; b=b5EGWiNEH7TTzxXpgFD/xGyf3g+K2z66ekEyWUH5iKK+XQE3C75XzbJBt/1zm0a2kA pS6VgM2AhUWb+SBYf2mm0jcU+41+yAaf577GXfoa+X1AnvGEJVpOyyep+OVcWM+Bp8RE fE2QFt8S27aYqpDa9oXFdr6D2hFOYQOnJIXMJp8sjJL+iu+Y+ABAPpyKfPuWS6tIB+sb 4bT7h/8GRAFD8d6GJ7jQ4BWdhZcIRta7DbHh1SCCPTX/6fqKU5pVI0VbusKvdwweiokL iWm/nJtgNquQI5GmUUJ2tLzYDjBhLl1uO6NFpbXRF4SteO74FDRixAzkviWvoxP9ZyX9 G+rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="X46/hfSc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id fd11-20020a056a002e8b00b006cb7f9dd0b6si10543417pfb.214.2023.11.27.08.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:57:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="X46/hfSc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2EB72809E73E; Mon, 27 Nov 2023 08:57:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234488AbjK0Q5H (ORCPT + 99 others); Mon, 27 Nov 2023 11:57:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234522AbjK0Qzw (ORCPT ); Mon, 27 Nov 2023 11:55:52 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB2F71BEE; Mon, 27 Nov 2023 08:55:26 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id D177E66071EF; Mon, 27 Nov 2023 16:55:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104125; bh=6fLuB21NqZHQ9MYfFVjrs/3zUstZGwJ8LCc0NS9LFcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X46/hfSczoQezSpEDoB4gMCxWcrCu/PmrdfIbxsUqXyLgcUdVBnZCapFmnqB78f/N Rkq0xLW3LBtfKdyUICWd/b22L5v1j8lzrc8Y5msfSqTshXC+m7zfUGixwUhDoCz7wh wtJi0FY7JsF8dAf6NKcZYSliw+At0lUQSi71uRC9PhERPgdTULw3A3YvhiXSWBliUU gA0Fvzm0vNwLT70tWOxUAbChhbJnIzkp/Rp1vwpHGUnJ6zDMzRdOtc1O1ObkkQzdVi NxoaXijoa0y2AxYoW/ASXNaHfye9kIX7lSDtOKvdorglQxUxcxLoXJVbTkboPYDrtS azWDc8ZE0l/Rg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Sakari Ailus , Bingbu Cao , Tianshu Qiu Subject: [PATCH 25/55] media: ipu3: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:24 +0100 Message-Id: <20231127165454.166373-26-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:57:18 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783737081663119677 X-GMAIL-MSGID: 1783737081663119677 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. ipu3 driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Sakari Ailus CC: Bingbu Cao CC: Tianshu Qiu --- drivers/staging/media/ipu3/ipu3-v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c index 0fe2b858da83..197326fbcc2c 100644 --- a/drivers/staging/media/ipu3/ipu3-v4l2.c +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c @@ -1198,7 +1198,7 @@ static int imgu_v4l2_node_setup(struct imgu_device *imgu, unsigned int pipe, vbq->buf_struct_size = imgu->buf_struct_size; vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; /* can streamon w/o buffers */ - vbq->min_buffers_needed = 0; + vbq->min_reqbufs_allocation = 0; vbq->drv_priv = imgu; vbq->lock = &node->lock; r = vb2_queue_init(vbq);