Message ID | 20231127165454.166373-21-benjamin.gaignard@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3286762vqx; Mon, 27 Nov 2023 08:57:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXC0/70Vsq5zvvQsXq0WoTKVhT0j9h/EBUGbFNxOUY6EcgqA//jda5WYywNUZKIIctP5fJ X-Received: by 2002:a17:90b:4a03:b0:285:6f70:3e02 with SMTP id kk3-20020a17090b4a0300b002856f703e02mr14479360pjb.33.1701104223676; Mon, 27 Nov 2023 08:57:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701104223; cv=none; d=google.com; s=arc-20160816; b=KcDEtK2N9qpti8pSNSwve+ndPNkB1o89b7rs3p7Nt0AbG1I2cu4VQ4Na8bX/b3vCzV foKrUHmGUBuNrsh9ukoYgioTqscQze9SrNhef00NW8oJAKhPhbktgQiX8o+fbDldHXin B0BzfwWMeY3yU2GFRKta/gv2eOx8eJNGr/6HuWDkT+LqW2TYRwsVIcW/iM+WuAVLQzgA 9B5EIFtC74sN6V/RwIPIDstDq8qUwnOeuOo5SG+3Wf0D34LwFsdDd/bStuhvUNI657hs 9snYQCQ1SrQvC1t4wTsAny2LTHryPRg6qCg9BYQcG/JYJ9mO+gwiRiQR6lBB8CiobrVJ 3pOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=veurVNi6s6aoa+f1h1oB8b9G9+kFGgAmw5qlxaQt2EI=; fh=AJvajGurJww4MIiKHtF6oSDbh02msZyVL2eyE+ODfEQ=; b=GDxYRt11/rUnIKQu9cU6QCQKRCSgVCYQNuXJmMFv6qrpIs+rCz3wi7iYKLkO4pM1k/ iI9c7U186r6xDQ5KiikUTkkJIAoRhlbEiqNBP9iO4zjw7jodhEYhsEOlURg7STVSvGUd L5iVJ0khaTcxoRyyu4nhAZbhDmfXLMSYLxOZ44UsASs/xQHuexoTbgKfLxG8vnmYqq9v 4Z6qJ7+UkaxJ9tXIRSxiYRMcmv+/Rn6tqGSIC8pSfIAfwr3UwyEbQZMS+inNea2kfNPk Oymt1bEWDMvMznR4qmw7Mg0ejbXl23cBaKt/Yu29HaVML844Srl3R2Jzi9zT3KDo37J3 RsxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="QmkVCU/m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id a9-20020a17090ad80900b002802f5bf238si9849781pjv.31.2023.11.27.08.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:57:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="QmkVCU/m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 28B1B80789F9; Mon, 27 Nov 2023 08:56:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234388AbjK0Q4U (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Mon, 27 Nov 2023 11:56:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234448AbjK0Qzn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 27 Nov 2023 11:55:43 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E358D1BC0; Mon, 27 Nov 2023 08:55:22 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id C8BB06607314; Mon, 27 Nov 2023 16:55:20 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104121; bh=Gl50yamOqxp5F3J61bdrX38ELoxqbgPRLIk274ynKbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QmkVCU/mNHbH08K2PA2jaI2xpeSxJuOOVrVYa9HY95R21gu5GweBdW7pOdRQcH8sw 97ZkaSuMlYvGcvZWaIfkrUeK33oPvy53N5merp83DLt/CUymdW3Sdv986VTvkfckbY BvQudmhzSKODBZ5dyEb6bSpshQR6PoiBmaQ6biGTlhD3/RgJK9mtSDxhHZ6CRWC5PU b9oleh9GiLzNgSFmVOKJ9Nj3xyRbK0toNby8SYUtxVwn9+gx8kpTovWdSkHXfcOf36 aKWhVZHgm9eW7jxcvb8bZMqte8r+rePL7h6ZehDPaKj80A6YWzn7oAUah6WqqOhnNc 5tseHh0k29+8Q== From: Benjamin Gaignard <benjamin.gaignard@collabora.com> To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard <benjamin.gaignard@collabora.com>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org> Subject: [PATCH 20/55] media: sunxi: sun6i-csi: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:19 +0100 Message-Id: <20231127165454.166373-21-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:56:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783737062044571274 X-GMAIL-MSGID: 1783737062044571274 |
Series |
Clean up queue_setup()/min_buffers_needed (ab)use
|
|
Commit Message
Benjamin Gaignard
Nov. 27, 2023, 4:54 p.m. UTC
'min_buffers_needed' is suppose to be used to indicate the number
of buffers needed by DMA engine to start streaming.
sun6i-csi driver doesn't use DMA engine and just want to specify
the minimum number of buffers to allocate when calling VIDIOC_REQBUFS.
That 'min_reqbufs_allocation' field purpose so use it.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
CC: Chen-Yu Tsai <wens@csie.org>
CC: Jernej Skrabec <jernej.skrabec@gmail.com>
CC: Samuel Holland <samuel@sholland.org>
---
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c index cf6aadbc130b..73e721936d27 100644 --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c @@ -1010,7 +1010,7 @@ int sun6i_csi_capture_setup(struct sun6i_csi_device *csi_dev) queue->buf_struct_size = sizeof(struct sun6i_csi_buffer); queue->ops = &sun6i_csi_capture_queue_ops; queue->mem_ops = &vb2_dma_contig_memops; - queue->min_buffers_needed = 2; + queue->min_reqbufs_allocation = 2; queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->lock = &capture->lock; queue->dev = csi_dev->dev;