From patchwork Mon Nov 27 16:54:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 170291 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3286382vqx; Mon, 27 Nov 2023 08:56:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbOqVIFPyik1Y2AkbW1imWC+IzeIE4QFnOVC0QLGQO/HmCSlm1VXUpPBs2e+3oALf92Gyw X-Received: by 2002:a05:6a20:2d0a:b0:188:1125:88bd with SMTP id g10-20020a056a202d0a00b00188112588bdmr19467586pzl.43.1701104191135; Mon, 27 Nov 2023 08:56:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701104191; cv=none; d=google.com; s=arc-20160816; b=TAyDbYBwhvK0S5Mow5ANZ/K3EelU9XoJmnzMvdBzg9/105RcBrOWbxUJcvQV/CFHaa 9J+vAlz0mIoPEezyQwmNTyvW6UACXOXyv2Gf8wEQArOr5vhm6Yz+vY/eJQZWbmrh9n2P o642Lkjt7gcbaWvI9xRu8yQnHyfr1XwddQq+X/eYFFBUwqQzXH+znE8usWWHH1Dn5jvv vftjCakvZ5wNhoD9x26oFUMn5+J3lq5AD8rrFOFMjKtN0LX8BnBcefnGfl1aInGWt0+P XinPWGGCgjgrZG4HLbW6CrYrsY8K7qvu8abHWBfUG5SYgRyC9F4ZrDUa9C5mHSsXPBLA 1ryg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dacwjV9GZ8fbusF4fqlg88GIJyDKYCvTV+c7K23zUnY=; fh=AJvajGurJww4MIiKHtF6oSDbh02msZyVL2eyE+ODfEQ=; b=UrjbAbG44qMBIg3f3zl5O3ZH+qLhWhgdi/eCe/GD6woNyMmqr84KDxjitxfY1tEc81 fWjJK7MrFzUfxMjRZwSvwxZmDT51YyMvnqqv6FIjD0xuDHUDqZCPrRGyHRtGL6BJAzws vBXE2ujeqcx4GfmXOXTdwVHKlcdvdM6KiVuH5awtK7o5jKFd5yC3JjQwS5JB4bSEHLoS Ec+5cL9YRcHHsHccJTSBvd0G42Q01SafeuKCWgug02fOySZgeqf9KWOyHtgb3hgISoOn p/rS00+lUJmQ4JzxWBKU0XCse2+RMImUvmwckyH8qub9T98YYo2/bTNLZbHa5b6oOfyo fJRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=BCsEkgRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id t42-20020a056a0013aa00b006cb901a87c4si10514705pfg.376.2023.11.27.08.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:56:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=BCsEkgRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 3A7888158382; Mon, 27 Nov 2023 08:56:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234650AbjK0Q4G (ORCPT + 99 others); Mon, 27 Nov 2023 11:56:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234351AbjK0Qzb (ORCPT ); Mon, 27 Nov 2023 11:55:31 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3E9519A4; Mon, 27 Nov 2023 08:55:20 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7184C6607295; Mon, 27 Nov 2023 16:55:18 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104119; bh=nJOkOwWG7HAPg6iANkaE4/DJj5MpFIvKCNqxFpSa5Zo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BCsEkgRkF4I9+jKVaLVK/3afs96G/4+2+vyjv9QCBgA8jFRYWCAajIW3xxZETRBo9 tgAXP7TuMlICwajFzuuxxPjlfd1iWnVacLHUsfH1f/waR8rkWqVUnyNRRUgsMur1u9 cYcusOnwHTTJnAtWClQFvLYMcs4rCCIxFcdbouVKijEy1uCVut+hPm5bfhq/WaeXd6 jiMtIsdu/kerhiVahdK02NKYg3C4/SN5aTxb6KWs9ODpChLU/SZdSImNgujMG82jjh gr5cqbYm8yNCICgMFsvZsPuA5ulTFb5mNFRjUHiXl+vpvvagIntfjcxN+TRu6S3Hzd nnNt7JCp1E3dA== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Subject: [PATCH 17/55] media: sun4i-csi: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:16 +0100 Message-Id: <20231127165454.166373-18-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:56:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783737028448524178 X-GMAIL-MSGID: 1783737028448524178 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. sun4i-csi driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Chen-Yu Tsai CC: Jernej Skrabec CC: Samuel Holland --- drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c index 95b5633b7914..8f071cba2d25 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c @@ -411,7 +411,7 @@ int sun4i_csi_dma_register(struct sun4i_csi *csi, int irq) for (i = 0; i < CSI_MAX_BUFFER; i++) csi->current_buf[i] = NULL; - q->min_buffers_needed = 3; + q->min_reqbufs_allocation = 3; q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; q->io_modes = VB2_MMAP | VB2_DMABUF; q->lock = &csi->lock;