diff mbox series

[net-next,v7,3/3] net: dsa: microchip: make phylink_mac_link_up() not optional

Message ID 20231127145101.3039399-4-o.rempel@pengutronix.de
State New
Headers
Series Fine-Tune Flow Control and Speed Configurations in Microchip KSZ8xxx DSA Driver |

Commit Message

Oleksij Rempel Nov. 27, 2023, 2:51 p.m. UTC 
  Last part of the driver do now support phylink_mac_link_up(). So, make it
not optional.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/dsa/microchip/ksz_common.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Florian Fainelli Nov. 27, 2023, 6:19 p.m. UTC | #1 
On 11/27/23 06:51, Oleksij Rempel wrote:
> Last part of the driver do now support phylink_mac_link_up(). So, make it
> not optional.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff mbox series

Patch

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 3b1fe9aff6a8..9545aed905f5 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -3113,10 +3113,8 @@  static void ksz_phylink_mac_link_up(struct dsa_switch *ds, int port,
 {
 	struct ksz_device *dev = ds->priv;
 
-	if (dev->dev_ops->phylink_mac_link_up)
-		dev->dev_ops->phylink_mac_link_up(dev, port, mode, interface,
-						  phydev, speed, duplex,
-						  tx_pause, rx_pause);
+	dev->dev_ops->phylink_mac_link_up(dev, port, mode, interface, phydev,
+					  speed, duplex, tx_pause, rx_pause);
 }
 
 static int ksz_switch_detect(struct ksz_device *dev)