From patchwork Mon Nov 27 13:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 170139 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3125520vqx; Mon, 27 Nov 2023 05:51:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhp9jJyxmRwQ/hX2YUAnrqDrRnuC3v6euhYkNz/0LLe3rseuONBVlYkSEI7w5s8IscuVD4 X-Received: by 2002:a05:6a20:12c6:b0:18a:59fa:7da4 with SMTP id v6-20020a056a2012c600b0018a59fa7da4mr11463368pzg.29.1701093073028; Mon, 27 Nov 2023 05:51:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701093073; cv=none; d=google.com; s=arc-20160816; b=tt8zjRb7pDU20a+rbrsRAVzZkyiHVB7WA9lSRQs5wzWVURemo9/JZ60QpgZQgoleLD R40s/S5UuMBvoeNONbP3o+ptmTTshsfNP3iAPPDYWR61YeHnqF0AuLvcNcEc7WNedMCk NSuhwwNfHs4+v4DYV7qLLEYmN/KMw4iRjifgocxJA6fjQaTXnHMWpCU65YmMtFdpi2QL d+rGY+opMiFzgUG+wWVlaDVTsepTtiZwBQwhRC7zOniQ454lQ8hdsbq7XgvspAFXGst9 gTHC8unaZMRE4HLvWKPp1Xdq+os+2XP3YQEEqU/QgQZEIqYL03hXS22COgFhAJzX7rsf 1tbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VHnnOST8qodLmJFznIgEimpV+tpqmVRkoEWPEvmIUa4=; fh=ft66dTIf9typG3XG2ol8N8ONYnIe/glzv1IfDwcUiZU=; b=R2y55U5OneJeomBm+JyaXQVcPWCq6AuxhUHGj7VoTpwPAJ+63qCi5Afp/W9nTnyFZK NeFTMfsz3BQnAbZEHFYaYzDb3KtBcUJh3jXMZWvlCWnz+71C94r3uE90HNM6/Z5D231A XPoOl/KCjIPZnhRx/eu2AaXa3dwXFRH7dfpp6Wf8FG/DfoSe0GBEoOd2evVV/o4u8JHA fek9EQROTnWDCWDE97H0kDS4ziZjR2o3QupfgXBa6bsRcJkHg0HA5eEGPU5ZThxwIGna VKgqDZU3MDlctvesjhYrqd7WKhiuKQcBtS/FvsqC5u3vnoKX2m0kYkmnxsV3H7KBXG8n WPZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MQ8cKdK4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q15-20020a056a00084f00b006c040064180si10289189pfk.335.2023.11.27.05.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 05:51:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MQ8cKdK4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A1AB88067A50; Mon, 27 Nov 2023 05:51:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233172AbjK0Nuj (ORCPT + 99 others); Mon, 27 Nov 2023 08:50:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233145AbjK0Nuh (ORCPT ); Mon, 27 Nov 2023 08:50:37 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C6CBC3 for ; Mon, 27 Nov 2023 05:50:43 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-507a0907896so5504578e87.2 for ; Mon, 27 Nov 2023 05:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701093041; x=1701697841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VHnnOST8qodLmJFznIgEimpV+tpqmVRkoEWPEvmIUa4=; b=MQ8cKdK4bNOca3G7Et1zmM77SY/Ak0sQR1ArkiUBopHtmB1i0t07vcVVL1Nzo5mtGW ifUoi+1N5D/a3/KpQtuWOrdHZC23Sw+8hVbW4ofE+sb6PMKGXFOYgboRIFE7u6NuLoHy N0hpEee8gpG1cMEOy/fpt9qYYocKAeOYjN+ivAhx7YrmJSSIU6dx5lq2Vbo87RDVXc2G OiORGdHLWsCDvU0zHj+WJAksifhWR7fc0xFl3mCH6S+dG6R6D36cOQMa9KgWT1COgWFM NeEseneDVG1neSFiEs+g3+BmJE/Tf7aUDzveGJDN9Ho2MBbQQSBgOYv3ywYzQX5rwOto Nzig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701093041; x=1701697841; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VHnnOST8qodLmJFznIgEimpV+tpqmVRkoEWPEvmIUa4=; b=HgD8TVGyZm6lJXzLTgsLZ6nLbla4vLo1309ry3ghA+xICoN80VdlNEM7ZdMLNt5ggp 2geQ58MDB6i04q1dVbW6CZ/EuCqZu0eKzqX2KRri5Z8Fd4kU3MLpZ+FxeUdeUzXznL3m ULlz1m+rlpSynTBKIIdWwKXaYBkAGRH0Pegi6uFwCQqhmGp54K597I/lAXynwocX6Bd2 Gb5IvndcTAN9F6yc08BF9F2lglFbSkP/ysLhyyOIf2y6oFFww/79Appc8qR2JStLqVea fx8DmIBVxycQAhiaP5qB+i67QGk/NpU/VAlhNvEMUt5DTfDA9ccuyfj0GkhCC3KcMdcs JOqQ== X-Gm-Message-State: AOJu0YydKscLF0KnV6mhaRHtYum8NuVMC30WrHyI2mf1mHkSLwfdZxe3 CcPFXi8mc4O9Fs2RVujq/87plz6Zz6nyIO/aZ1I= X-Received: by 2002:ac2:4210:0:b0:50a:9fb9:91b with SMTP id y16-20020ac24210000000b0050a9fb9091bmr6551854lfh.64.1701093040398; Mon, 27 Nov 2023 05:50:40 -0800 (PST) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id t7-20020a19ad07000000b0050a71ac3f45sm1472663lfc.203.2023.11.27.05.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 05:50:39 -0800 (PST) From: Ulf Hansson To: Sudeep Holla , Cristian Marussi Cc: Nikunj Kela , Prasad Sodagudi , Alexandre Torgue , Ulf Hansson , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] pmdomain: arm: Avoid polling for scmi_perf_domain Date: Mon, 27 Nov 2023 14:50:33 +0100 Message-Id: <20231127135033.136442-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 27 Nov 2023 05:51:10 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783725370454438745 X-GMAIL-MSGID: 1783725370454438745 It was a mistake to prefer polling based mode when setting a performance level for a domain. Let's instead rely on the protocol to decide what is best and thus avoid polling when possible. Reported-by: Nikunj Kela Fixes: 2af23ceb8624 ("pmdomain: arm: Add the SCMI performance domain") Signed-off-by: Ulf Hansson Reviewed-by: Sudeep Holla --- drivers/pmdomain/arm/scmi_perf_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pmdomain/arm/scmi_perf_domain.c b/drivers/pmdomain/arm/scmi_perf_domain.c index bc3f78abb6da..709bbc448fad 100644 --- a/drivers/pmdomain/arm/scmi_perf_domain.c +++ b/drivers/pmdomain/arm/scmi_perf_domain.c @@ -35,7 +35,7 @@ scmi_pd_set_perf_state(struct generic_pm_domain *genpd, unsigned int state) if (!state) return -EINVAL; - ret = pd->perf_ops->level_set(pd->ph, pd->domain_id, state, true); + ret = pd->perf_ops->level_set(pd->ph, pd->domain_id, state, false); if (ret) dev_warn(&genpd->dev, "Failed with %d when trying to set %d perf level", ret, state);