From patchwork Mon Nov 27 11:13:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frieder Schrempf X-Patchwork-Id: 170090 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp3015042vqx; Mon, 27 Nov 2023 03:14:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHn4634W/Ls4yxfTTtUnMhQM+JvpQ7Z03rzNdj8a3Pm34K1Zw23YANiHV04CfrKMPqo82Hd X-Received: by 2002:a05:6a00:1d88:b0:6cb:d24b:878a with SMTP id z8-20020a056a001d8800b006cbd24b878amr11066491pfw.25.1701083696667; Mon, 27 Nov 2023 03:14:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701083696; cv=none; d=google.com; s=arc-20160816; b=rQiJ/40t09aM1L5ruIo5h7DfJ/NS+k5ERn3QT18eO9HNsTbrA3DpuJIW5r8MXgn2MJ 9c1zN5c0aGgmvTVTHVXVh0SIxI7Odd3FaUo27hQCALH54P1ws4k+5d1cZh6RmyZySXPs cGsIBM6wP0xO54uRplD4d2fg7SSAFExNG037+p05Q/et4LizKMqAPJwAlJnik/HLZT/I Ry2EsESagz6wXL46U/vPVQXkJlkKDmIwNn78MFROZ2CjGS5YNJqWAP20rfwFJ3ouK5Ly pJC1fe9Bd6uP4erzYDtkYzxj7ynahZCPfShQUYcjXXd1IQmsbpc3zxouXXUT7nuOwXjI wn+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TtObVw8YUfhzjUng8rafUVONqr/7XfXzj8lQVXj7nE0=; fh=6xybqo/qINGZ9KaXl6oKe3bJXDcN/FE23vLcQKtUoIw=; b=xnW9/g5OnLGMpdk/jzvR9SYtmrDgMKwK6bJa+xpdmYyeBiy78gqVEB7YJv0KUzAiBZ hilcO4aHvqa7AlnJiljGwVikU0K3DLe7wg73tQEG57OXE1UlCvV+yOW3+SF+OL1uja40 o/8CTC9y2WsTzCSnXQMTjlJVt6/2GRwjUpPxsa5wo+XnlriQTb7du+xFDXevx+5qteP6 n12+wxxLn5CsqeOfap5imrrOL3uheqQI1e6snaE/IMBM77hOJ5yRs6udS0D0jfXZ+5r4 U6lIN3kIIaR42eWQ4xEHFGcq8ZcBGckGpDIDh9/X+q8HzmEHG0rtIw+BXxUE2qyG6p+g ZePA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fris.de header.s=dkim header.b=jxYmtFaH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fris.de Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u2-20020a056a00158200b0068fcf6fe22csi10103779pfk.304.2023.11.27.03.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 03:14:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@fris.de header.s=dkim header.b=jxYmtFaH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fris.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BE65E805F958; Mon, 27 Nov 2023 03:14:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233054AbjK0LOn (ORCPT + 99 others); Mon, 27 Nov 2023 06:14:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232680AbjK0LOk (ORCPT ); Mon, 27 Nov 2023 06:14:40 -0500 Received: from mail.fris.de (unknown [IPv6:2a01:4f8:c2c:390b::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BB5F135; Mon, 27 Nov 2023 03:14:45 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8BE47BFC84; Mon, 27 Nov 2023 12:14:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1701083683; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=TtObVw8YUfhzjUng8rafUVONqr/7XfXzj8lQVXj7nE0=; b=jxYmtFaHcFe41GJCnvC8Svwbkg37mJSpLm4qO1gWbAUTUnCKPGDd/hmADPdkZVlCPbj9Yz XfaExWSgaDJjsOMoiegizQh/Uq5LR/kbSQJWPviolY4cGf8iOIv2z3CMlFimdib+JcBSae 92Qh/DjGEMidH1hik5T5vXjgzoj0DcYUx5cuyMTXdVgWj1LVoHjenRz+owFiPqQNOGM7Mz tOX1PQwTmbwmuol9ZbavI5zEzgGM0OwTGbGqB4UWs8H1SgODkYkXrnP6W5jIjqVK4qyXJJ mPTbcD45rm6pBKMsycvoCwe9AtFPrH4SbcGfAgkJYmRcsknwltMCMODqMi+s0g== From: Frieder Schrempf To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Matthias Kaehlcke Cc: Frieder Schrempf , Anand Moon , Benjamin Bara , Rob Herring , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Subject: [PATCH 2/3] usb: misc: onboard_usb_hub: Add support for clock input Date: Mon, 27 Nov 2023 12:13:23 +0100 Message-ID: <20231127111332.107640-2-frieder@fris.de> In-Reply-To: <20231127111332.107640-1-frieder@fris.de> References: <20231127111332.107640-1-frieder@fris.de> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NEUTRAL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 03:14:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783715538517322600 X-GMAIL-MSGID: 1783715538517322600 From: Frieder Schrempf Most onboard USB hubs have a dedicated crystal oscillator but on some boards the clock signal for the hub is provided by the SoC. In order to support this, we add the possibility of specifying a clock in the devicetree that gets enabled/disabled when the hub is powered up/down. Signed-off-by: Frieder Schrempf --- Changes in v2: * use %pe to print symbolic error name --- drivers/usb/misc/onboard_usb_hub.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index 077824beffa01..0d84b16deab50 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -5,6 +5,7 @@ * Copyright (c) 2022, Google LLC */ +#include #include #include #include @@ -61,12 +62,19 @@ struct onboard_hub { bool going_away; struct list_head udev_list; struct mutex lock; + struct clk *clk; }; static int onboard_hub_power_on(struct onboard_hub *hub) { int err; + err = clk_prepare_enable(hub->clk); + if (err) { + dev_err(hub->dev, "failed to enable clock: %pe\n", ERR_PTR(err)); + return err; + } + err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies); if (err) { dev_err(hub->dev, "failed to enable supplies: %pe\n", ERR_PTR(err)); @@ -93,6 +101,8 @@ static int onboard_hub_power_off(struct onboard_hub *hub) return err; } + clk_disable_unprepare(hub->clk); + hub->is_powered_on = false; return 0; @@ -267,6 +277,10 @@ static int onboard_hub_probe(struct platform_device *pdev) return err; } + hub->clk = devm_clk_get_optional(dev, NULL); + if (IS_ERR(hub->clk)) + return dev_err_probe(dev, PTR_ERR(hub->clk), "failed to get clock\n"); + hub->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(hub->reset_gpio))