From patchwork Mon Nov 27 09:04:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 171100 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp153431vqn; Tue, 28 Nov 2023 22:30:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHoZ9h859XHEkvpCL6iiNjUEVIhVDfWWtonp4/Lx4vVFAVNErbyk2w+tDH70t4H2RURnpC1 X-Received: by 2002:a17:902:c945:b0:1cf:c340:c1e2 with SMTP id i5-20020a170902c94500b001cfc340c1e2mr11836554pla.50.1701239435155; Tue, 28 Nov 2023 22:30:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701239435; cv=none; d=google.com; s=arc-20160816; b=XQcubMua7wfKxbS72hk9NbOW9Rdf2IGl3RfLMSHHL76dgPoP331aHsxDFS5S7QIxyx C5/PUQ8aaEs0uec7LqjvIqs5ah7u5tvzSm+N+jSMm3Xc1wLWQdGBirhAQutrV23d0Joz vV1o5hZdOy19Kf8E/aLko654IdRKw+E+M/2FV8jUq1B3vkqpgWrxN2qSXAZIL2FMbw6D OUC45kTYWbZbTC+KwOJbrqXmpQGdRyHavlltXS3tj+N1vY6+XkE/g+of0ku1sD21Op1a /O2IzPJ8Nqt3WoZRhYmXsv4DteeB3Ut2MlUexPnKrTx0dmUi2OjKSu6PNQwL1ORT+rDX +wXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ELkubP0P+TLGoCnHyLiXJ02PqgLHPPVcTUt4fu5hI+U=; fh=+jwocpIEcpU4tee9Medy6FcgWbHkCjESAH5riVYuYu0=; b=BnZtzvz+dG/WzxyJJqcSo9kxfPndIF9JzKcQ82qu/zR1zHv0+HuJQUx07r4iRgqg1q b04Z+Qw5oWFRY5jKukaxwUhqlMwjkNDnjYV/74u0Goxk98O+TiQ/VA7lTwPPNlIgKmZn zvmHxNS5qgPhGq6vkiuEngQfWHssS31dPMKTq0WjI3pSNMIfEyZMwGMYOdJKRxsyAPAa WXf4/w1tUYpt2V24mPIh7Xts94m+cT1CxhIN1lRBuKAQ6LXNfQIwbaLoDyN+RAtGOMGz G/fAxlslaRmAxy3t9XZ5dUk/GXO/fyXEUyLJ1N0mfmoSb3z9gCHeMzou8Ofh43QdmuG0 +gSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=m079bd8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id t9-20020a170902e84900b001cfb3d25f2asi9350102plg.652.2023.11.28.22.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 22:30:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=m079bd8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BC38F805FB3F; Mon, 27 Nov 2023 01:05:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232748AbjK0JEx (ORCPT + 99 others); Mon, 27 Nov 2023 04:04:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232711AbjK0JEo (ORCPT ); Mon, 27 Nov 2023 04:04:44 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D261A5 for ; Mon, 27 Nov 2023 01:04:48 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a00c200782dso571759666b.1 for ; Mon, 27 Nov 2023 01:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1701075887; x=1701680687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ELkubP0P+TLGoCnHyLiXJ02PqgLHPPVcTUt4fu5hI+U=; b=m079bd8OcJFjx2msty6Z505gA3PCNLsaHAVt4LHONHEE7B36nWigeeRxBK3dbs0a4k SzOzokAVadlBLFaTRAUNwFBBpX9tvxtJ7PwSwOyOKiRHwMXLRpzZ/poRfBuggQ02BsY8 KDAyh67FRQ/Pm7U19f+eRHBw/buiigB3YUIib6QEYsaTZvD9vWEZ51pq3371W7HR1ib4 rB/Fl1a/lT0kpz+AscGl6u5MDKiFzArgxAAiNS0tvizvKDpx+SGpKc1GgsMzMAId3cnZ fRMiO0hpo0xRQnNdguTt5CrLrs5bKofZuw/i9lW42cOFi3tBYCpC8zOYX/n7lzrM+E0s bPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701075887; x=1701680687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ELkubP0P+TLGoCnHyLiXJ02PqgLHPPVcTUt4fu5hI+U=; b=f+/VD6gmpq67SA/XuZ+9uKfJHkOxo1M/pSsm9wko57VaPDigBPdGqZyZEqvEhzXLTj vCYcPu7ehgKM348D50Vv/rB0fUZE0dVqbQRFt5JYDgUCgoBLDWGb4F+9ZE2jsKa+Tvjs BOCSmpp2F7ow2VMy8QtLUwyZnkYOjSSo/a6xOWLk6RCczIOVV+fnbwWCE1g49LRc7nxC nMRebwr4CzInmBiUV1z16+lgKfQyhZpFJlbEiC/ac4IveeOak/YFE/kzU8sDY4PuTiZd XzZpadr8XAX9o40DSB3OSYICldsAkNU8JqmHgVcbm5Cnbf/5gt9Mq2Kv7oAvUMbl+qGY BpJw== X-Gm-Message-State: AOJu0YziQhLBZEXLQp9Ziwqhx8xlygwkLaEON2mX051LccfGj8T7rCgH //t/vSB8dw21zpYsq6e4W7BjqA== X-Received: by 2002:a17:906:3a87:b0:a03:24d9:12ce with SMTP id y7-20020a1709063a8700b00a0324d912cemr7704534ejd.63.1701075886887; Mon, 27 Nov 2023 01:04:46 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.125]) by smtp.gmail.com with ESMTPSA id ay14-20020a170906d28e00b009fad1dfe472sm5456539ejb.153.2023.11.27.01.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 01:04:46 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, p.zabel@pengutronix.de, yoshihiro.shimoda.uh@renesas.com, geert+renesas@glider.be, wsa+renesas@sang-engineering.com, robh@kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, mitsuhiro.kimura.kc@renesas.com, masaru.nagai.vx@renesas.com Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH 4/6] net: ravb: Start TX queues after HW initialization succeeded Date: Mon, 27 Nov 2023 11:04:24 +0200 Message-Id: <20231127090426.3761729-5-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127090426.3761729-1-claudiu.beznea.uj@bp.renesas.com> References: <20231127090426.3761729-1-claudiu.beznea.uj@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 01:05:03 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783878842060007682 X-GMAIL-MSGID: 1783878842060007682 From: Claudiu Beznea ravb_phy_start() may fail. If that happens, the TX queues will remain started. Thus, move the netif_tx_start_all_queues() after PHY is successfully initialized. Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Signed-off-by: Claudiu Beznea Reviewed-by: Sergey Shtylyov --- Changes since [1]: - collected Rb tag [1] https://lore.kernel.org/all/20231120084606.4083194-1-claudiu.beznea.uj@bp.renesas.com/ drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 2d4f4fb3d16e..f7e62e6c9df9 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1812,13 +1812,13 @@ static int ravb_open(struct net_device *ndev) if (info->gptp) ravb_ptp_init(ndev, priv->pdev); - netif_tx_start_all_queues(ndev); - /* PHY control start */ error = ravb_phy_start(ndev); if (error) goto out_ptp_stop; + netif_tx_start_all_queues(ndev); + return 0; out_ptp_stop: