Message ID | 20231127051414.3783108-2-victor.liu@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2859184vqx; Sun, 26 Nov 2023 21:10:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsdTm0HspDBYjlXYVNm/RoXOMjqkZ7tHHIcH94e03CI7WsFCSJEm72hdIg9PrVFrLdK26V X-Received: by 2002:a05:6a20:430f:b0:187:6dab:578 with SMTP id h15-20020a056a20430f00b001876dab0578mr11150662pzk.40.1701061840542; Sun, 26 Nov 2023 21:10:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1701061840; cv=pass; d=google.com; s=arc-20160816; b=BooMw1eR61QR1co7HvqZEybsQfyCsxJb+kwRtWItGopeMydEdRPcDpqPbd65FmYRTV WW6xcb7uY2b52B1EdPiIZKYOnIGMpJlGPU3epHiBr3WoGFhML5Gjj7n+u0zUlZZsihJo wyfvowDMjXkwpOKqhAbkafh+V2r2d/I2R3JQ4TchBlhFLdN2kaFNNzdhwJ9mUHt/saa4 1skPiOMEA9WJC6EjLmnNonzQfhcGKOtTaA6VDt9SdWgXPELFEd7EK1v0gN3iaHcWaGBO 39OhLpMvh4HhltrvUwlvsYvToMBqw63gpA6Mc87c0szHqRTDSvpODElsKl24oNILtp4Q fxNA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4H8CoeRgMRXKQ1atlM4es6H/VQXCXNsOCyDVttO8y40=; fh=umrqgllYhWw5vxVpcn9kRdEyuYEdXxvnhZqsZuCDxwQ=; b=pcGSYk9nBxYuQ5YjdJjE0cpmbFDT+JRPeTScnAEXhp6nmLV1TfMZBkjcrKii4S4Mna 6XFphHooHOIAW/mmuy6Uv+AopugA0dIypoFkmRXCblg26d8ndxc5BwNzNeqbIN91NAFc zsMA8hipgVHrskxeY2Ndz6EaNjICL0brpWTkmUqnN6ru/s7ps41rEIvW3/04QdkbiD18 K2k2RaqsXf4Vh1eTz6sSRJkET30rsSfa9HJ3XOoOBW49VuY7/gpIcCVOlsjW70r479ek 6jm3Qz7eaFvkAODiMy19ZaTtZzS0w8g06E+VD0LAzc18rX/G58dLVCuFHdNScSuYrMHa m65g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=MpzsM7BD; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id gb24-20020a17090b061800b00285ca600d79si1730573pjb.85.2023.11.26.21.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:10:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=MpzsM7BD; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 28E488087E1C; Sun, 26 Nov 2023 21:10:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbjK0FKG (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Mon, 27 Nov 2023 00:10:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjK0FKD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 27 Nov 2023 00:10:03 -0500 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2064.outbound.protection.outlook.com [40.107.22.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EAFC127; Sun, 26 Nov 2023 21:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QwZeynRGSOIcXvwHRIx0RBcFqe1FucaqFM5wytaXDPyv+UbYvCcN7uC7on4KyHRClx+M5c1MpsndOItZ0pcAS3s5HP8+qPue1vlFd4HWaQo1ffME+8bg/HiEbbX2+nhqTWfgeSJWXACk6ioA/ENMWvOXnya0owF/lDPIYwaBTNlmRc+iMjpALsY/AtnxDQ5OQeBu+ts9O4V2fdIEaj9dqngT38x9gvSOdbOIgO71667vc7c8d3buAe0ekgeNAdnaPU7ssFfMQLLHwu4S38ICGGsy/QXDwS+i9x4WNYJrWrW+LgVVXKDVgQRK3D0Objqla6u/mWdgq39zColOACGXTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4H8CoeRgMRXKQ1atlM4es6H/VQXCXNsOCyDVttO8y40=; b=FT8B9pkNI3nuH/EjIOZnw/L6snFMAqmEoqUIm2+mKOYjOF99gvvgsxEjxyk0xqq/uGU+wmYHPwn89X8ba5T3Dm2tw8c5X54NDnVe4pzhkkR0hcVZmAEVRc0ZFK6ODJ9VVvJYz4FQoHZv/gqYU0UDP/GhwO/fRVx5Sv8cZ3HTvli/hRtTC74mSgI07HEs6nXY2l0WKds5OnR+06zI9eZOyuMM1mPLFJf0PZjVYmcGpV/oFfYnfx8QdVIh0QSN2QEdTG7Yyw2zzhv7aYof6oVIKxdqe+SkxMelhMECLQyx4vNaRdoMRRmdHxnvflPernLIyjrRchGYVBm1kSODmGUU1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4H8CoeRgMRXKQ1atlM4es6H/VQXCXNsOCyDVttO8y40=; b=MpzsM7BD2smJACHL3z589zGYFx/L902i2lEtZxZh0g5u8hlxWrCHBDIlMzz0YJoo4qAmB8p3f0efyiNQjzMKfP8VI7yBaF01dkAsXA+YoABp1V0fTuECC8/97+LZwKlHHomjxPZDkyGNBqH02AyYkdaWC3dMCZUCLxONpLmL9mw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AM0PR04MB6961.eurprd04.prod.outlook.com (2603:10a6:208:180::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.21; Mon, 27 Nov 2023 05:10:07 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d99:f43f:65a3:9bf]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d99:f43f:65a3:9bf%7]) with mapi id 15.20.7046.015; Mon, 27 Nov 2023 05:10:07 +0000 From: Liu Ying <victor.liu@nxp.com> To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: linux-next@vger.kernel.org, sfr@canb.auug.org.au, gregkh@linuxfoundation.org, rafael@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, angelogioacchino.delregno@collabora.com, ulf.hansson@linaro.org, linus.walleij@linaro.org Subject: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules Date: Mon, 27 Nov 2023 13:14:13 +0800 Message-Id: <20231127051414.3783108-2-victor.liu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20231127051414.3783108-1-victor.liu@nxp.com> References: <20231127051414.3783108-1-victor.liu@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AM0PR04MB6961:EE_ X-MS-Office365-Filtering-Correlation-Id: 05668dcf-cf8a-4525-b087-08dbef071f21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ghIeuuMjoVMyO6nJC1YOydTyD9tCcKeaNUaJN7lZP1Nb47nsjzl3P74I/dLLeRpdifTIBIi5h8l7uMYKnkYWiHOZk7tLYSR4XCxY05G6At/SdCr5KZsRWSd3SRP0a0ojqS1Yk7Z3x7nSD8punuikQnmyQLWyuIR9Mcf4uHYCZslJBk3Rq7rwWWywVXxWku2CwHJMOxlQVL2MgRZsay7r4J/83KDsOH7Z8UvplmL7HKVpRvGrc2jiujU1Hzdgb7tTy2hyP0nxpQFeWzHU8+g0yqixEKBUyOA6/pfHl3D8VS9bvWqoldpo9Sic4MBSbcQsww/NI5ikA3DlXtP2JXnhHyH90UD30NyklkbbCw7FJITrPiN96JudM72OhPwL6L8lFHb9nJmywzMUnnHz7rYolP1yGoOdtf4PbauOPXRQNoKx3UDdnO+l1x7216lJ/K0N4IO33lkGu5JqXma0n0lNzWzsvj5v7DdR2eL43b5tMUPBJ83ONkIlaMVxdyo2AMLhZ/N7qA8PEXzCVNF/Bl5yVJmT0pO+VmUoyiQvUai/Kn5rdT5BMs8Z4l6cIZrvIVB554egHpAtV7cOSStrya6ksNDN5f3RAltlCEsV52GQe8pno0zSsige+TFj1Cn+ZBb5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(39860400002)(376002)(346002)(396003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(6512007)(6506007)(1076003)(2616005)(6486002)(478600001)(52116002)(6666004)(4744005)(7416002)(2906002)(5660300002)(41300700001)(66946007)(66556008)(66476007)(316002)(4326008)(8936002)(8676002)(38100700002)(38350700005)(86362001)(36756003)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FhwI5jK8lk5xtvcwbm2wORVAu1+1ihHUlYvOrsjvz+sVTyLzxh46Q4/gB/yKYDl8zQwZKINWABarzxRYq+FJ3/1SOqCysnaKTbLC/quLNLw73yOYUJYCMhNkTEYco9GfE0F/cdq9cEOHJJLUxs+NQHFDZ9IE7O2FaKryJysi/Cccwg4B30fhL4xqy+rXWksjc+zA/ucq3SlJrSn1igO0S8IvqH+TLylgkj6dMWDEJ0JB0XwCxGQ65GyedRvZfSxkyCylHOBAU+8MbgvScGQLJiQluuNSqLh8Jkx+XZjKR2wpqUiklFOukl0zX3kn8njuC5HZnoOBqWSRkPGXiIO4VqXmEFIMtcGsQ2MfXW025dDM+Ho2H6m8WKJVfcui/BSIuViTAayLs5fbG1cgn7sHnO6befeMvOX0ND6Vol8ecClZC012uPJ1KreNA/OQVCfsnjfIOoAyezLpbEV3Hz3gcAjWLxALoRgB28k3cI60SZNxzzp4wIoL3v1L+uH4X3H+822BsZm5OPTzht5LRZOCmfYLHP563fmZAU1uyPDZ6taIOhu3gin4ml+pDIIcVBF6ogwODNVBKVt44WfcmRxW4uDNUhDn4wYoEMubXGnhs3BRAau9c5aTPWiF3MXNXqoFwHDsY7oEi3D39qxoL2q4iFGIuoN/ZumQhRa6FU5Ai7HKy22mx6wO4hW2PoZIvvIQ4nGaDEaxStCnw253MJDi1cm5FgINJbLX2STSh/vk5G8qKHgILYY/K1uoX7z4O6UUKp+BDB4sirgclCyIXzz1gOPTgjigwXaD+LPHgqKC4Pti0XESlyp3kCSJJ5TcxpzJE9aYCSF+HIaFZwdPItBb4MCqMlEEegJZzgHIzD6FIWF/qPgjgVKI/3j20Vb/UbL1lpY1PjPoE2HULqOYf3RFEdm85u0j8X39MBMJgzhKzqNMwT6vuOtpLy3GxY/+1lZt2iKKS6qNEh0PMfQIZbM33BtzRqiUIi0HAZxW6UoGFud0kjQq3vhMJDAIfFBxcEwOkSIypig9VSQ46LxXVphsERBFzFfoH2ey+OSSFYUn883v+Mgt8f4726v0GkfqtbD0TlN2ztxqcEmjGYVWxqwVH+qhpMPUGU3j7jLuuX47aZ9WwOGLv9ZJydPcsOg6ZAkiFa9C88OGKL7AGqa176YZVgvPeZIbyFanLm7YVo9rTXFGnE9WvvhKxExzsZkTY9c2GggfTsZw7SSFP2LcJUZ+fJCw6YE8vakh4Uj3/c16ZJJvh/JqdG0HozpXHLvSD9HlVhfMmnp5KNpo2bGIGxJGLMKtNtMROmkeT15XFbovCWCpqGD7gYfgwiUMGaLs9kcq+aoQslhH6ymhmGye52w/nWnDZBM4a1RVb4ujGbu4UOD7O+zjipLFJxi2iY+gABWhtJkBAkyAdftzaOgRT2P61GYMrFdnDdU73c0H3PQ45sXqO3vRiiVN0N++BuULwfnqo349TJb1N9j8M9vtu81Gj6Kk6kFjjZDKBjyeH51m3jhgB3qawaqTRWSOuV8dMBIGttwtelcCecQ7Ei8eYUBJu/d47IAn7aZ83DB+M6p/9bKcYlpuyArzreo7MzAtKLFi X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05668dcf-cf8a-4525-b087-08dbef071f21 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 05:10:07.2510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HAz6MsCAZfx5tfOCjkg/mSKjan0upAJLZP1WWtwa+yM21R6i8syeXpQJegXzBbFIhQeX7Du+WGcPVeN7cMlM1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6961 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 26 Nov 2023 21:10:38 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783692620569257833 X-GMAIL-MSGID: 1783692620569257833 |
Series |
drm/bridge: panel: Check device dependency before managing device link
|
|
Commit Message
Liu Ying
Nov. 27, 2023, 5:14 a.m. UTC
Export device_is_dependent() since the drm_kms_helper module is starting
to use it.
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v2:
* Newly introduced as needed by patch 2.
drivers/base/core.c | 1 +
1 file changed, 1 insertion(+)
Comments
Greg, Rafael, On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > Export device_is_dependent() since the drm_kms_helper module is starting > to use it. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > v2: > * Newly introduced as needed by patch 2. > > drivers/base/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 67ba592afc77..bfd2bf0364b7 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -328,6 +328,7 @@ int device_is_dependent(struct device *dev, void *target) > } > return ret; > } > +EXPORT_SYMBOL_GPL(device_is_dependent); So, a committer just applied this to drm-misc-fixes without your approval. Could you ack it? If you don't want to, we'll fix it. Maxime
On Mon, Nov 27, 2023 at 05:38:13PM +0100, Maxime Ripard wrote: > Greg, Rafael, > > On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > > Export device_is_dependent() since the drm_kms_helper module is starting > > to use it. > > > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > > --- > > v2: > > * Newly introduced as needed by patch 2. > > > > drivers/base/core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/base/core.c b/drivers/base/core.c > > index 67ba592afc77..bfd2bf0364b7 100644 > > --- a/drivers/base/core.c > > +++ b/drivers/base/core.c > > @@ -328,6 +328,7 @@ int device_is_dependent(struct device *dev, void *target) > > } > > return ret; > > } > > +EXPORT_SYMBOL_GPL(device_is_dependent); > > So, a committer just applied this to drm-misc-fixes without your > approval. Could you ack it? If you don't want to, we'll fix it. Wait, why exactly is this needed? Nothing outside of the driver core should be needing this function, it shouldn't be public at all (I missed that before.) So please, revert it for now, let's figure out why DRM thinks this is needed for it's devices, and yet no other bus/subsystem does. thanks, greg k-h
On Mon, Nov 27, 2023 at 7:20 PM Greg KH <gregkh@linuxfoundation.org> wrote: [Maxime] > > So, a committer just applied this to drm-misc-fixes without your > > approval. That was me, mea culpa. I learned a lesson. Or two. > Wait, why exactly is this needed? Nothing outside of the driver core > should be needing this function, it shouldn't be public at all (I missed > that before.) > > So please, revert it for now, let's figure out why DRM thinks this is > needed for it's devices, and yet no other bus/subsystem does. I'm preparing a revert series back to the original patch causing the issue so we can clear the original bug out of the way, take a step back and fix this properly. Yours, Linus Walleij
diff --git a/drivers/base/core.c b/drivers/base/core.c index 67ba592afc77..bfd2bf0364b7 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -328,6 +328,7 @@ int device_is_dependent(struct device *dev, void *target) } return ret; } +EXPORT_SYMBOL_GPL(device_is_dependent); static void device_link_init_status(struct device_link *link, struct device *consumer,